Skip to contentSkip to conversation

staging: fbtft: use %pe for backlight errors

PATCH In review Keefe Reeves 3 participants 3 messages Jun 14 – Jul 7

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: fbtft: use %pe for backlight errors

Coccinelle found two places where backlight registration errors are printed by passing PTR_ERR() to dev_err().

Use %pe instead so the error pointer can be printed directly. This keeps the behavior the same and just makes the error printing cleaner.

---
Changes in v2:
- Use reachable Gmail address for author and Signed-off-by.

 drivers/staging/fbtft/fb_ssd1351.c | 4 ++--
 drivers/staging/fbtft/fbtft-core.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/fbtft/fb_ssd1351.c +2 -2
index 6736b09b2f45..b6cb60f20b11 100644
@@ -218,8 +218,8 @@ static void register_onboard_backlight(struct fbtft_par *par)
 				       &bl_props);
 	if (IS_ERR(bd)) {
 		dev_err(par->info->device,
-			"cannot register backlight device (%ld)\n",
-			PTR_ERR(bd));
+			"cannot register backlight device (%pe)\n",
+			bd);
 		return;
 	}
 	par->info->bl_dev = bd;
drivers/staging/fbtft/fbtft-core.c +2 -2
index 3da42c8ca6e3..b6a846ada3e0 100644
@@ -187,8 +187,8 @@ void fbtft_register_backlight(struct fbtft_par *par)
 				       &fbtft_bl_ops, &bl_props);
 	if (IS_ERR(bd)) {
 		dev_err(par->info->device,
-			"cannot register backlight device (%ld)\n",
-			PTR_ERR(bd));
+			"cannot register backlight device (%pe)\n",
+			bd);
 		return;
 	}
 	par->info->bl_dev = bd;
Signature · 1 line
2.54.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 6 lines · Keefe Reeves

Coccinelle found two places where backlight registration errors are printed by passing PTR_ERR() to dev_err().

Use %pe instead so the error pointer can be printed directly. This keeps the behavior the same and just makes the error printing cleaner.

Oh, nice! Now

(for curious ones: you can also see my comment against v1 of this patch).

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#2 lore raw
In reply to Keefe Reeves
Quoted 10 lines · Keefe Reeves

Coccinelle found two places where backlight registration errors are printed by passing PTR_ERR() to dev_err().

Use %pe instead so the error pointer can be printed directly. This keeps the behavior the same and just makes the error printing cleaner.

---
Changes in v2:
- Use reachable Gmail address for author and Signed-off-by.

Does not apply to my tree :(