Rewrite fw_load test using new API
v7 cover Rewrite fw_load test using new API
Support immutable distribution by splitting test in two:
- fw_load01 triggers request_firmware on /lib/firmware (read-only on immutable distributions) and it doesn't support read-only filesystems
- fw_load02 triggers request_firmware on custom path (always supported by any distribution)
---
Changes in v7:
- simplify test result logic
- fw_load01 and fw_load02 are now sharing the same test function
- Link to v6: https://lore.kernel.org/r/[email protected]
Changes in v6:
- add commit for git mv mergin both test and kernel module into fw_load folder
- fix fw_load02 fw_path setup
- Link to v5: https://lore.kernel.org/r/[email protected]
Changes in v5:
- rebase since apply is failing
- Link to v4: https://lore.kernel.org/r/[email protected]
Changes in v4:
- verify /lib/firmware/update was created by our test
- fix algorithm op order in fw_load02
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- fix bisecting
- fix algorithm op order
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- fix fw_load.h define
- fix Makefile copyright position
- fix year in the firmware file
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Andrea Cervesato (4):
fw_load: Modernize ltp_fw_load kernel module
fw_load: rewrite test using new LTP API
fw_load: merge module and test into fw_load folder
fw_load: add fw_load02 for custom firmware path
runtest/kernel_misc | 3 +-
.../{fw_load_kernel => fw_load}/.gitignore | 2 +
testcases/kernel/firmware/fw_load/Makefile | 25 +++
testcases/kernel/firmware/fw_load/fw_load.h | 87 +++++++++
testcases/kernel/firmware/fw_load/fw_load01.c | 111 +++++++++++
testcases/kernel/firmware/fw_load/fw_load02.c | 93 +++++++++
testcases/kernel/firmware/fw_load/ltp_fw_load.c | 178 +++++++++++++++++
testcases/kernel/firmware/fw_load_kernel/Makefile | 35 ----
testcases/kernel/firmware/fw_load_kernel/README | 16 --
.../kernel/firmware/fw_load_kernel/ltp_fw_load.c | 164 ----------------
testcases/kernel/firmware/fw_load_user/.gitignore | 1 -
testcases/kernel/firmware/fw_load_user/Makefile | 20 --
testcases/kernel/firmware/fw_load_user/README | 11 --
testcases/kernel/firmware/fw_load_user/fw_load.c | 213 ---------------------
14 files changed, 498 insertions(+), 461 deletions(-)---
base-commit: 548a05c01137580d621d56a02ce00e33dc44e859
change-id: 20260609-fw_load-2882088bec8e
Best regards,
Signature · 5 lines
Andrea Cervesato <[email protected]> -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v7 1/4 fw_load: Modernize ltp_fw_load kernel module
From: Andrea Cervesato <[email protected]>
Fix VLA (banned since kernel v4.20), replace sscanf() with kstrtoint(), reset test_result between invocations, make the loop variable local and pass expected data explicitly.
Update license headers, fix brace style, drop obsolete README in favour of the in-source documentation.
--- testcases/kernel/firmware/fw_load_kernel/Makefile | 16 +-- testcases/kernel/firmware/fw_load_kernel/README | 16 --- .../kernel/firmware/fw_load_kernel/ltp_fw_load.c | 114 ++++++++++++--------- 3 files changed, 66 insertions(+), 80 deletions(-)
testcases/kernel/firmware/fw_load_kernel/Makefile +2 -14
@@ -1,18 +1,6 @@ # Copyright (c) 2013 Oracle and/or its affiliates. All Rights Reserved. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it would be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write the Free Software Foundation, -# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# Copyright (c) Linux Test Project, 2026 +# SPDX-License-Identifier: GPL-2.0-or-later ifneq ($(KERNELRELEASE),)
testcases/kernel/firmware/fw_load_kernel/README deleted +0 -16
@@ -1,16 +0,0 @@ -The aim of the test is to check device firmware loading. Since kernel 3.7 -firmware loading changed to direct loading (by-pass udev). The test consists -of the two parts: - - userspace part - - kernelspace part - -This is a kernel module, which is a part of the device firmware loading test. -It allows to call request_firmware kernel function with specified parameters. -Template firmware file name and expected firmware file's data size are passed -as the insmod command line parameters. Then, the number of firmware test files -should be written to sysfs file 'fwnum' (the maximum number is 32). This write -will initiate request firmware procedure. In the end, results can be read from -'result' device sysfs file. Also, some information regarding module loading, -can be obtained by looking at kernel log file. - -It is automatically used by userspace part of the test.
testcases/kernel/firmware/fw_load_kernel/ltp_fw_load.c +64 -50
203 lines not on this page · raw message
Signature · 5 lines
2.51.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] fw_load: Modernize ltp_fw_load kernel module
Hi Andrea,
Quoted 1 line · Andrea Cervesato
fw_load: Modernizeltp_fw_loadkernel module
Verdict - Reviewed
---
Note:
The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v7 1/4] fw_load: Modernize ltp_fw_load kernel module
In reply to Andrea CervesatoHi!
For the whole patchset:
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v7 1/4] fw_load: Modernize ltp_fw_load kernel module
Fixed year in 1/4 patch and merged. Thanks.
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v7 2/4 fw_load: rewrite test using new LTP API
In reply to Andrea CervesatoFrom: Andrea Cervesato <[email protected]>
Remove the obsolete user-helper and create a fw_load.h where to store the firmware support information.
--- testcases/kernel/firmware/fw_load_user/Makefile | 18 +- testcases/kernel/firmware/fw_load_user/README | 11 - testcases/kernel/firmware/fw_load_user/fw_load.c | 286 ++++++++++------------- testcases/kernel/firmware/fw_load_user/fw_load.h | 18 ++ 4 files changed, 140 insertions(+), 193 deletions(-)
testcases/kernel/firmware/fw_load_user/Makefile +3 -15
@@ -1,20 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later # Copyright (c) 2013 Oracle and/or its affiliates. All Rights Reserved. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it would be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write the Free Software Foundation, -# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# Copyright (c) Linux Test Project, 2026 -top_srcdir ?= ../../../.. +top_srcdir ?= ../../../.. include $(top_srcdir)/include/mk/testcases.mk include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/firmware/fw_load_user/README deleted +0 -11
@@ -1,11 +0,0 @@ -The aim of the test is to check device firmware loading. Since kernel 3.7 -firmware loading changed to direct loading (by-pass udev). The test consists -of the two parts: - - userspace part - - kernelspace part - -This is the userspace part, its tasks are: - - create firmware files in the standard firmware paths - - load the module and initiate firmware request procedure - - read device's result file and print final results - - unload the module.
testcases/kernel/firmware/fw_load_user/fw_load.c +119 -167
332 lines not on this page · raw message
testcases/kernel/firmware/fw_load_user/fw_load.h new file +18 -0
@@ -0,0 +1,18 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Copyright (c) 2026 SUSE LLC Andrea Cervesato <[email protected]> +*/ + +#ifndef FW_LOAD_H +#define FW_LOAD_H + +#define MNAME_KO "ltp_fw_load.ko" +#define FW_NAME "load_tst.fw" +#define FW_SIZE 0x1000 +#define FW_NUM 5 +#define FW_PATH "/sys/module/firmware_class/parameters/path" +#define DEV_FWNUM "/sys/devices/ltp_fw_load/fwnum" +#define DEV_RESULT "/sys/devices/ltp_fw_load/result" +#define LIB_PATH "/lib/firmware" + +#endif
Signature · 5 lines
2.51.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v7 3/4 fw_load: merge module and test into fw_load folder
In reply to Andrea CervesatoFrom: Andrea Cervesato <[email protected]>
Rename fw_load test into fw_load01 and move it into the fw_load folder within ltp_fw_load.ko module.
---
runtest/kernel_misc | 2 +-
testcases/kernel/firmware/{fw_load_kernel => fw_load}/.gitignore | 1 +
testcases/kernel/firmware/{fw_load_kernel => fw_load}/Makefile | 8 +++++---
testcases/kernel/firmware/{fw_load_user => fw_load}/fw_load.h | 0
.../firmware/{fw_load_user/fw_load.c => fw_load/fw_load01.c} | 0
.../kernel/firmware/{fw_load_kernel => fw_load}/ltp_fw_load.c | 0
testcases/kernel/firmware/fw_load_user/.gitignore | 1 -
testcases/kernel/firmware/fw_load_user/Makefile | 8 --------
8 files changed, 7 insertions(+), 13 deletions(-)runtest/kernel_misc +1 -1
@@ -1,6 +1,6 @@ cn_pec_sh cn_pec.sh kmsg01 kmsg01 -fw_load fw_load +fw_load01 fw_load01 rtc01 rtc01 rtc02 rtc02 block_dev block_dev
testcases/kernel/firmware/fw_load/.gitignore renamed from testcases/kernel/firmware/fw_load_kernel/.gitignore +1 -0
@@ -5,3 +5,4 @@ /ltp_fw_load.mod.c /.tmp_versions/ modules.livepatch +fw_load01
testcases/kernel/firmware/fw_load/Makefile renamed from testcases/kernel/firmware/fw_load_kernel/Makefile +5 -3
@@ -1,6 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-or-later # Copyright (c) 2013 Oracle and/or its affiliates. All Rights Reserved. # Copyright (c) Linux Test Project, 2026 -# SPDX-License-Identifier: GPL-2.0-or-later ifneq ($(KERNELRELEASE),)
@@ -11,11 +11,13 @@ endif else top_srcdir ?= ../../../.. -include $(top_srcdir)/include/mk/env_pre.mk + +include $(top_srcdir)/include/mk/testcases.mk REQ_VERSION_MAJOR := 3 REQ_VERSION_PATCH := 7 -MAKE_TARGETS := ltp_fw_load.ko + +MAKE_TARGETS := fw_load01 ltp_fw_load.ko include $(top_srcdir)/include/mk/module.mk include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/firmware/fw_load/fw_load.h renamed from testcases/kernel/firmware/fw_load_user/fw_load.h +0 -0
testcases/kernel/firmware/fw_load/fw_load01.c renamed from testcases/kernel/firmware/fw_load_user/fw_load.c +0 -0
testcases/kernel/firmware/fw_load/ltp_fw_load.c renamed from testcases/kernel/firmware/fw_load_kernel/ltp_fw_load.c +0 -0
testcases/kernel/firmware/fw_load_user/.gitignore deleted +0 -1
@@ -1 +0,0 @@ -/fw_load
testcases/kernel/firmware/fw_load_user/Makefile deleted +0 -8
@@ -1,8 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-or-later -# Copyright (c) 2013 Oracle and/or its affiliates. All Rights Reserved. -# Copyright (c) Linux Test Project, 2026 - -top_srcdir ?= ../../../.. - -include $(top_srcdir)/include/mk/testcases.mk -include $(top_srcdir)/include/mk/generic_leaf_target.mk
Signature · 5 lines
2.51.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v7 4/4 fw_load: add fw_load02 for custom firmware path
In reply to Andrea CervesatoFrom: Andrea Cervesato <[email protected]>
Add fw_load02 which points the kernel firmware loader at the writable LTP temporary directory via /sys/module/firmware_class/parameters/path. Unlike fw_load01, it does not rely on a writable /lib/firmware and so works on read-only and immutable root filesystems while still exercising request_firmware() for both successful loads and the not-found case.
Move test inside the header so both fw_load01 and fw_load02 will share the same test function.
--- runtest/kernel_misc | 1 + testcases/kernel/firmware/fw_load/.gitignore | 1 + testcases/kernel/firmware/fw_load/Makefile | 2 +- testcases/kernel/firmware/fw_load/fw_load.h | 69 ++++++++++++++++++++ testcases/kernel/firmware/fw_load/fw_load01.c | 72 +++------------------ testcases/kernel/firmware/fw_load/fw_load02.c | 93 +++++++++++++++++++++++++++ 6 files changed, 174 insertions(+), 64 deletions(-)
runtest/kernel_misc +1 -0
@@ -1,6 +1,7 @@ cn_pec_sh cn_pec.sh kmsg01 kmsg01 fw_load01 fw_load01 +fw_load02 fw_load02 rtc01 rtc01 rtc02 rtc02 block_dev block_dev
testcases/kernel/firmware/fw_load/.gitignore +1 -0
@@ -6,3 +6,4 @@ /.tmp_versions/ modules.livepatch fw_load01 +fw_load02
testcases/kernel/firmware/fw_load/Makefile +1 -1
@@ -17,7 +17,7 @@ include $(top_srcdir)/include/mk/testcases.mk REQ_VERSION_MAJOR := 3 REQ_VERSION_PATCH := 7 -MAKE_TARGETS := fw_load01 ltp_fw_load.ko +MAKE_TARGETS := fw_load01 fw_load02 ltp_fw_load.ko include $(top_srcdir)/include/mk/module.mk include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/firmware/fw_load/fw_load.h +69 -0
79 lines not on this page · raw message
testcases/kernel/firmware/fw_load/fw_load01.c +9 -63
102 lines not on this page · raw message
testcases/kernel/firmware/fw_load/fw_load02.c new file +93 -0
93 lines not on this page · raw message
Signature · 5 lines
2.51.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp