Skip to contentSkip to conversation

hw/nvme: support online resize

PATCH Superseded Alexander Mikhalitsyn 1 participant 4 messages Jun 15 – Jul 17

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover hw/nvme: support online resize

From: Alexander Mikhalitsyn <[email protected]>

Dear friends,

This patchset is aimed to support online resize for NVMe emulated device. My approach is simple - I just implement (BlockDevOps *)->resize_cb() callback and ensure that AER notification is fired to all controllers using a namespace that is being resized.

Testing.

I manually validated this with Debian 13 VM (a resized disk was a root disk) and Windows Server 2022 (a resized disk was a secondary one).

Git tree:
https://gitlab.com/mihalicyn/qemu/-/commits/nvme-resize

Changelog for version 2:
- checkpatch fixes
- rebased
- CI is green (https://gitlab.com/mihalicyn/qemu/-/pipelines/2602102750)

Kind regards,
Alex

Alexander Mikhalitsyn (2):
hw/nvme: initialize ns->subsys for n->namespace
hw/nvme: support online resize

 hw/nvme/ctrl.c | 10 ++++++++
 hw/nvme/ns.c   | 68 +++++++++++++++++++++++++++++++++++++++++++++++++-
 hw/nvme/nvme.h |  2 ++
 3 files changed, 79 insertions(+), 1 deletion(-)
Signature · 1 line
2.47.3
#1 lore raw

PATCH v2 1/2 hw/nvme: initialize ns->subsys for n->namespace

From: Alexander Mikhalitsyn <[email protected]>

We must properly initialize n->namespace.subsys too.

Will be important in the following patches.

---
 hw/nvme/ctrl.c | 1 +
 1 file changed, 1 insertion(+)
hw/nvme/ctrl.c +1 -0
index 815f39173c8..391f8260fc2 100644
@@ -9331,6 +9331,7 @@ static void nvme_realize(PCIDevice *pci_dev, Error **errp)
         ns = &n->namespace;
         ns->params.nsid = 1;
         ns->ctrl = n;
+        ns->subsys = n->subsys;
 
         if (nvme_ns_setup(ns, errp)) {
             return;
Signature · 1 line
2.47.3
#2 lore raw

PATCH v2 2/2 hw/nvme: support online resize

In reply to Alexander Mikhalitsyn

From: Alexander Mikhalitsyn <[email protected]>

Implement (BlockDevOps *)->resize_cb() for NVMe namespace to enable online resize support.

We must handle cases when multiple namespaces are attached to a single controller, or namespace is shared across a few different controllers by iterating over controllers attached to a NvmeSubsystem and properly notify every controller about a size change.

---
v2:
- check-patch fixes

---
 hw/nvme/ctrl.c |  9 +++++++
 hw/nvme/ns.c   | 68 +++++++++++++++++++++++++++++++++++++++++++++++++-
 hw/nvme/nvme.h |  2 ++
 3 files changed, 78 insertions(+), 1 deletion(-)
hw/nvme/ctrl.c +9 -0
index 391f8260fc2..d329276e127 100644
@@ -6898,6 +6898,15 @@ static uint16_t nvme_ns_attachment(NvmeCtrl *n, NvmeRequest *req)
     return NVME_SUCCESS;
 }
 
+void nvme_ctrl_notify_ns_resize(NvmeCtrl *ctrl, NvmeNamespace *ns)
+{
+    if (!test_and_set_bit(ns->params.nsid, ctrl->changed_nsids)) {
+        nvme_enqueue_event(ctrl, NVME_AER_TYPE_NOTICE,
+                           NVME_AER_INFO_NOTICE_NS_ATTR_CHANGED,
+                           NVME_LOG_CHANGED_NSLIST);
+    }
+}
+
 typedef struct NvmeFormatAIOCB {
     BlockAIOCB common;
     BlockAIOCB *aiocb;
hw/nvme/ns.c +67 -1

83 lines not on this page · raw message

hw/nvme/nvme.h +2 -0
index 5ef3ebee29e..ac94cc72c0f 100644
@@ -748,4 +748,6 @@ void nvme_atomic_configure_max_write_size(bool dn, uint16_t awun,
 void nvme_ns_atomic_configure_boundary(bool dn, uint16_t nabsn,
                                        uint16_t nabspf, NvmeAtomic *atomic);
 
+void nvme_ctrl_notify_ns_resize(NvmeCtrl *ctrl, NvmeNamespace *ns);
+
 #endif /* HW_NVME_NVME_H */
Signature · 1 line
2.47.3
#3 lore raw
In reply to Alexander Mikhalitsyn

Gentle ping

Kind regards,
Alex

Am Mo., 15. Juni 2026 um 16:12 Uhr schrieb Alexander Mikhalitsyn <[email protected]>:

Quoted 38 lines

From: Alexander Mikhalitsyn <[email protected]>

Dear friends,

This patchset is aimed to support online resize for NVMe emulated device. My approach is simple - I just implement (BlockDevOps *)->resize_cb() callback and ensure that AER notification is fired to all controllers using a namespace that is being resized.

Testing.

I manually validated this with Debian 13 VM (a resized disk was a root disk) and Windows Server 2022 (a resized disk was a secondary one).

Git tree:
https://gitlab.com/mihalicyn/qemu/-/commits/nvme-resize

Changelog for version 2:
- checkpatch fixes
- rebased
- CI is green (https://gitlab.com/mihalicyn/qemu/-/pipelines/2602102750)

Kind regards,
Alex

Alexander Mikhalitsyn (2):
hw/nvme: initialize ns->subsys for n->namespace
hw/nvme: support online resize

 hw/nvme/ctrl.c | 10 ++++++++
 hw/nvme/ns.c   | 68 +++++++++++++++++++++++++++++++++++++++++++++++++-
 hw/nvme/nvme.h |  2 ++
 3 files changed, 79 insertions(+), 1 deletion(-)

--
2.47.3