Skip to contentSkip to conversation

ufs: Add HS_GEAR6 string in power_info/gear sysfs output

PATCH Superseded himanshubatra 5 participants 10 messages Jun 15 – Jul 29

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ufs: Add HS_GEAR6 string in power_info/gear sysfs output

In power_info/gear sysfs, currently it supports output only till gear 5. If operating mode is gear 6, it is giving output as "UNKNOWN". Add support for HS_GEAR6 string in sysfs output when operating mode is gear 6.

---
 drivers/ufs/core/ufs-sysfs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/ufs/core/ufs-sysfs.c +1 -0
index 99af3c73f1af..d1f5041fc3c8 100644
@@ -54,6 +54,7 @@ static const char *ufs_hs_gear_to_string(enum ufs_hs_gear_tag gear)
 	case UFS_HS_G3:	return "HS_GEAR3";
 	case UFS_HS_G4:	return "HS_GEAR4";
 	case UFS_HS_G5:	return "HS_GEAR5";
+	case UFS_HS_G6:	return "HS_GEAR6";
 	default:	return "UNKNOWN";
 	}
 }
Signature · 1 line
2.54.0.1189.g8c84645362-goog
#1 lore raw

scsi: ufs: sysfs: Add ....

Quoted 3 lines · himanshubatra

In power_info/gear sysfs, currently it supports output only till gear 5. If operating mode is gear 6, it is giving output as "UNKNOWN".

it outputs "UNKNOWN"

Quoted 23 lines

Add support for HS_GEAR6 string in sysfs output when operating mode is gear 6.

---
 drivers/ufs/core/ufs-sysfs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/ufs/core/ufs-sysfs.c +1 -1
index 99af3c73f1af..d1f5041fc3c8 100644
@@ -54,6 +54,7 @@ static const char *ufs_hs_gear_to_string(enum ufs_hs_gear_tag gear)
        case UFS_HS_G3: return "HS_GEAR3";
        case UFS_HS_G4: return "HS_GEAR4";
        case UFS_HS_G5: return "HS_GEAR5";
+       case UFS_HS_G6: return "HS_GEAR6";
        default:        return "UNKNOWN";
        }
 }
--

2.54.0.1189.g8c84645362-goog

#2 lore raw
Quoted 3 lines · VAMSHI GAJJELA

scsi: ufs: sysfs: Add ....

Done in v2

Quoted 5 lines · himanshubatra
Quoted 3 lines

In power_info/gear sysfs, currently it supports output only till gear 5. If operating mode is gear 6, it is giving output as "UNKNOWN".

it outputs "UNKNOWN"

Done in v2

Quoted 23 lines
Quoted 23 lines

Add support for HS_GEAR6 string in sysfs output when operating mode is gear 6.

---
 drivers/ufs/core/ufs-sysfs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/ufs/core/ufs-sysfs.c +1 -1
index 99af3c73f1af..d1f5041fc3c8 100644
@@ -54,6 +54,7 @@ static const char *ufs_hs_gear_to_string(enum ufs_hs_gear_tag gear)
        case UFS_HS_G3: return "HS_GEAR3";
        case UFS_HS_G4: return "HS_GEAR4";
        case UFS_HS_G5: return "HS_GEAR5";
+       case UFS_HS_G6: return "HS_GEAR6";
        default:        return "UNKNOWN";
        }
 }
--

2.54.0.1189.g8c84645362-goog

#3 lore raw

PATCH v2 1/1 scsi: ufs: sysfs: Add HS_GEAR6 string in power_info/gear sysfs output

In power_info/gear sysfs, currently it supports output only till gear 5. If operating mode is gear 6, it outputs "UNKNOWN".
Add support for HS_GEAR6 string in sysfs output when operating mode is gear 6.

---

Changes in v2:
- A slightly better comment.

 drivers/ufs/core/ufs-sysfs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/ufs/core/ufs-sysfs.c +1 -0
index 99af3c73f1af..d1f5041fc3c8 100644
@@ -54,6 +54,7 @@ static const char *ufs_hs_gear_to_string(enum ufs_hs_gear_tag gear)
 	case UFS_HS_G3:	return "HS_GEAR3";
 	case UFS_HS_G4:	return "HS_GEAR4";
 	case UFS_HS_G5:	return "HS_GEAR5";
+	case UFS_HS_G6:	return "HS_GEAR6";
 	default:	return "UNKNOWN";
 	}
 }
Signature · 1 line
2.54.0.1189.g8c84645362-goog
#4 lore raw

Re: [PATCH v2] scsi: ufs: sysfs: Add HS_GEAR6 string in power_info/gear sysfs output

Quoted 30 lines · himanshubatra

In power_info/gear sysfs, currently it supports output only till gear 5. If operating mode is gear 6, it outputs "UNKNOWN".
Add support for HS_GEAR6 string in sysfs output when operating mode is gear 6.

---

Changes in v2:
- A slightly better comment.

 drivers/ufs/core/ufs-sysfs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/ufs/core/ufs-sysfs.c +1 -0
index 99af3c73f1af..d1f5041fc3c8 100644
@@ -54,6 +54,7 @@ static const char *ufs_hs_gear_to_string(enum ufs_hs_gear_tag gear)
 	case UFS_HS_G3:	return "HS_GEAR3";
 	case UFS_HS_G4:	return "HS_GEAR4";
 	case UFS_HS_G5:	return "HS_GEAR5";
+	case UFS_HS_G6:	return "HS_GEAR6";
 	default:	return "UNKNOWN";
 	}
 }
Signature · 1 line
2.54.0.1189.g8c84645362-goog

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- It looks like you did not use your "real" name for the patch on either the Signed-off-by: line, or the From: line (both of which have to match). Please read the kernel file, Documentation/process/submitting-patches.rst for how to do this correctly.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

#5 lore raw

PATCH v3 1/1 scsi: ufs: sysfs: Add HS_GEAR6 string in power_info/gear sysfs output

In power_info/gear sysfs, currently it supports output only till gear 5. If operating mode is gear 6, it outputs "UNKNOWN".
Add support for HS_GEAR6 string in sysfs output when operating mode is gear 6.

---

Changes in v3:
- Fixed the identity alignment issue: updated both the 'From:' line and 'Signed-off-by:' tag to use my full real name ("Himanshu Batra")

Changes in v2:
- A slightly better comment.

 drivers/ufs/core/ufs-sysfs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/ufs/core/ufs-sysfs.c +1 -0
index 99af3c73f1af..d1f5041fc3c8 100644
@@ -54,6 +54,7 @@ static const char *ufs_hs_gear_to_string(enum ufs_hs_gear_tag gear)
 	case UFS_HS_G3:	return "HS_GEAR3";
 	case UFS_HS_G4:	return "HS_GEAR4";
 	case UFS_HS_G5:	return "HS_GEAR5";
+	case UFS_HS_G6:	return "HS_GEAR6";
 	default:	return "UNKNOWN";
 	}
 }
Signature · 1 line
2.54.0.1189.g8c84645362-goog
reviewer Reviewed-by on v3 1/1
#6 lore raw

Re: [PATCH v3] scsi: ufs: sysfs: Add HS_GEAR6 string in power_info/gear sysfs output

Quoted 4 lines · Himanshu Batra

In power_info/gear sysfs, currently it supports output only till gear 5. If operating mode is gear 6, it outputs "UNKNOWN".
Add support for HS_GEAR6 string in sysfs output when operating mode is gear 6.

Some general advice:
- New versions of a patch should be posted as a new email thread instead of as a reply to an existing email conversation. Replies to an existing email conversation tend to get overlooked.
- At least 24 hours should elapse before a new version of a patch is posted. Otherwise reviewers who are in another time zone don't have the chance to reply. For large patch series, more time should elapse between reposts (e.g. one week).
- The "scsi:" prefix is no longer used for UFS kernel patches.

Since the code changes look good to me:

#7 lore raw

Re: [PATCH v3] scsi: ufs: sysfs: Add HS_GEAR6 string in power_info/gear sysfs output

Quoted 7 lines · Bart Van Assche
Quoted 4 lines · Himanshu Batra

In power_info/gear sysfs, currently it supports output only till gear 5. If operating mode is gear 6, it outputs "UNKNOWN".
Add support for HS_GEAR6 string in sysfs output when operating mode is gear 6.

Quoted 9 lines

Some general advice:
- New versions of a patch should be posted as a new email thread instead of as a reply to an existing email conversation. Replies to an existing email conversation tend to get overlooked.
- At least 24 hours should elapse before a new version of a patch is posted. Otherwise reviewers who are in another time zone don't have the chance to reply. For large patch series, more time should elapse between reposts (e.g. one week).
- The "scsi:" prefix is no longer used for UFS kernel patches.

Acked, I will follow this for future contributions.

Quoted 5 lines

Since the code changes look good to me:

#8 lore raw

Re: [PATCH v3] scsi: ufs: sysfs: Add HS_GEAR6 string in power_info/gear sysfs output

In reply to Himanshu Batra

Himanshu,

Quoted 3 lines

In power_info/gear sysfs, currently it supports output only till gear
5. If operating mode is gear 6, it outputs "UNKNOWN". Add support for HS_GEAR6 string in sysfs output when operating mode is gear 6.

Applied to 7.3/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen
#9 lore raw

Re: [PATCH v3] scsi: ufs: sysfs: Add HS_GEAR6 string in power_info/gear sysfs output

In reply to Himanshu Batra
Quoted 6 lines · Himanshu Batra

In power_info/gear sysfs, currently it supports output only till gear 5. If operating mode is gear 6, it outputs "UNKNOWN".
Add support for HS_GEAR6 string in sysfs output when operating mode is gear 6.

Applied to 7.3/scsi-queue, thanks!

[1/1] scsi: ufs: sysfs: Add HS_GEAR6 string in power_info/gear sysfs output

      https://git.kernel.org/mkp/scsi/c/78f638ff3bc1
Signature · 1 line
Martin K. Petersen