binder: synchronize Rust Binder stats with freeze commands

PATCH Superseded syncrain 4 participants 8 messages Jun 15

Subsystems (2)

Rust Android drivers

lore

Share & tools

lore

syncrain

author

2026-06-15 20:19 UTC #0 lore raw

PATCH 1/1 binder: synchronize Rust Binder stats with freeze commands

From: Keshav Verma <[email protected]>

Rust Binder stats use BC_COUNT and BR_COUNT to size the command and return counters, and use event string tables when printing debug statistics.

The Binder protocol includes freeze-related commands and return codes, but the Rust Binder statistics code was not updated to cover them. As a result, those commands and return codes are not accounted for or printed by the stats debug output.

Update the counts and event string tables so these commands and return codes are included in the debug statistics output.

Signed-off-by Keshav Verma <[email protected]>

---
 drivers/android/binder/rust_binder_events.c | 7 ++++++-
 drivers/android/binder/stats.rs             | 4 ++--
 2 files changed, 8 insertions(+), 3 deletions(-)

drivers/android/binder/rust_binder_events.c +6 -1

index 488b1470060c..5792aa59cc82 100644
@@ -28,6 +28,9 @@ const char * const binder_command_strings[] = {
 	"BC_DEAD_BINDER_DONE",
 	"BC_TRANSACTION_SG",
 	"BC_REPLY_SG",
+	"BC_REQUEST_FREEZE_NOTIFICATION",
+	"BC_CLEAR_FREEZE_NOTIFICATION",
+	"BC_FREEZE_NOTIFICATION_DONE",
 };
 
 const char * const binder_return_strings[] = {

@@ -51,7 +54,9 @@ const char * const binder_return_strings[] = {
 	"BR_FAILED_REPLY",
 	"BR_FROZEN_REPLY",
 	"BR_ONEWAY_SPAM_SUSPECT",
-	"BR_TRANSACTION_PENDING_FROZEN"
+	"BR_TRANSACTION_PENDING_FROZEN",
+	"BR_FROZEN_BINDER",
+	"BR_CLEAR_FREEZE_NOTIFICATION_DONE",
 };
 
 #define CREATE_TRACE_POINTS

drivers/android/binder/stats.rs +2 -2

index ab75e9561cbf..ec81dc7747db 100644
@@ -8,8 +8,8 @@
 use kernel::sync::atomic::{ordering::Relaxed, Atomic};
 use kernel::{ioctl::_IOC_NR, seq_file::SeqFile, seq_print};
 
-const BC_COUNT: usize = _IOC_NR(BC_REPLY_SG) as usize + 1;
-const BR_COUNT: usize = _IOC_NR(BR_TRANSACTION_PENDING_FROZEN) as usize + 1;
+const BC_COUNT: usize = _IOC_NR(BC_FREEZE_NOTIFICATION_DONE) as usize + 1;
+const BR_COUNT: usize = _IOC_NR(BR_CLEAR_FREEZE_NOTIFICATION_DONE) as usize + 1;
 
 pub(crate) static GLOBAL_STATS: BinderStats = BinderStats::new();

Signature · 1 line

2.39.5

Carlos Llamas

maintainer Acked-by on v1 1/1

2026-06-15 20:36 UTC #1 lore raw

Quoted 11 lines · syncrain

From: Keshav Verma <[email protected]>
Rust Binder stats use BC_COUNT and BR_COUNT to size the command and return counters, and use event string tables when printing debug statistics.
The Binder protocol includes freeze-related commands and return codes, but the Rust Binder statistics code was not updated to cover them. As a result, those commands and return codes are not accounted for or printed by the stats debug output.

Quoted 5 lines

Update the counts and event string tables so these commands and return codes are included in the debug statistics output.
Signed-off-by Keshav Verma <[email protected]>
---

IIUC, this should have tags:

Cc stable <[email protected]>

Fixes eafedbc7c050 ("rust_binder: add Rust Binder driver")

But other than that, it LGTM so:

Acked-by Carlos Llamas <[email protected]>

Thanks
--
Carlos Llamas

Alice Ryhl

maintainer Reviewed-by

2026-06-15 21:09 UTC #2 lore raw

Quoted 19 lines · Carlos Llamas

Quoted 11 lines · syncrain
From: Keshav Verma <[email protected]>
Rust Binder stats use BC_COUNT and BR_COUNT to size the command and return counters, and use event string tables when printing debug statistics.
The Binder protocol includes freeze-related commands and return codes, but the Rust Binder statistics code was not updated to cover them. As a result, those commands and return codes are not accounted for or printed by the stats debug output.
Quoted 5 lines
Update the counts and event string tables so these commands and return codes are included in the debug statistics output.
Signed-off-by Keshav Verma <[email protected]>
---

Quoted 7 lines

IIUC, this should have tags:
Cc stable <[email protected]>
Fixes eafedbc7c050 ("rust_binder: add Rust Binder driver")
But other than that, it LGTM so:
Acked-by Carlos Llamas <[email protected]>

Patch itself LGTM, so:

Reviewed-by Alice Ryhl <[email protected]>

Thanks!

Keshav Verma

author

2026-06-15 20:51 UTC #3 lore raw

PATCH v2 1/1 binder: synchronize Rust Binder stats with freeze commands

In reply to syncrain

Rust Binder stats use BC_COUNT and BR_COUNT to size the command and return counters, and use event string tables when printing debug statistics.

Update the counts and event string tables so these commands and return codes are included in the debug statistics output.

Fixes eafedbc7c050 ("rust_binder: add Rust Binder driver")

Cc [email protected]

Acked-by Carlos Llamas <[email protected]>

Signed-off-by Keshav Verma <[email protected]>

---
 drivers/android/binder/rust_binder_events.c | 7 ++++++-
 drivers/android/binder/stats.rs             | 4 ++--
 2 files changed, 8 insertions(+), 3 deletions(-)

drivers/android/binder/rust_binder_events.c +6 -1

index 488b1470060c..5792aa59cc82 100644
@@ -28,6 +28,9 @@ const char * const binder_command_strings[] = {
 	"BC_DEAD_BINDER_DONE",
 	"BC_TRANSACTION_SG",
 	"BC_REPLY_SG",
+	"BC_REQUEST_FREEZE_NOTIFICATION",
+	"BC_CLEAR_FREEZE_NOTIFICATION",
+	"BC_FREEZE_NOTIFICATION_DONE",
 };
 
 const char * const binder_return_strings[] = {

@@ -51,7 +54,9 @@ const char * const binder_return_strings[] = {
 	"BR_FAILED_REPLY",
 	"BR_FROZEN_REPLY",
 	"BR_ONEWAY_SPAM_SUSPECT",
-	"BR_TRANSACTION_PENDING_FROZEN"
+	"BR_TRANSACTION_PENDING_FROZEN",
+	"BR_FROZEN_BINDER",
+	"BR_CLEAR_FREEZE_NOTIFICATION_DONE",
 };
 
 #define CREATE_TRACE_POINTS

drivers/android/binder/stats.rs +2 -2

index ab75e9561cbf..ec81dc7747db 100644
@@ -8,8 +8,8 @@
 use kernel::sync::atomic::{ordering::Relaxed, Atomic};
 use kernel::{ioctl::_IOC_NR, seq_file::SeqFile, seq_print};
 
-const BC_COUNT: usize = _IOC_NR(BC_REPLY_SG) as usize + 1;
-const BR_COUNT: usize = _IOC_NR(BR_TRANSACTION_PENDING_FROZEN) as usize + 1;
+const BC_COUNT: usize = _IOC_NR(BC_FREEZE_NOTIFICATION_DONE) as usize + 1;
+const BR_COUNT: usize = _IOC_NR(BR_CLEAR_FREEZE_NOTIFICATION_DONE) as usize + 1;
 
 pub(crate) static GLOBAL_STATS: BinderStats = BinderStats::new();

Signature · 1 line

2.39.5

Greg KH

maintainer

2026-06-15 20:52 UTC #4 lore raw

In reply to syncrain

Quoted 64 lines · syncrain

From: Keshav Verma <[email protected]>
Rust Binder stats use BC_COUNT and BR_COUNT to size the command and return counters, and use event string tables when printing debug statistics.
The Binder protocol includes freeze-related commands and return codes, but the Rust Binder statistics code was not updated to cover them. As a result, those commands and return codes are not accounted for or printed by the stats debug output.
Update the counts and event string tables so these commands and return codes are included in the debug statistics output.
Signed-off-by Keshav Verma <[email protected]>
---
 drivers/android/binder/rust_binder_events.c | 7 ++++++-
 drivers/android/binder/stats.rs             | 4 ++--
 2 files changed, 8 insertions(+), 3 deletions(-)
drivers/android/binder/rust_binder_events.c +6 -1
index 488b1470060c..5792aa59cc82 100644
@@ -28,6 +28,9 @@ const char * const binder_command_strings[] = {
 	"BC_DEAD_BINDER_DONE",
 	"BC_TRANSACTION_SG",
 	"BC_REPLY_SG",
+	"BC_REQUEST_FREEZE_NOTIFICATION",
+	"BC_CLEAR_FREEZE_NOTIFICATION",
+	"BC_FREEZE_NOTIFICATION_DONE",
 };
 
 const char * const binder_return_strings[] = {
@@ -51,7 +54,9 @@ const char * const binder_return_strings[] = {
 	"BR_FAILED_REPLY",
 	"BR_FROZEN_REPLY",
 	"BR_ONEWAY_SPAM_SUSPECT",
-	"BR_TRANSACTION_PENDING_FROZEN"
+	"BR_TRANSACTION_PENDING_FROZEN",
+	"BR_FROZEN_BINDER",
+	"BR_CLEAR_FREEZE_NOTIFICATION_DONE",
 };
 
 #define CREATE_TRACE_POINTS
drivers/android/binder/stats.rs +2 -2
index ab75e9561cbf..ec81dc7747db 100644
@@ -8,8 +8,8 @@
 use kernel::sync::atomic::{ordering::Relaxed, Atomic};
 use kernel::{ioctl::_IOC_NR, seq_file::SeqFile, seq_print};
 
-const BC_COUNT: usize = _IOC_NR(BC_REPLY_SG) as usize + 1;
-const BR_COUNT: usize = _IOC_NR(BR_TRANSACTION_PENDING_FROZEN) as usize + 1;
+const BC_COUNT: usize = _IOC_NR(BC_FREEZE_NOTIFICATION_DONE) as usize + 1;
+const BR_COUNT: usize = _IOC_NR(BR_CLEAR_FREEZE_NOTIFICATION_DONE) as usize + 1;
 
 pub(crate) static GLOBAL_STATS: BinderStats = BinderStats::new();
 
Signature · 1 line
2.39.5

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

Keshav Verma

author

2026-06-15 21:06 UTC #5 lore raw

PATCH v3 1/1 binder: synchronize Rust Binder stats with freeze commands

In reply to syncrain

Rust Binder stats use BC_COUNT and BR_COUNT to size the command and return counters, and use event string tables when printing debug statistics.

Update the counts and event string tables so these commands and return codes are included in the debug statistics output.

Fixes eafedbc7c050 ("rust_binder: add Rust Binder driver")

Cc [email protected]

Acked-by Carlos Llamas <[email protected]>

Signed-off-by Keshav Verma <[email protected]>

---
v3:
- Add changelog for previous revisions.

v2:
- Add Fixes: tag for rust_binder introduction commit.
- Cc [email protected].
- Add Acked-by from Carlos Llamas.
- Use real name in Signed-off-by.

 drivers/android/binder/rust_binder_events.c | 7 ++++++-
 drivers/android/binder/stats.rs             | 4 ++--
 2 files changed, 8 insertions(+), 3 deletions(-)

drivers/android/binder/rust_binder_events.c +6 -1

index 488b1470060c..5792aa59cc82 100644
@@ -28,6 +28,9 @@ const char * const binder_command_strings[] = {
 	"BC_DEAD_BINDER_DONE",
 	"BC_TRANSACTION_SG",
 	"BC_REPLY_SG",
+	"BC_REQUEST_FREEZE_NOTIFICATION",
+	"BC_CLEAR_FREEZE_NOTIFICATION",
+	"BC_FREEZE_NOTIFICATION_DONE",
 };
 
 const char * const binder_return_strings[] = {

@@ -51,7 +54,9 @@ const char * const binder_return_strings[] = {
 	"BR_FAILED_REPLY",
 	"BR_FROZEN_REPLY",
 	"BR_ONEWAY_SPAM_SUSPECT",
-	"BR_TRANSACTION_PENDING_FROZEN"
+	"BR_TRANSACTION_PENDING_FROZEN",
+	"BR_FROZEN_BINDER",
+	"BR_CLEAR_FREEZE_NOTIFICATION_DONE",
 };
 
 #define CREATE_TRACE_POINTS

drivers/android/binder/stats.rs +2 -2

index ab75e9561cbf..ec81dc7747db 100644
@@ -8,8 +8,8 @@
 use kernel::sync::atomic::{ordering::Relaxed, Atomic};
 use kernel::{ioctl::_IOC_NR, seq_file::SeqFile, seq_print};
 
-const BC_COUNT: usize = _IOC_NR(BC_REPLY_SG) as usize + 1;
-const BR_COUNT: usize = _IOC_NR(BR_TRANSACTION_PENDING_FROZEN) as usize + 1;
+const BC_COUNT: usize = _IOC_NR(BC_FREEZE_NOTIFICATION_DONE) as usize + 1;
+const BR_COUNT: usize = _IOC_NR(BR_CLEAR_FREEZE_NOTIFICATION_DONE) as usize + 1;
 
 pub(crate) static GLOBAL_STATS: BinderStats = BinderStats::new();

Signature · 1 line

2.39.5

Alice Ryhl

maintainer

2026-06-15 21:11 UTC #6 lore raw

Quoted 10 lines · Keshav Verma

Rust Binder stats use BC_COUNT and BR_COUNT to size the command and return counters, and use event string tables when printing debug statistics.
The Binder protocol includes freeze-related commands and return codes, but the Rust Binder statistics code was not updated to cover them. As a result, those commands and return codes are not accounted for or printed by the stats debug output.

Quoted 7 lines

Update the counts and event string tables so these commands and return codes are included in the debug statistics output.
Fixes eafedbc7c050 ("rust_binder: add Rust Binder driver")
Cc [email protected]
Acked-by Carlos Llamas <[email protected]>
Signed-off-by Keshav Verma <[email protected]>

I noticed that the patch heading says binder: instead of rust_binder:. Can you update the prefix to match other Rust Binder changes?

Thanks

Keshav Verma

author

2026-06-15 21:18 UTC #7 lore raw

PATCH v4 1/1 rust_binder: synchronize Rust Binder stats with freeze commands

In reply to syncrain

Rust Binder stats use BC_COUNT and BR_COUNT to size the command and return counters, and use event string tables when printing debug statistics.

Update the counts and event string tables so these commands and return codes are included in the debug statistics output.

Fixes eafedbc7c050 ("rust_binder: add Rust Binder driver")

Cc [email protected]

Acked-by Carlos Llamas <[email protected]>

Reviewed-by Alice Ryhl <[email protected]>

Signed-off-by Keshav Verma <[email protected]>

---
v4:
- Rename subject prefix from "binder:" to "rust_binder:"

v3:
- Add changelog for previous revisions.

v2:
- Add Fixes: tag for rust_binder introduction commit.
- Cc [email protected].
- Add Acked-by from Carlos Llamas.
- Use real name in Signed-off-by.

 drivers/android/binder/rust_binder_events.c | 7 ++++++-
 drivers/android/binder/stats.rs             | 4 ++--
 2 files changed, 8 insertions(+), 3 deletions(-)

drivers/android/binder/rust_binder_events.c +6 -1

index 488b1470060c..5792aa59cc82 100644
@@ -28,6 +28,9 @@ const char * const binder_command_strings[] = {
 	"BC_DEAD_BINDER_DONE",
 	"BC_TRANSACTION_SG",
 	"BC_REPLY_SG",
+	"BC_REQUEST_FREEZE_NOTIFICATION",
+	"BC_CLEAR_FREEZE_NOTIFICATION",
+	"BC_FREEZE_NOTIFICATION_DONE",
 };
 
 const char * const binder_return_strings[] = {

@@ -51,7 +54,9 @@ const char * const binder_return_strings[] = {
 	"BR_FAILED_REPLY",
 	"BR_FROZEN_REPLY",
 	"BR_ONEWAY_SPAM_SUSPECT",
-	"BR_TRANSACTION_PENDING_FROZEN"
+	"BR_TRANSACTION_PENDING_FROZEN",
+	"BR_FROZEN_BINDER",
+	"BR_CLEAR_FREEZE_NOTIFICATION_DONE",
 };
 
 #define CREATE_TRACE_POINTS

drivers/android/binder/stats.rs +2 -2

index ab75e9561cbf..ec81dc7747db 100644
@@ -8,8 +8,8 @@
 use kernel::sync::atomic::{ordering::Relaxed, Atomic};
 use kernel::{ioctl::_IOC_NR, seq_file::SeqFile, seq_print};
 
-const BC_COUNT: usize = _IOC_NR(BC_REPLY_SG) as usize + 1;
-const BR_COUNT: usize = _IOC_NR(BR_TRANSACTION_PENDING_FROZEN) as usize + 1;
+const BC_COUNT: usize = _IOC_NR(BC_FREEZE_NOTIFICATION_DONE) as usize + 1;
+const BR_COUNT: usize = _IOC_NR(BR_CLEAR_FREEZE_NOTIFICATION_DONE) as usize + 1;
 
 pub(crate) static GLOBAL_STATS: BinderStats = BinderStats::new();

Signature · 1 line

2.39.5