io_uring, audit: don't log IORING_OP_RECV_ZC
PATCH 1/1 io_uring, audit: don't log IORING_OP_RECV_ZC
IORING_OP_RECV_ZC is a read operation. Audit only tracks file/socket creation, not subsequent reads. Set audit_skip to align with audit-userspace uringop_table.h.
--- io_uring/opdef.c | 1 + 1 file changed, 1 insertion(+)
io_uring/opdef.c +1 -0
@@ -519,6 +519,7 @@ const struct io_issue_def io_issue_defs[] = {#endif }, [IORING_OP_RECV_ZC] = { + .audit_skip = 1, .needs_file = 1, .unbound_nonreg_file = 1, .pollin = 1,
Signature · 1 line
2.53.0
Quoted 3 lines · Ricardo Robaina
IORING_OP_RECV_ZCis a read operation. Audit only tracks file/socket creation ...
That's not strictly correct, audit tracks more than just socket creation. Connection events and connection-less writes are also of interest.
Quoted 2 lines
... not subsequent reads. Set
audit_skipto align with audit-userspaceuringop_table.h.
While the logic above is correct, IORING_OP_RECV_ZC should be "audit_skip", the reasoning is backwards: the audit userspace io_uring table is dependent on the kernel, not the other way around (for what should be obvious reasons).
Quoted 21 lines
Fixes 11ed914bbf94 ("io_uring/zcrx: add io_recvzc request")Suggested-by Steve Grubb <[email protected]>Signed-off-by Ricardo Robaina <[email protected]>--- io_uring/opdef.c | 1 + 1 file changed, 1 insertion(+)io_uring/opdef.c +1
-1@@ -519,6 +519,7 @@ const struct io_issue_def io_issue_defs[] = {#endif }, [IORING_OP_RECV_ZC] = { + .audit_skip = 1, .needs_file = 1, .unbound_nonreg_file = 1, .pollin = 1, --2.53.0
Signature · 1 line
paul-moore.com
Quoted 36 lines · Paul Moore
Quoted 3 lines · Ricardo Robaina
IORING_OP_RECV_ZCis a read operation. Audit only tracks file/socket creation ...That's not strictly correct, audit tracks more than just socket creation. Connection events and connection-less writes are also of interest.
Quoted 2 lines
... not subsequent reads. Set
audit_skipto align with audit-userspaceuringop_table.h.While the logic above is correct,
IORING_OP_RECV_ZCshould be "audit_skip", the reasoning is backwards: the audit userspaceio_uringtable is dependent on the kernel, not the other way around (for what should be obvious reasons).Acked-by Paul Moore <[email protected]>Quoted 16 lines
Fixes 11ed914bbf94 ("io_uring/zcrx: add io_recvzc request")Suggested-by Steve Grubb <[email protected]>Signed-off-by Ricardo Robaina <[email protected]>--- io_uring/opdef.c | 1 + 1 file changed, 1 insertion(+)io_uring/opdef.c +1
-0@@ -519,6 +519,7 @@ const struct io_issue_def io_issue_defs[] = {#endif }, [IORING_OP_RECV_ZC] = { + .audit_skip = 1,
Quoted 9 lines
Quoted 5 lines
io_uring/opdef.c +0
-1.needs_file = 1, .unbound_nonreg_file = 1, .pollin = 1, --2.53.0
--
paul-moore.com
Thanks for reviewing the patch and the clarification, Paul!
-Ricardo
Quoted 3 lines · Ricardo Robaina
IORING_OP_RECV_ZCis a read operation. Audit only tracks file/socket creation, not subsequent reads. Setaudit_skipto align with audit-userspaceuringop_table.h.
Applied, thanks!
[1/1] io_uring, audit: don't log IORING_OP_RECV_ZC
commit: bdc2fc388c348ee14b4f984ff75f2ea440cefd44
Best regards,
Signature · 1 line
Jens Axboe
Quoted 7 lines · Jens Axboe
Quoted 3 lines · Ricardo Robaina
IORING_OP_RECV_ZCis a read operation. Audit only tracks file/socket creation, not subsequent reads. Setaudit_skipto align with audit-userspaceuringop_table.h.
Quoted 11 lines
Applied, thanks!
[1/1]
io_uring, audit: don't logIORING_OP_RECV_ZCcommit: bdc2fc388c348ee14b4f984ff75f2ea440cefd44Best regards,
--
Jens Axboe
Thanks, Jens!