iio: adc: ti-adc*: use dev_err_probe for probe time errors
Subsystems (2)
PATCH 1/1 iio: adc: ti-adc*: use dev_err_probe for probe time errors
This simplifies error handling and ensures consistent error reporting. Also add missing error messages in a few probe paths where failures were previously returned without any diagnostics.
--- drivers/iio/adc/ti-adc081c.c | 10 ++++------ drivers/iio/adc/ti-adc0832.c | 6 +++--- drivers/iio/adc/ti-adc084s021.c | 3 +-- drivers/iio/adc/ti-adc108s102.c | 2 +- drivers/iio/adc/ti-adc128s052.c | 2 +- drivers/iio/adc/ti-adc161s626.c | 6 +++--- 6 files changed, 13 insertions(+), 16 deletions(-)
drivers/iio/adc/ti-adc081c.c +4 -6
@@ -174,26 +174,24 @@ static int adc081c_probe(struct i2c_client *client) err =regulator_enable (adc->ref);if (err <0 ) -return err; +return dev_err_probe (&client->dev, err,"failed to enable regulator\n" ); err =devm_add_action_or_reset (&client->dev, adc081c_reg_disable, adc->ref);if (err) -return err; +return dev_err_probe (&client->dev, err,"failed to register cleanup action\n" ); iio->name =dev_name (&client->dev); iio->modes =INDIO_DIRECT_MODE ; iio->info = &adc081c_info; iio->channels = model->channels; iio->num_channels =ADC081C_NUM_CHANNELS ; err =devm_iio_triggered_buffer_setup (&client->dev, iio,NULL , adc081c_trigger_handler,NULL ); -if (err <0 ) { -dev_err (&client->dev,"iio triggered buffer setup failed\n" ); -return err; - } +if (err <0 ) +return dev_err_probe (&client->dev, err,"iio triggered buffer setup failed\n" );return devm_iio_device_register (&client->dev, iio); }
drivers/iio/adc/ti-adc0832.c +3 -3
@@ -289,17 +289,17 @@ static int adc0832_probe(struct spi_device *spi) ret =regulator_enable (adc->reg);if (ret) -return ret; +return dev_err_probe (&spi->dev, ret,"failed to enable regulator\n" ); ret =devm_add_action_or_reset (&spi->dev, adc0832_reg_disable, adc->reg);if (ret) -return ret; +return dev_err_probe (&spi->dev, ret,"failed to register cleanup action\n" ); ret =devm_iio_triggered_buffer_setup (&spi->dev, indio_dev,NULL , adc0832_trigger_handler,NULL );if (ret) -return ret; +return dev_err_probe (&spi->dev, ret,"iio triggered buffer setup failed\n" );return devm_iio_device_register (&spi->dev, indio_dev); }
drivers/iio/adc/ti-adc084s021.c +1 -2
@@ -230,8 +230,7 @@ static int adc084s021_probe(struct spi_device *spi) adc084s021_buffer_trigger_handler, &adc084s021_buffer_setup_ops);if (ret) { -dev_err (&spi->dev,"Failed to setup triggered buffer\n" ); -return ret; +return dev_err_probe (&spi->dev, ret,"Failed to setup triggered buffer\n" ); }return devm_iio_device_register (&spi->dev, indio_dev);
drivers/iio/adc/ti-adc108s102.c +1 -1
@@ -256,7 +256,7 @@ static int adc108s102_probe(struct spi_device *spi) &adc108s102_trigger_handler, NULL);if (ret) -return ret; +return dev_err_probe (&spi->dev, ret,"iio triggered buffer setup failed\n" ); ret =devm_iio_device_register (&spi->dev, indio_dev);if (ret)
drivers/iio/adc/ti-adc128s052.c +1 -1
@@ -225,7 +225,7 @@ static int adc128_probe(struct spi_device *spi) ret =devm_mutex_init (&spi->dev, &adc->lock);if (ret) -return ret; +return dev_err_probe (&spi->dev, ret,"failed to initialize mutex\n" );return devm_iio_device_register (&spi->dev, indio_dev); }
drivers/iio/adc/ti-adc161s626.c +3 -3
@@ -207,17 +207,17 @@ static int ti_adc_probe(struct spi_device *spi) ret =regulator_enable (data->ref);if (ret <0 ) -return ret; +return dev_err_probe (&spi->dev, ret,"failed to enable regulator\n" ); ret =devm_add_action_or_reset (&spi->dev, ti_adc_reg_disable, data->ref);if (ret) -return ret; +return dev_err_probe (&spi->dev, ret,"failed to add cleanup action\n" ); ret =devm_iio_triggered_buffer_setup (&spi->dev, indio_dev,NULL , ti_adc_trigger_handler,NULL );if (ret) -return ret; +return dev_err_probe (&spi->dev, ret,"iio triggered buffer setup failed\n" );return devm_iio_device_register (&spi->dev, indio_dev); }
--
2.54.0
David Lechner
reviewerQuoted 5 lines · Prashant Rahul
This simplifies error handling and ensures consistent error reporting. Also add missing error messages in a few probe paths where failures were previously returned without any diagnostics.
Signed-off-by Prashant Rahul <[email protected]>
Quoted 8 lines
--- drivers/iio/adc/ti-adc081c.c | 10 ++++------ drivers/iio/adc/ti-adc0832.c | 6 +++--- drivers/iio/adc/ti-adc084s021.c | 3 +-- drivers/iio/adc/ti-adc108s102.c | 2 +- drivers/iio/adc/ti-adc128s052.c | 2 +- drivers/iio/adc/ti-adc161s626.c | 6 +++--- 6 files changed, 13 insertions(+), 16 deletions(-)
Please make one patch per file.
Quoted 7 lines
drivers/iio/adc/ti-adc081c.c +0
-0@@ -174,26 +174,24 @@ static int adc081c_probe(struct i2c_client *client)
drivers/iio/adc/ti-adc081c.c static int adc081c_probe(struct i2c_client *client) · line 182
Quoted 10 lines
drivers/iio/adc/ti-adc081c.c +2
-2err =regulator_enable (adc->ref);if (err <0 ) -return err; +return dev_err_probe (&client->dev, err,"failed to enable regulator\n" ); err =devm_add_action_or_reset (&client->dev, adc081c_reg_disable, adc->ref);if (err) -return err; +return dev_err_probe (&client->dev, err,"failed to register cleanup action\n" );
Please don't add new error messages. If there is a really good reason to, please do that in a separate patch with a justification as to why it is needed.
In this particular case, the only error is -ENOMEM, which we never have an error message for.
Above, for regulator_enable(), an error is already printed in many cases when it fails, so needing to add an additional error message is questionable.
The same comments apply to the rest of the changes as well. Unless you actually hit one of these errors and found it difficult to troubleshoot without an additional message, then it probably isn't an improvement.
Quoted 1 line · David Lechner
Please make one patch per file.
will do
Quoted 5 lines
Please don't add new error messages. If there is a really good reason to, please do that in a separate patch with a justification as to why it is needed.
In this particular case, the only error is-ENOMEM, which we never have an error message for.
I understand. I will remove the additional logs, except the ones after devm_iio_triggered_buffer_setup for -ENOMEM.
Jonathan Cameron
maintainerQuoted 5 lines · On Thu, 18 Jun 2026 22:22:15 +0530 "Prashant Rahul"…
Quoted 1 line · David Lechner
Please make one patch per file.
will do
Quoted 8 lines
Quoted 5 lines
Please don't add new error messages. If there is a really good reason to, please do that in a separate patch with a justification as to why it is needed.
In this particular case, the only error is-ENOMEM, which we never have an error message for.I understand. I will remove the additional logs, except the ones after
devm_iio_triggered_buffer_setupfor-ENOMEM.
This jumped out at me. We very rarely do special prints for anything that returns -ENOMEM as that tends to be very noisy on the rare occasion it happens. Note that dev_err_probe() doesn't print anything in this case.
J
Quoted 3 lines · Jonathan Cameron
Quoted 1 line · On Thu, 18 Jun 2026 22:22:15 +0530 "Prashant Rahul"…
On Tue Jun 16, 2026 at 7:33 PM IST, David Lechner wrote:
...
Quoted 7 lines
Quoted 2 lines
I understand. I will remove the additional logs, except the ones after
devm_iio_triggered_buffer_setupfor-ENOMEM.This jumped out at me. We very rarely do special prints for anything that returns
-ENOMEMas that tends to be very noisy on the rare occasion it happens. Note thatdev_err_probe()doesn't print anything in this case.
And I didn't check this as well, I though it might return more codes. In such case this series is doomed because it adds dead code.
Signature · 2 lines
With Best Regards, Andy Shevchenko
cover use dev_err_probe for probe time error
In reply to Prashant RahulUsing dev_err_probe as it simplifies error handling and ensures consistent error reporting.
Errors are logged when enabling the regulator or adding the cleanup action fails, but not when buffer setup fails. This adds that missing log.
Prashant Rahul (5):
iio: adc: ti-adc081c: use dev_err_probe for probe time error
iio: adc: ti-adc084s021: use dev_err_probe for probe time error
iio: adc: ti-adc108s102: log buffer setup failure in probe
iio: adc: ti-adc161s626: log buffer setup failure in probe
iio: adc: ti-adc0832: log buffer setup failure in probe
drivers/iio/adc/ti-adc081c.c | 6 ++---- drivers/iio/adc/ti-adc0832.c | 2 +- drivers/iio/adc/ti-adc084s021.c | 3 +-- drivers/iio/adc/ti-adc108s102.c | 2 +- drivers/iio/adc/ti-adc161s626.c | 2 +- 5 files changed, 6 insertions(+), 9 deletions(-)
--
2.54.0
PATCH 1/5 iio: adc: ti-adc081c: use dev_err_probe for probe time error
This simplifies error handling and ensures consistent error reporting.
--- drivers/iio/adc/ti-adc081c.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/iio/adc/ti-adc081c.c +2 -4
@@ -190,10 +190,8 @@ static int adc081c_probe(struct i2c_client *client) err =devm_iio_triggered_buffer_setup (&client->dev, iio,NULL , adc081c_trigger_handler,NULL ); -if (err <0 ) { -dev_err (&client->dev,"iio triggered buffer setup failed\n" ); -return err; - } +if (err <0 ) +return dev_err_probe (&client->dev, err,"iio triggered buffer setup failed\n" );return devm_iio_device_register (&client->dev, iio); }
Signature · 1 line
2.54.0
Jonathan Cameron
maintainerRe: [PATCH 1/5] iio: adc: ti-adc081c: use dev_err_probe for probe time error
Quoted 1 line · On Fri, 19 Jun 2026 04:44:34 +0530 Prashant Rahul <[email protected]>…
This simplifies error handling and ensures consistent error reporting.
Applied with patch description amended to include () after dev_err_probe.
Thanks,
Jonathan
Quoted 23 lines
Signed-off-by Prashant Rahul <[email protected]>--- drivers/iio/adc/ti-adc081c.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/iio/adc/ti-adc081c.c +2
-4@@ -190,10 +190,8 @@ static int adc081c_probe(struct i2c_client *client) err =devm_iio_triggered_buffer_setup (&client->dev, iio,NULL , adc081c_trigger_handler,NULL ); -if (err <0 ) { -dev_err (&client->dev,"iio triggered buffer setup failed\n" ); -return err; - } +if (err <0 ) +return dev_err_probe (&client->dev, err,"iio triggered buffer setup failed\n" );return devm_iio_device_register (&client->dev, iio); }
PATCH 2/5 iio: adc: ti-adc084s021: use dev_err_probe for probe time error
In reply to Prashant RahulThis simplifies error handling and ensures consistent error reporting.
--- drivers/iio/adc/ti-adc084s021.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/adc/ti-adc084s021.c +1 -2
@@ -230,8 +230,7 @@ static int adc084s021_probe(struct spi_device *spi) adc084s021_buffer_trigger_handler, &adc084s021_buffer_setup_ops);if (ret) { -dev_err (&spi->dev,"Failed to setup triggered buffer\n" ); -return ret; +return dev_err_probe (&spi->dev, ret,"Failed to setup triggered buffer\n" ); }return devm_iio_device_register (&spi->dev, indio_dev);
Signature · 1 line
2.54.0
David Lechner
reviewerRe: [PATCH 2/5] iio: adc: ti-adc084s021: use dev_err_probe for probe time error
Quoted 12 lines · Prashant Rahul
This simplifies error handling and ensures consistent error reporting.
Signed-off-by Prashant Rahul <[email protected]>--- drivers/iio/adc/ti-adc084s021.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/iio/adc/ti-adc084s021.c +0
-0
drivers/iio/adc/ti-adc084s021.c static int adc084s021_probe(struct spi_device *spi) · line 234
Quoted 7 lines
drivers/iio/adc/ti-adc084s021.c +1
-2@@ -230,8 +230,7 @@ static int adc084s021_probe(struct spi_device *spi) adc084s021_buffer_trigger_handler, &adc084s021_buffer_setup_ops);if (ret) { -dev_err (&spi->dev,"Failed to setup triggered buffer\n" ); -return ret; +return dev_err_probe (&spi->dev, ret,"Failed to setup triggered buffer\n" ); }
Can drop the braces here
Quoted 2 lines
drivers/iio/adc/ti-adc084s021.c +0
-0return devm_iio_device_register (&spi->dev, indio_dev);
Jonathan Cameron
maintainerRe: [PATCH 2/5] iio: adc: ti-adc084s021: use dev_err_probe for probe time error
Quoted 8 lines · On Fri, 19 Jun 2026 09:49:19 -0500 David Lechner <[email protected]> wrote:
Quoted 7 lines · Prashant Rahul
This simplifies error handling and ensures consistent error reporting.
Signed-off-by Prashant Rahul <[email protected]>--- drivers/iio/adc/ti-adc084s021.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Quoted 16 lines
drivers/iio/adc/ti-adc084s021.c static int adc084s021_probe(struct spi_device *spi) · line 234
Quoted 12 lines
drivers/iio/adc/ti-adc084s021.c +1
-2@@ -230,8 +230,7 @@ static int adc084s021_probe(struct spi_device *spi) adc084s021_buffer_trigger_handler, &adc084s021_buffer_setup_ops);if (ret) { -dev_err (&spi->dev,"Failed to setup triggered buffer\n" ); -return ret; +return dev_err_probe (&spi->dev, ret,"Failed to setup triggered buffer\n" ); }Can drop the braces here
Dropped whilst applying. I'm a bit in two minds on whether we should print anything on this one given the incredibly low chance of anyone having a bug that double registers the buffer - still better as dev_err_probe() then dev_err() so applied.
Quoted 3 lines
Quoted 2 lines
drivers/iio/adc/ti-adc084s021.c +0
-0return devm_iio_device_register (&spi->dev, indio_dev);
PATCH 3/5 iio: adc: ti-adc108s102: log buffer setup failure in probe
In reply to Prashant RahulErrors are logged when enabling the regulator or adding the cleanup action fails, but not when buffer setup fails. Log the error returned by the buffer setup path as well.
--- drivers/iio/adc/ti-adc108s102.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ti-adc108s102.c +1 -1
@@ -256,7 +256,7 @@ static int adc108s102_probe(struct spi_device *spi) &adc108s102_trigger_handler, NULL);if (ret) -return ret; +return dev_err_probe (&spi->dev, ret,"iio triggered buffer setup failed\n" ); ret =devm_iio_device_register (&spi->dev, indio_dev);if (ret)
Signature · 1 line
2.54.0
Jonathan Cameron
maintainerRe: [PATCH 3/5] iio: adc: ti-adc108s102: log buffer setup failure in probe
Quoted 5 lines · On Fri, 19 Jun 2026 04:44:36 +0530 Prashant Rahul <[email protected]>…
Errors are logged when enabling the regulator or adding the cleanup action fails, but not when buffer setup fails. Log the error returned by the buffer setup path as well.
Signed-off-by Prashant Rahul <[email protected]>
I'm not going to add more prints to these. So won't pick up rest of the series.
Thanks,
Jonathan
Quoted 17 lines
--- drivers/iio/adc/ti-adc108s102.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/adc/ti-adc108s102.c +1
-1@@ -256,7 +256,7 @@ static int adc108s102_probe(struct spi_device *spi) &adc108s102_trigger_handler, NULL);if (ret) -return ret; +return dev_err_probe (&spi->dev, ret,"iio triggered buffer setup failed\n" ); ret =devm_iio_device_register (&spi->dev, indio_dev);if (ret)
PATCH 4/5 iio: adc: ti-adc161s626: log buffer setup failure in probe
In reply to Prashant RahulErrors are logged when enabling the regulator or adding the cleanup action fails, but not when buffer setup fails. Log the error returned by the buffer setup path as well.
--- drivers/iio/adc/ti-adc161s626.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ti-adc161s626.c +1 -1
@@ -217,7 +217,7 @@ static int ti_adc_probe(struct spi_device *spi) ret =devm_iio_triggered_buffer_setup (&spi->dev, indio_dev,NULL , ti_adc_trigger_handler,NULL );if (ret) -return ret; +return dev_err_probe (&spi->dev, ret,"iio triggered buffer setup failed\n" );return devm_iio_device_register (&spi->dev, indio_dev); }
Signature · 1 line
2.54.0
PATCH 5/5 iio: adc: ti-adc0832: log buffer setup failure in probe
In reply to Prashant RahulErrors are logged when enabling the regulator or adding the cleanup action fails, but not when buffer setup fails. Log the error returned by the buffer setup path as well.
--- drivers/iio/adc/ti-adc0832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ti-adc0832.c +1 -1
@@ -299,7 +299,7 @@ static int adc0832_probe(struct spi_device *spi) ret =devm_iio_triggered_buffer_setup (&spi->dev, indio_dev,NULL , adc0832_trigger_handler,NULL );if (ret) -return ret; +return dev_err_probe (&spi->dev, ret,"iio triggered buffer setup failed\n" );return devm_iio_device_register (&spi->dev, indio_dev); }
Signature · 1 line
2.54.0
David Lechner
reviewerRe: [PATCH 0/5] use dev_err_probe for probe time error
In reply to Prashant RahulQuoted 5 lines · Prashant Rahul
Using
dev_err_probeas it simplifies error handling and ensures consistent error reporting.Errors are logged when enabling the regulator or adding the cleanup action fails, but not when buffer setup fails. This adds that missing log.
Isn't this a v2 of [1]? It should have a changelog and link to the previous discussion (and start a new thread instead of being in reply to the previous revision).
[1]: https://lore.kernel.org/linux-iio/[email protected]/
No need to send a new version for that, but keep it in mind for future submissions.
Quoted 17 lines
Prashant Rahul (5):
iio: adc: ti-adc081c: usedev_err_probefor probe time error
iio: adc: ti-adc084s021: usedev_err_probefor probe time error
iio: adc: ti-adc108s102: log buffer setup failure in probe
iio: adc: ti-adc161s626: log buffer setup failure in probe
iio: adc: ti-adc0832: log buffer setup failure in probedrivers/iio/adc/ti-adc081c.c | 6 ++---- drivers/iio/adc/ti-adc0832.c | 2 +- drivers/iio/adc/ti-adc084s021.c | 3 +-- drivers/iio/adc/ti-adc108s102.c | 2 +- drivers/iio/adc/ti-adc161s626.c | 2 +- 5 files changed, 6 insertions(+), 9 deletions(-)--
2.54.0
Re: [PATCH 0/5] use dev_err_probe for probe time error
Quoted 8 lines · David Lechner
Isn't this a v2 of [1]? It should have a changelog and link to the previous discussion (and start a new thread instead of being in reply to the previous revision).
[1]: https://lore.kernel.org/linux-iio/[email protected]/
No need to send a new version for that, but keep it in mind for future submissions.
My apologies, will keep that in mind, I am still getting used to the whole email based workflow.