dlm: prevent NPD when writing a positive value to event_done
PATCH 1/1 dlm: prevent NPD when writing a positive value to event_done
From: Thadeu Lima de Souza Cascardo <[email protected]>
commit 8e2bad543eca5c25cd02cbc63d72557934d45f13 upstream.
do_uevent returns the value written to event_done. In case it is a positive value, new_lockspace would undo all the work, and lockspace would not be set. __dlm_new_lockspace, however, would treat that positive value as a success due to commit 8511a2728ab8 ("dlm: fix use count with multiple joins").
Down the line, device_create_lockspace would pass that NULL lockspace to dlm_find_lockspace_local, leading to a NULL pointer dereference.
Treating such positive values as successes prevents the problem. Given this has been broken for so long, this is unlikely to break userspace expectations.
---
Backport fix for CVE-2025-23131
fs/dlm/lockspace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/dlm/lockspace.c +1 -1
@@ -576,7 +576,7 @@ static int new_lockspace(const char *name, const char *cluster,lockspace to start running (via sysfs) in dlm_ls_start(). */ error =do_uevent (ls,1 ); -if (error) +if (error <0 ) goto out_recoverd;/* wait until recovery is successful or failed */
Signature · 1 line
2.47.3