media: rc: igorplugusb: Fix wrong pointer passed to usb_fill_control_urb()
Subsystems (3)
PATCH 1/1 media: rc: igorplugusb: Fix wrong pointer passed to usb_fill_control_urb()
ir->request is already a pointer to struct usb_ctrlrequest, so passing &ir->request passes the address of the pointer rather than the pointer itself. This causes usb_submit_urb() to read garbage as the URB setup packet, resulting in a direction mismatch warning:
usb 1-1: BOGUS control dir, pipe doesn't match bRequestType
Fix this by passing ir->request directly instead of &ir->request.
--- drivers/media/rc/igorplugusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/rc/igorplugusb.c +1 -1
@@ -184,7 +184,7 @@ static int igorplugusb_probe(struct usb_interface *intf,if (!ir->buf_in) goto fail;usb_fill_control_urb (ir->urb, udev, -usb_rcvctrlpipe (udev,0 ), (uint8_t *)&ir->request, +usb_rcvctrlpipe (udev,0 ), (uint8_t *)ir->request, ir->buf_in,MAX_PACKET , igorplugusb_callback, ir);usb_make_path (udev, ir->phys,sizeof (ir->phys));
Signature · 1 line
2.34.1
Sean Young
maintainerQuoted 8 lines · Moksh Panicker
ir->requestis already a pointer to structusb_ctrlrequest, so passing&ir->requestpasses the address of the pointer rather than the pointer itself. This causesusb_submit_urb()to read garbage as the URB setup packet, resulting in a direction mismatch warning:usb 1-1: BOGUS control dir, pipe doesn't match bRequestType
Fix this by passing
ir->requestdirectly instead of&ir->request.
Already fixed and merged upstream, see commit171022c7d594c133a45f92357a2a91475edabe20.
Thanks,
Sean
Quoted 24 lines
Reported-by [email protected]Signed-off-by Moksh Panicker <[email protected]>--- drivers/media/rc/igorplugusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/rc/igorplugusb.c +1
-1@@ -184,7 +184,7 @@ static int igorplugusb_probe(struct usb_interface *intf,if (!ir->buf_in) goto fail;usb_fill_control_urb (ir->urb, udev, -usb_rcvctrlpipe (udev,0 ), (uint8_t *)&ir->request, +usb_rcvctrlpipe (udev,0 ), (uint8_t *)ir->request, ir->buf_in,MAX_PACKET , igorplugusb_callback, ir);usb_make_path (udev, ir->phys,sizeof (ir->phys));Signature · 1 line
2.34.1