HID: core: Fix OOB read in hid_get_report for numbered reports
PATCH 1/1 HID: core: Fix OOB read in hid_get_report for numbered reports
When a caller passes a size of 0 to hid_report_raw_event() for a numbered report, the function originally called hid_get_report() before performing any size validation.
Inside hid_get_report(), if the report is numbered (report_enum->numbered is true), it unconditionally dereferences data[0] to extract the report ID. With a size of 0, this results in an out-of-bounds read or kernel panic.
Fix this by moving the numbered report size validation check before the call to hid_get_report(), ensuring that size is at least 1 before dereferencing the data pointer.
--- drivers/hid/hid-core.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/hid/hid-core.c +7 -0
@@ -2045,6 +2045,13 @@ int hid_report_raw_event(struct hid_device *hid, enum hid_report_type type, u8 *u8 *cdata = data;int ret =0 ; +if (report_enum->numbered && (size <1 || bufsize <1 )) { +hid_warn_ratelimited (hid, +"Event data for numbered report is too short (%d vs %zu)\n" , + size, bufsize); +return -EINVAL ; + } + report =hid_get_report (report_enum, data);if (!report)return 0 ;
Signature · 1 line
2.54.0.1136.gdb2ca164c4-goog
Quoted 12 lines · Lee Jones
When a caller passes a size of 0 to
hid_report_raw_event()for a numbered report, the function originally calledhid_get_report()before performing any size validation.Inside
hid_get_report(), if the report is numbered (report_enum->numberedis true), it unconditionally dereferences data[0] to extract the report ID. With a size of 0, this results in an out-of-bounds read or kernel panic.Fix this by moving the numbered report size validation check before the call to
hid_get_report(), ensuring that size is at least 1 before dereferencing the data pointer.
Quoted 5 lines
Fixes 2c85c61d1332 ("HID: pass the buffer size to hid_report_raw_event")Signed-off-by Lee Jones <[email protected]>--- drivers/hid/hid-core.c | 7 +++++++ 1 file changed, 7 insertions(+)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
Quoted 40 lines · Greg Kroah-Hartman
Quoted 12 lines · Lee Jones
When a caller passes a size of 0 to
hid_report_raw_event()for a numbered report, the function originally calledhid_get_report()before performing any size validation.Inside
hid_get_report(), if the report is numbered (report_enum->numberedis true), it unconditionally dereferences data[0] to extract the report ID. With a size of 0, this results in an out-of-bounds read or kernel panic.Fix this by moving the numbered report size validation check before the call to
hid_get_report(), ensuring that size is at least 1 before dereferencing the data pointer.Quoted 5 lines
Fixes 2c85c61d1332 ("HID: pass the buffer size to hid_report_raw_event")Signed-off-by Lee Jones <[email protected]>--- drivers/hid/hid-core.c | 7 +++++++ 1 file changed, 7 insertions(+)Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the
Documentation/process/stable-kernel-rules.rstfile for how to resolve this.
Quoted 4 lines
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
Sure, why not! :)
Signature · 1 line
Lee Jones
Quoted 8 lines · Lee Jones
When a caller passes a size of 0 to
hid_report_raw_event()for a numbered report, the function originally calledhid_get_report()before performing any size validation.Inside
hid_get_report(), if the report is numbered (report_enum->numberedis true), it unconditionally dereferences data[0] to extract the report ID. With a size of 0, this results in an out-of-bounds read or kernel panic.
Quoted 6 lines
Fix this by moving the numbered report size validation check before the call to
hid_get_report(), ensuring that size is at least 1 before dereferencing the data pointer.Fixes 2c85c61d1332 ("HID: pass the buffer size to hid_report_raw_event")Signed-off-by Lee Jones <[email protected]>
Applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs