Skip to contentSkip to conversation

generic/645: Confirm availability of free inodes

PATCH In review Ojaswin Mujoo 2 participants 6 messages Jun 17 – Jul 30

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/645: Confirm availability of free inodes

When running generic/645 with ext4 using 64k block size + bigalloc, the test fails with ENOSPC because the filesystem runs out of inodes before the test completes.

The test creates approximately 10,001 files, however, in this particular configuration a standard 5G FS only has around ~5100 inodes resulting in the ENOSPC failure.

Add a check using _get_free_inode() to verify sufficient inodes are available before running the test, else skip it.

---
 tests/generic/645 | 6 ++++++
 1 file changed, 6 insertions(+)
tests/generic/645 +5 -0
index d6eb75e6..944b33db 100755
@@ -19,6 +19,12 @@ _require_chown
 _wants_kernel_commit dacfd001eaf2 \
 	"fs/mnt_idmapping.c: Return -EINVAL when no map is written"
 
+_free_inodes=$(_get_free_inode $TEST_DIR)
+if [ $_free_inodes -ne 0 ] && [ $_free_inodes -lt 10001 ]; then
+	_notrun "Insufficient free inodes ($_free_inodes), need at least 10001"
+fi
+
 echo "Silence is golden"
 
 $here/src/vfs/vfstest --test-nested-userns \
Signature · 1 line
2.53.0
#1 lore raw
Quoted 22 lines · Ojaswin Mujoo

When running generic/645 with ext4 using 64k block size + bigalloc, the test fails with ENOSPC because the filesystem runs out of inodes before the test completes.

The test creates approximately 10,001 files, however, in this particular configuration a standard 5G FS only has around ~5100 inodes resulting in the ENOSPC failure.

Add a check using _get_free_inode() to verify sufficient inodes are available before running the test, else skip it.

---
 tests/generic/645 | 6 ++++++
 1 file changed, 6 insertions(+)
tests/generic/645 +0 -0
index d6eb75e6..944b33db 100755

tests/generic/645 _require_chown · line 23

Quoted 5 lines
tests/generic/645 +2 -0
@@ -19,6 +19,12 @@ _require_chown
 _wants_kernel_commit dacfd001eaf2 \
 	"fs/mnt_idmapping.c: Return -EINVAL when no map is written"
 
+_free_inodes=$(_get_free_inode $TEST_DIR)
+if [ $_free_inodes -ne 0 ] && [ $_free_inodes -lt 10001 ]; then

I'm assuming the > 0 check here is to cover weird filesystems like fat that don't advertise any inodes? /me wonders if that ought to be a common helper where we can record that justification:

_require_free_inodes() {
	local path="$1"
	local nr="$2"

	local _free_inodes=$(_get_free_inode "$path")

	# Weird filesystems like vfat don't report any inodes, so we
	# can't check for sufficient free inodes; IOWs, FAFO.
	test "$_free_inodes" -eq 0 && return

	test "$_free_inodes" -lt "$nr" && \
		_notrun "Insufficient free inodes ($_free_inodes), need at least $nr"
}

_require_free_inodes $TEST_DIR 10001

(maybe clean up the comment a bit)

--D

Quoted 10 lines
tests/generic/645 +3 -0
+	_notrun "Insufficient free inodes ($_free_inodes), need at least 10001"
+fi
+
 echo "Silence is golden"
 
 $here/src/vfs/vfstest --test-nested-userns \
Signature · 1 line
2.53.0
#2 lore raw
Quoted 26 lines · Darrick J. Wong
Quoted 25 lines · Ojaswin Mujoo

When running generic/645 with ext4 using 64k block size + bigalloc, the test fails with ENOSPC because the filesystem runs out of inodes before the test completes.

The test creates approximately 10,001 files, however, in this particular configuration a standard 5G FS only has around ~5100 inodes resulting in the ENOSPC failure.

Add a check using _get_free_inode() to verify sufficient inodes are available before running the test, else skip it.

---
 tests/generic/645 | 6 ++++++
 1 file changed, 6 insertions(+)
tests/generic/645 +0 -0
index d6eb75e6..944b33db 100755
@@ -19,6 +19,12 @@ _require_chown
 _wants_kernel_commit dacfd001eaf2 \
 	"fs/mnt_idmapping.c: Return -EINVAL when no map is written"
 
Quoted 5 lines

tests/generic/645 _require_chown · line 23

Quoted 2 lines
tests/generic/645 +2 -0
+_free_inodes=$(_get_free_inode $TEST_DIR)
+if [ $_free_inodes -ne 0 ] && [ $_free_inodes -lt 10001 ]; then

I'm assuming the > 0 check here is to cover weird filesystems like fat that don't advertise any inodes? /me wonders if that ought to be a

Hey Darrick, sorry I missed this email earlier. Yes that's the idea. I see there is a helper already

_require_inode_limits()

{
	if [ $(_get_free_inode $TEST_DIR) -eq 0 ]; then
		_notrun "$FSTYP does not have a fixed number of inodes available"
	fi
}

But this will end up skipping the FSes that don't have a concept of free inodes.

Quoted 11 lines

common helper where we can record that justification:

_require_free_inodes() {
	local path="$1"
	local nr="$2"

	local _free_inodes=$(_get_free_inode "$path")

	# Weird filesystems like vfat don't report any inodes, so we
	# can't check for sufficient free inodes; IOWs, FAFO.
	test "$_free_inodes" -eq 0 && return

If we do this, won't we pass the check for the case where say xfs has 0 free inodes. It's a rare chance IMObut still wondering if we want to keep that edge case open.

What do you think in these options:
- use the above check
- use _require_free_inodes which will cause notruns on some FSes
- Maybe have a new helper to check if FS advertises free inodes and then use somthing like

if ! __fs_advertises_free_inodes
return
else
test "$_free_inodes" -lt "$nr" && \
_notrun "Insufficient free inodes ($_free_inodes), need at least $nr"

Regards,
ojaswin

Quoted 23 lines
	test "$_free_inodes" -lt "$nr" && \
		_notrun "Insufficient free inodes ($_free_inodes), need at least $nr"
}

_require_free_inodes $TEST_DIR 10001

(maybe clean up the comment a bit)

--D

Quoted 10 lines
tests/generic/645 +3 -0
+	_notrun "Insufficient free inodes ($_free_inodes), need at least 10001"
+fi
+
 echo "Silence is golden"
 
 $here/src/vfs/vfstest --test-nested-userns \
Signature · 1 line
2.53.0
#3 lore raw
Quoted 68 lines · Ojaswin Mujoo
Quoted 26 lines · Darrick J. Wong
Quoted 25 lines · Ojaswin Mujoo

When running generic/645 with ext4 using 64k block size + bigalloc, the test fails with ENOSPC because the filesystem runs out of inodes before the test completes.

The test creates approximately 10,001 files, however, in this particular configuration a standard 5G FS only has around ~5100 inodes resulting in the ENOSPC failure.

Add a check using _get_free_inode() to verify sufficient inodes are available before running the test, else skip it.

---
 tests/generic/645 | 6 ++++++
 1 file changed, 6 insertions(+)
tests/generic/645 +0 -0
index d6eb75e6..944b33db 100755
@@ -19,6 +19,12 @@ _require_chown
 _wants_kernel_commit dacfd001eaf2 \
 	"fs/mnt_idmapping.c: Return -EINVAL when no map is written"
 
Quoted 5 lines

tests/generic/645 _require_chown · line 23

Quoted 2 lines
tests/generic/645 +2 -0
+_free_inodes=$(_get_free_inode $TEST_DIR)
+if [ $_free_inodes -ne 0 ] && [ $_free_inodes -lt 10001 ]; then

I'm assuming the > 0 check here is to cover weird filesystems like fat that don't advertise any inodes? /me wonders if that ought to be a

Hey Darrick, sorry I missed this email earlier. Yes that's the idea. I see there is a helper already

_require_inode_limits()

{
	if [ $(_get_free_inode $TEST_DIR) -eq 0 ]; then
		_notrun "$FSTYP does not have a fixed number of inodes available"
	fi
}

But this will end up skipping the FSes that don't have a concept of free inodes.

Quoted 11 lines

common helper where we can record that justification:

_require_free_inodes() {
	local path="$1"
	local nr="$2"

	local _free_inodes=$(_get_free_inode "$path")

	# Weird filesystems like vfat don't report any inodes, so we
	# can't check for sufficient free inodes; IOWs, FAFO.
	test "$_free_inodes" -eq 0 && return

If we do this, won't we pass the check for the case where say xfs has 0 free inodes. It's a rare chance IMObut still wondering if we want to keep that edge case open.

What do you think in these options:
- use the above check
- use _require_free_inodes which will cause notruns on some FSes
- Maybe have a new helper to check if FS advertises free inodes and then use somthing like

Quoted 6 lines

if ! __fs_advertises_free_inodes
return
else
test "$_free_inodes" -lt "$nr" && \
_notrun "Insufficient free inodes ($_free_inodes), need at least $nr"

Hmmm. This is getting complicated, because generic tests can run on any filesystem and we have no idea how much space an inode actually consumes, or if the filesystem even has any real concept of inodes.

Can we instead check the vfstest output for the ENOSPC error message and _notrun it if that is found?

--D

Quoted 27 lines

Regards,
ojaswin

Quoted 23 lines
	test "$_free_inodes" -lt "$nr" && \
		_notrun "Insufficient free inodes ($_free_inodes), need at least $nr"
}

_require_free_inodes $TEST_DIR 10001

(maybe clean up the comment a bit)

--D

Quoted 10 lines
tests/generic/645 +3 -0
+	_notrun "Insufficient free inodes ($_free_inodes), need at least 10001"
+fi
+
 echo "Silence is golden"
 
 $here/src/vfs/vfstest --test-nested-userns \
Signature · 1 line
2.53.0
#4 lore raw
Quoted 76 lines · Darrick J. Wong
Quoted 68 lines · Ojaswin Mujoo
Quoted 26 lines · Darrick J. Wong
Quoted 25 lines · Ojaswin Mujoo

When running generic/645 with ext4 using 64k block size + bigalloc, the test fails with ENOSPC because the filesystem runs out of inodes before the test completes.

The test creates approximately 10,001 files, however, in this particular configuration a standard 5G FS only has around ~5100 inodes resulting in the ENOSPC failure.

Add a check using _get_free_inode() to verify sufficient inodes are available before running the test, else skip it.

---
 tests/generic/645 | 6 ++++++
 1 file changed, 6 insertions(+)
tests/generic/645 +0 -0
index d6eb75e6..944b33db 100755
@@ -19,6 +19,12 @@ _require_chown
 _wants_kernel_commit dacfd001eaf2 \
 	"fs/mnt_idmapping.c: Return -EINVAL when no map is written"
 
Quoted 5 lines

tests/generic/645 _require_chown · line 23

Quoted 2 lines
tests/generic/645 +2 -0
+_free_inodes=$(_get_free_inode $TEST_DIR)
+if [ $_free_inodes -ne 0 ] && [ $_free_inodes -lt 10001 ]; then

I'm assuming the > 0 check here is to cover weird filesystems like fat that don't advertise any inodes? /me wonders if that ought to be a

Hey Darrick, sorry I missed this email earlier. Yes that's the idea. I see there is a helper already

_require_inode_limits()

{
	if [ $(_get_free_inode $TEST_DIR) -eq 0 ]; then
		_notrun "$FSTYP does not have a fixed number of inodes available"
	fi
}

But this will end up skipping the FSes that don't have a concept of free inodes.

Quoted 11 lines

common helper where we can record that justification:

_require_free_inodes() {
	local path="$1"
	local nr="$2"

	local _free_inodes=$(_get_free_inode "$path")

	# Weird filesystems like vfat don't report any inodes, so we
	# can't check for sufficient free inodes; IOWs, FAFO.
	test "$_free_inodes" -eq 0 && return

If we do this, won't we pass the check for the case where say xfs has 0 free inodes. It's a rare chance IMObut still wondering if we want to keep that edge case open.

What do you think in these options:
- use the above check
- use _require_free_inodes which will cause notruns on some FSes
- Maybe have a new helper to check if FS advertises free inodes and then use somthing like

Quoted 6 lines

if ! __fs_advertises_free_inodes
return
else
test "$_free_inodes" -lt "$nr" && \
_notrun "Insufficient free inodes ($_free_inodes), need at least $nr"

Quoted 6 lines

Hmmm. This is getting complicated, because generic tests can run on any filesystem and we have no idea how much space an inode actually consumes, or if the filesystem even has any real concept of inodes.

Can we instead check the vfstest output for the ENOSPC error message and _notrun it if that is found?

Yes this sounds simple enough. The below diff works for me:

  diff --git a/tests/generic/645 b/tests/generic/645
  index d6eb75e6..3d8ca905 100755
  --- a/tests/generic/645
  +++ b/tests/generic/645
  @@ -22,7 +22,14 @@ _wants_kernel_commit dacfd001eaf2 \
   echo "Silence is golden"

$here/src/vfs/vfstest --test-nested-userns \

  -       --device "$TEST_DEV" --mount "$TEST_DIR" --fstype "$FSTYP"
  +       --device "$TEST_DEV" --mount "$TEST_DIR" --fstype "$FSTYP" \
  +       > $tmp.vfstest 2>&1

+if grep -q "No space left on device" $tmp.vfstest; then
+ _notrun "No space left on device"
+fi
+
+cat $tmp.vfstest
status=$?

If this looks good I cans send a formal patch.

Regards,
ojaswin

Quoted 30 lines

--D

Quoted 27 lines

Regards,
ojaswin

Quoted 23 lines
	test "$_free_inodes" -lt "$nr" && \
		_notrun "Insufficient free inodes ($_free_inodes), need at least $nr"
}

_require_free_inodes $TEST_DIR 10001

(maybe clean up the comment a bit)

--D

Quoted 10 lines
tests/generic/645 +3 -0
+	_notrun "Insufficient free inodes ($_free_inodes), need at least 10001"
+fi
+
 echo "Silence is golden"
 
 $here/src/vfs/vfstest --test-nested-userns \
Signature · 1 line
2.53.0
#5 lore raw
Quoted 98 lines · Ojaswin Mujoo
Quoted 76 lines · Darrick J. Wong
Quoted 68 lines · Ojaswin Mujoo
Quoted 26 lines · Darrick J. Wong
Quoted 25 lines · Ojaswin Mujoo

When running generic/645 with ext4 using 64k block size + bigalloc, the test fails with ENOSPC because the filesystem runs out of inodes before the test completes.

The test creates approximately 10,001 files, however, in this particular configuration a standard 5G FS only has around ~5100 inodes resulting in the ENOSPC failure.

Add a check using _get_free_inode() to verify sufficient inodes are available before running the test, else skip it.

---
 tests/generic/645 | 6 ++++++
 1 file changed, 6 insertions(+)
tests/generic/645 +0 -0
index d6eb75e6..944b33db 100755
@@ -19,6 +19,12 @@ _require_chown
 _wants_kernel_commit dacfd001eaf2 \
 	"fs/mnt_idmapping.c: Return -EINVAL when no map is written"
 
Quoted 5 lines

tests/generic/645 _require_chown · line 23

Quoted 2 lines
tests/generic/645 +2 -0
+_free_inodes=$(_get_free_inode $TEST_DIR)
+if [ $_free_inodes -ne 0 ] && [ $_free_inodes -lt 10001 ]; then

I'm assuming the > 0 check here is to cover weird filesystems like fat that don't advertise any inodes? /me wonders if that ought to be a

Hey Darrick, sorry I missed this email earlier. Yes that's the idea. I see there is a helper already

_require_inode_limits()

{
	if [ $(_get_free_inode $TEST_DIR) -eq 0 ]; then
		_notrun "$FSTYP does not have a fixed number of inodes available"
	fi
}

But this will end up skipping the FSes that don't have a concept of free inodes.

Quoted 11 lines

common helper where we can record that justification:

_require_free_inodes() {
	local path="$1"
	local nr="$2"

	local _free_inodes=$(_get_free_inode "$path")

	# Weird filesystems like vfat don't report any inodes, so we
	# can't check for sufficient free inodes; IOWs, FAFO.
	test "$_free_inodes" -eq 0 && return

If we do this, won't we pass the check for the case where say xfs has 0 free inodes. It's a rare chance IMObut still wondering if we want to keep that edge case open.

What do you think in these options:
- use the above check
- use _require_free_inodes which will cause notruns on some FSes
- Maybe have a new helper to check if FS advertises free inodes and then use somthing like

Quoted 6 lines

if ! __fs_advertises_free_inodes
return
else
test "$_free_inodes" -lt "$nr" && \
_notrun "Insufficient free inodes ($_free_inodes), need at least $nr"

Quoted 6 lines

Hmmm. This is getting complicated, because generic tests can run on any filesystem and we have no idea how much space an inode actually consumes, or if the filesystem even has any real concept of inodes.

Can we instead check the vfstest output for the ENOSPC error message and _notrun it if that is found?

Yes this sounds simple enough. The below diff works for me:

  diff --git a/tests/generic/645 b/tests/generic/645
  index d6eb75e6..3d8ca905 100755
  --- a/tests/generic/645
  +++ b/tests/generic/645
  @@ -22,7 +22,14 @@ _wants_kernel_commit dacfd001eaf2 \
   echo "Silence is golden"
   $here/src/vfs/vfstest --test-nested-userns \
  -       --device "$TEST_DEV" --mount "$TEST_DIR" --fstype "$FSTYP"
  +       --device "$TEST_DEV" --mount "$TEST_DIR" --fstype "$FSTYP" \
  +       > $tmp.vfstest 2>&1
Quoted 8 lines

+if grep -q "No space left on device" $tmp.vfstest; then
+ _notrun "No space left on device"
+fi
+
+cat $tmp.vfstest
status=$?

If this looks good I cans send a formal patch.

Yes! :)

--D

Quoted 34 lines

Regards,
ojaswin

Quoted 30 lines

--D

Quoted 27 lines

Regards,
ojaswin

Quoted 23 lines
	test "$_free_inodes" -lt "$nr" && \
		_notrun "Insufficient free inodes ($_free_inodes), need at least $nr"
}

_require_free_inodes $TEST_DIR 10001

(maybe clean up the comment a bit)

--D

Quoted 10 lines
tests/generic/645 +3 -0
+	_notrun "Insufficient free inodes ($_free_inodes), need at least 10001"
+fi
+
 echo "Silence is golden"
 
 $here/src/vfs/vfstest --test-nested-userns \
Signature · 1 line
2.53.0