KVM: x86: WARN (once) if RTC pending EOI tracking goes off the rails
Sean Christopherson
maintainerPATCH 1/1 KVM: x86: WARN (once) if RTC pending EOI tracking goes off the rails
WARN once if KVM's tracking for pending EOIs for Real-Time Clock IRQs goes off the rails, as there's no reason to bug the host or risk a DoS due to spamming dmesg with endless WARNs. Absolute worst case scenario, guest time will go awry.
Signed-off-by Sean Christopherson <[email protected]>
--- arch/x86/kvm/ioapic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kvm/ioapic.c +2 -2
@@ -84,7 +84,7 @@ static void kvm_rtc_eoi_tracking_restore_all(struct kvm_ioapic *ioapic);static void rtc_status_pending_eoi_check_valid (struct kvm_ioapic *ioapic) { -if (WARN_ON (ioapic->rtc_status.pending_eoi <0 )) +if (WARN_ON_ONCE (ioapic->rtc_status.pending_eoi <0 ))kvm_rtc_eoi_tracking_restore_all (ioapic); }
@@ -484,7 +484,7 @@ static int ioapic_service(struct kvm_ioapic *ioapic, int irq, bool line_status)* ensures that it is only called if it is >= zero, namely * if rtc_irq_check_coalesced returns false). */ -BUG_ON (ioapic->rtc_status.pending_eoi !=0 ); +WARN_ON_ONCE (ioapic->rtc_status.pending_eoi); ret =__kvm_irq_delivery_to_apic (ioapic->kvm,NULL , &irqe, &ioapic->rtc_status); ioapic->rtc_status.pending_eoi = (ret <0 ?0 : ret);
base-commit: 9d4853b044beefa21c4ee3e18c40653601a64ced
Signature · 1 line
2.55.0.rc0.738.g0c8ab3ebcc-goog
Quoted 6 lines · Sean Christopherson
WARN once if KVM's tracking for pending EOIs for Real-Time Clock IRQs goes off the rails, as there's no reason to bug the host or risk a DoS due to spamming dmesg with endless WARNs. Absolute worst case scenario, guest time will go awry.
Signed-off-by Sean Christopherson <[email protected]>
Reviewed-by Kai Huang <[email protected]>
Queued, thanks.
Paolo