Skip to contentSkip to conversation

staging: rtl8723bs: remove unused rtl8192c function declarations

PATCH New Jad Keskes 1 participant 3 messages Jun 18 Staging

lore
Share & tools
lore

Jad Keskes

author
#0 lore raw

PATCH 1/3 staging: rtl8723bs: remove unused rtl8192c function declarations

Remove two function declarations from rtl8192c_recv.h that have no implementation and are never called in the rtl8723bs driver:

- rtl8192c_translate_rx_signal_stuff()
- rtl8192c_query_rx_desc_status()

These are leftovers from the original Realtek multi-chip codebase and relate to the RTL8192C family, not the RTL8723B.

Signed-off-by Jad Keskes <[email protected]>
---
 drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/rtl8723bs/include/rtl8192c_recv.h +0 -4
index e2e9aa03ffdf..b63625ab4e45 100644
@@ -30,8 +30,4 @@ struct phy_stat {
 /*  Rx smooth factor */
 #define	Rx_Smooth_Factor (20)
 
-
-void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe, struct phy_stat *pphy_status);
-void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
-
 #endif
Signature · 1 line
2.54.0
author
#1 lore raw

PATCH 2/3 staging: rtl8723bs: remove unused AMPDU burst mode values for other chips

Remove enum values from rt_ampdu_burst that correspond to chips not supported by this driver:

- RT_AMPDU_BURST_92D
- RT_AMPDU_BURST_88E
- RT_AMPDU_BURST_8812_4/8/12/15

These are leftovers from the original Realtek multi-chip codebase. Only RT_AMPDU_BURST_NONE and RT_AMPDU_BURST_8723B are kept.

While here, remove the stale comment referencing 92C.

Signed-off-by Jad Keskes <[email protected]>
---
 drivers/staging/rtl8723bs/include/hal_data.h | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
drivers/staging/rtl8723bs/include/hal_data.h +2 -8
index ff4383e30322..4383f404c7da 100644
@@ -37,13 +37,7 @@ enum rt_regulator_mode {
 
 enum rt_ampdu_burst {
 	RT_AMPDU_BURST_NONE	= 0,
-	RT_AMPDU_BURST_92D	= 1,
-	RT_AMPDU_BURST_88E	= 2,
-	RT_AMPDU_BURST_8812_4	= 3,
-	RT_AMPDU_BURST_8812_8	= 4,
-	RT_AMPDU_BURST_8812_12	= 5,
-	RT_AMPDU_BURST_8812_15	= 6,
-	RT_AMPDU_BURST_8723B	= 7,
+	RT_AMPDU_BURST_8723B	= 1,
 };
 
 #define CHANNEL_MAX_NUMBER		(14)	/*  14 is the max channel number */

@@ -363,7 +357,7 @@ struct hal_com_data {
 	u8 RegIQKFWOffload;
 	struct submit_ctx	iqk_sctx;
 
-	enum rt_ampdu_burst	AMPDUBurstMode; /* 92C maybe not use, but for compile successfully */
+	enum rt_ampdu_burst	AMPDUBurstMode;
 
 	u32 		sdio_himr;
 	u32 		sdio_hisr;
Signature · 1 line
2.54.0
author
#2 lore raw

PATCH 3/3 staging: rtl8723bs: remove unused RF_PATH_MAX_90_8812 define

In reply to Jad Keskes

Remove RF_PATH_MAX_90_8812 which is a leftover from RTL8812 chip support and is not referenced anywhere in this driver.

Signed-off-by Jad Keskes <[email protected]>
---
 drivers/staging/rtl8723bs/include/hal_phy.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8723bs/include/hal_phy.h +0 -1
index 3d71a4f41592..a4d15879f01d 100644
@@ -39,7 +39,6 @@ enum rf_path {
 #define	TX_4S			3
 
 #define	RF_PATH_MAX_92C_88E		2
-#define	RF_PATH_MAX_90_8812		4	/* Max RF number 90 support */
 
 enum wireless_mode {
 	WIRELESS_MODE_UNKNOWN = 0x00,
Signature · 1 line
2.54.0