staging: rtl8723bs: fix missing unregister_netdev on sdio_alloc_irq failure
PATCH 1/1 staging: rtl8723bs: fix missing unregister_netdev on sdio_alloc_irq failure
In rtw_drv_init(), if rtw_drv_register_netdev() succeeds but sdio_alloc_irq() fails, the error path jumps to free_if1 and calls rtw_sdio_if1_deinit(). However, rtw_sdio_if1_deinit() calls rtw_free_netdev() without a preceding unregister_netdev(), freeing a still-registered netdev but leaving stale sysfs entries behind.
Signed-off-by Devansh Soni <[email protected]>
--- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/os_dep/sdio_intf.c +4 -1
@@ -359,10 +359,13 @@ static int rtw_drv_init( status =sdio_alloc_irq (dvobj);if (status != _SUCCESS) - goto free_if1; + goto free_netdev; status = _SUCCESS; +free_netdev: +if (status != _SUCCESS) +rtw_unregister_netdevs (dvobj); free_if1:if (status != _SUCCESS && if1)rtw_sdio_if1_deinit (if1);
Signature · 1 line
2.54.0