Skip to contentSkip to conversation

mm/damon: handle zero sampling interval in damon_max_nr_accesses()

RFC PATCH In review SeongJae Park 2 participants 3 messages Jun 19

Subsystems (3)
lore
Share & tools
lore

SeongJae Park

author maintainer
#0 lore raw

RFC PATCH 1/1 mm/damon: handle zero sampling interval in damon_max_nr_accesses()

damon_max_nr_accesses() causes divide-by-zero if sampling interval is zero. Fix it by handling the case.

The issue was dicovered [1] by Sashiko.

[1] https://lore.kernel.org/[email protected]

Fixes 198f0f4c58b9 ("mm/damon/vaddr,paddr: support pageout prioritization")
Cc <[email protected]> # 5.16.x
---
 include/linux/damon.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
include/linux/damon.h +3 -1
index 64d75c78f4df4..b6fbe6089abc6 100644
@@ -1066,8 +1066,10 @@ static inline bool damon_target_has_pid(const struct damon_ctx *ctx)
 
 static inline unsigned int damon_max_nr_accesses(const struct damon_attrs *attrs)
 {
+	unsigned long sample_interval = attrs->sample_interval ? : 1;
+
 	/* {aggr,sample}_interval are unsigned long, hence could overflow */
-	return min(attrs->aggr_interval / attrs->sample_interval,
+	return min(attrs->aggr_interval / sample_interval,
 			(unsigned long)UINT_MAX);
 }
 

base-commit: 7a58ae62cdf3c006a53b805bbb12079ab2621a07

Signature · 1 line
2.47.3
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The patch replaces a divide-by-zero crash in damon_max_nr_accesses() with a divide-by-zero crash in caller functions such as damon_hot_score(). When aggr_interval and sample_interval are 0, damon_max_nr_accesses() returns 0, which is then used as a divisor by its callers. --

commit ca6b91d50d3b7234e014066f6e835c8aab906f49
Author: SeongJae Park <[email protected]>

mm/damon: handle zero sampling interval in damon_max_nr_accesses()

damon_max_nr_accesses() causes divide-by-zero if sampling interval is zero. Fix it by handling the case.

Quoted 5 lines
include/linux/damon.h +0 -0
index 6f7edb3590ef9..83b43d8ffef38 100644

include/linux/damon.h static inline bool damon_target_has_pid(const struct damon_ctx *ctx) · line 1073

Quoted 10 lines
include/linux/damon.h +3 -1
@@ -1065,8 +1065,10 @@ static inline bool damon_target_has_pid(const struct damon_ctx *ctx)
 
 static inline unsigned int damon_max_nr_accesses(const struct damon_attrs *attrs)
 {
+	unsigned long sample_interval = attrs->sample_interval ? : 1;
+
 	/* {aggr,sample}_interval are unsigned long, hence could overflow */
-	return min(attrs->aggr_interval / attrs->sample_interval,
+	return min(attrs->aggr_interval / sample_interval,
 			(unsigned long)UINT_MAX);
 }

[Severity: High]
This is a pre-existing issue, but does this patch shift the divide-by-zero crash to the callers of damon_max_nr_accesses()?

If a user configures DAMON via sysfs with both sample_interval and aggr_interval set to 0, damon_set_attrs() allows it because the validation check evaluates to false (0 > 0):

mm/damon/core.c:damon_set_attrs() {
	if (attrs->sample_interval > attrs->aggr_interval)
		return -EINVAL;
	...
}

With this patch applied, damon_max_nr_accesses() prevents the initial division by zero by defaulting sample_interval to 1. However, it then evaluates min(0 / 1, UINT_MAX) and returns 0.

Later, when a DAMOS scheme with a quota is evaluated, damon_hot_score() uses the return value as a divisor:

mm/damon/ops-common.c:damon_hot_score() {
	...
	freq_subscore = r->nr_accesses * DAMON_MAX_SUBSCORE /
			damon_max_nr_accesses(&c->attrs);
	...
}

Since damon_max_nr_accesses() now successfully returns 0, wouldn't this trigger a divide-by-zero exception in damon_hot_score() instead?

Could we explicitly reject an aggr_interval of 0 in damon_set_attrs(), or ensure damon_max_nr_accesses() always returns at least 1?

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
author maintainer
#2 lore raw
Quoted 60 lines · On Fri, 19 Jun 2026 21:03:04 +0000 [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The patch replaces a divide-by-zero crash in damon_max_nr_accesses() with a divide-by-zero crash in caller functions such as damon_hot_score(). When aggr_interval and sample_interval are 0, damon_max_nr_accesses() returns 0, which is then used as a divisor by its callers. --

commit ca6b91d50d3b7234e014066f6e835c8aab906f49
Author: SeongJae Park <[email protected]>

mm/damon: handle zero sampling interval in damon_max_nr_accesses()

damon_max_nr_accesses() causes divide-by-zero if sampling interval is zero. Fix it by handling the case.

Quoted 5 lines
include/linux/damon.h +0 -0
index 6f7edb3590ef9..83b43d8ffef38 100644

include/linux/damon.h static inline bool damon_target_has_pid(const struct damon_ctx *ctx) · line 1073

Quoted 10 lines
include/linux/damon.h +3 -1
@@ -1065,8 +1065,10 @@ static inline bool damon_target_has_pid(const struct damon_ctx *ctx)
 
 static inline unsigned int damon_max_nr_accesses(const struct damon_attrs *attrs)
 {
+	unsigned long sample_interval = attrs->sample_interval ? : 1;
+
 	/* {aggr,sample}_interval are unsigned long, hence could overflow */
-	return min(attrs->aggr_interval / attrs->sample_interval,
+	return min(attrs->aggr_interval / sample_interval,
 			(unsigned long)UINT_MAX);
 }

[Severity: High]
This is a pre-existing issue, but does this patch shift the divide-by-zero crash to the callers of damon_max_nr_accesses()?

If a user configures DAMON via sysfs with both sample_interval and aggr_interval set to 0, damon_set_attrs() allows it because the validation check evaluates to false (0 > 0):

mm/damon/core.c:damon_set_attrs() {
	if (attrs->sample_interval > attrs->aggr_interval)
		return -EINVAL;
	...
}

With this patch applied, damon_max_nr_accesses() prevents the initial division by zero by defaulting sample_interval to 1. However, it then evaluates min(0 / 1, UINT_MAX) and returns 0.

Later, when a DAMOS scheme with a quota is evaluated, damon_hot_score() uses the return value as a divisor:

mm/damon/ops-common.c:damon_hot_score() {
	...
	freq_subscore = r->nr_accesses * DAMON_MAX_SUBSCORE /
			damon_max_nr_accesses(&c->attrs);
	...
}
Quoted 5 lines

Since damon_max_nr_accesses() now successfully returns 0, wouldn't this trigger a divide-by-zero exception in damon_hot_score() instead?

Could we explicitly reject an aggr_interval of 0 in damon_set_attrs(), or ensure damon_max_nr_accesses() always returns at least 1?

Ah, good catch. I will fix this in the next revision, like below:

'''

include/linux/damon.h +2 -2
@@ -1252,11 +1252,11 @@ static inline bool damon_target_has_pid(const struct damon_ctx *ctx)
 
 static inline unsigned int damon_max_nr_accesses(const struct damon_attrs *attrs)
 {
+       unsigned long aggr_interval = attrs->aggr ? : 1;
        unsigned long sample_interval = attrs->sample_interval ? : 1;
 
        /* {aggr,sample}_interval are unsigned long, hence could overflow */
-       return min(attrs->aggr_interval / sample_interval,
-                       (unsigned long)UINT_MAX);
+       return min(ggr_interval / sample_interval, (unsigned long)UINT_MAX);
 }

'''

Thanks,
SJ

[...]