Skip to contentSkip to conversation

platform/x86: asus-armoury: Add power limits for FA401KM

PATCH New Marco Scardovi 2 participants 5 messages Jun 21 – Jul 7 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

cover platform/x86: asus-armoury: Add power limits for FA401KM

Hi everyone,

This patch adds the power limits quirk entry for the ASUS ROG FA401KM laptop. The limits are extracted from the device's ThrottleGear XML configuration file using my ThrottleGear program https://github.com/mscardovi/throttlegear.

Marco Scardovi (1):
platform/x86: asus-armoury: Add power limits quirk for FA401KM

 drivers/platform/x86/asus-armoury.h | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/1 platform/x86: asus-armoury: Add power limits quirk for FA401KM

Add power limits quirk entry for ASUS ROG FA401KM laptop.
The limits are extracted from the device's ThrottleGear XML configuration file for the 'Ryzen' profile.

Assisted-by ThrottleGear
---
 drivers/platform/x86/asus-armoury.h | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
drivers/platform/x86/asus-armoury.h +32 -0
@@ -371,6 +371,38 @@
 	},
 	{
 		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "FA401KM"),
+		},
+		.driver_data = &(struct power_data) {
+			.ac_data = &(struct power_limits) {
+				.nv_dynamic_boost_max = 15,
+				.nv_dynamic_boost_min = 5,
+				.nv_temp_target_max = 87,
+				.nv_temp_target_min = 75,
+				.nv_tgp_max = 95,
+				.nv_tgp_min = 55,
+				.ppt_pl1_spl_max = 80,
+				.ppt_pl1_spl_min = 15,
+				.ppt_pl2_sppt_max = 80,
+				.ppt_pl2_sppt_min = 35,
+				.ppt_pl3_fppt_max = 80,
+				.ppt_pl3_fppt_min = 35,
+			},
+			.dc_data = &(struct power_limits) {
+				.nv_temp_target_max = 87,
+				.nv_temp_target_min = 75,
+				.ppt_pl1_spl_max = 35,
+				.ppt_pl1_spl_min = 25,
+				.ppt_pl2_sppt_max = 44,
+				.ppt_pl2_sppt_min = 31,
+				.ppt_pl3_fppt_max = 65,
+				.ppt_pl3_fppt_min = 45,
+			},
+			.requires_fan_curve = true,
+		},
+	},
+	{
+		.matches = {
 			DMI_MATCH(DMI_BOARD_NAME, "FA401UM"),
 		},
 		.driver_data = &(struct power_data) {
Signature · 1 line
2.34.1
#2 lore raw

v2 cover platform/x86: asus-armoury: Add power limits for FA401KM

Hi everyone,

As Denis pointed to me, Assisted-by is used for AI contribution, while mine is a simple program to extract values. I'm gonna push it again as v2 without the tag.

This patch adds the power limits quirk entry for the ASUS ROG FA401KM laptop. The limits are extracted from the device's ThrottleGear XML configuration file using my ThrottleGear program https://github.com/mscardovi/throttlegear.

Changes in v2:
- Removed Assisted-by tag from the patch.
- It does not provide any changes on codebase.

Marco Scardovi (1):
platform/x86: asus-armoury: Add power limits quirk for FA401KM

 drivers/platform/x86/asus-armoury.h | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
Signature · 1 line
2.34.1
#3 lore raw

PATCH v2 1/1 platform/x86: asus-armoury: Add power limits quirk for FA401KM

Add power limits quirk entry for ASUS ROG FA401KM laptop.
The limits are extracted from the device's ThrottleGear XML configuration file for the 'Ryzen' profile.

---
 drivers/platform/x86/asus-armoury.h | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
drivers/platform/x86/asus-armoury.h +32 -0
@@ -371,6 +371,38 @@
 	},
 	{
 		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "FA401KM"),
+		},
+		.driver_data = &(struct power_data) {
+			.ac_data = &(struct power_limits) {
+				.nv_dynamic_boost_max = 15,
+				.nv_dynamic_boost_min = 5,
+				.nv_temp_target_max = 87,
+				.nv_temp_target_min = 75,
+				.nv_tgp_max = 95,
+				.nv_tgp_min = 55,
+				.ppt_pl1_spl_max = 80,
+				.ppt_pl1_spl_min = 15,
+				.ppt_pl2_sppt_max = 80,
+				.ppt_pl2_sppt_min = 35,
+				.ppt_pl3_fppt_max = 80,
+				.ppt_pl3_fppt_min = 35,
+			},
+			.dc_data = &(struct power_limits) {
+				.nv_temp_target_max = 87,
+				.nv_temp_target_min = 75,
+				.ppt_pl1_spl_max = 35,
+				.ppt_pl1_spl_min = 25,
+				.ppt_pl2_sppt_max = 44,
+				.ppt_pl2_sppt_min = 31,
+				.ppt_pl3_fppt_max = 65,
+				.ppt_pl3_fppt_min = 45,
+			},
+			.requires_fan_curve = true,
+		},
+	},
+	{
+		.matches = {
 			DMI_MATCH(DMI_BOARD_NAME, "FA401UM"),
 		},
 		.driver_data = &(struct power_data) {
Signature · 1 line
2.54.0
maintainer
#4 lore raw
In reply to Marco Scardovi
Quoted 9 lines · Marco Scardovi

As Denis pointed to me, Assisted-by is used for AI contribution, while mine is a simple program to extract values. I'm gonna push it again as v2 without the tag.

This patch adds the power limits quirk entry for the ASUS ROG FA401KM laptop. The limits are extracted from the device's ThrottleGear XML configuration file using my ThrottleGear program https://github.com/mscardovi/throttlegear.

[...]

Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also fixes are mostly routed through for-next unless the fix is for a commit introduced in the most recent cycle or is clearly a regression fix.

The list of commits applied:
[1/1] platform/x86: asus-armoury: Add power limits quirk for FA401KM

      commit: 2729f12006f94b52238fdeda4a9aa4f3c749f218

--
i.