Skip to contentSkip to conversation

platform/x86: asus-armoury: Add power limits for ROG Strix SCAR 16 (G635LX)

PATCH In review Avi Fenesh 2 participants 2 messages Jun 21 – Jul 7 x86 platform drivers

lore
Share & tools
lore

Avi Fenesh

author
#0 lore raw

PATCH 1/1 platform/x86: asus-armoury: Add power limits for ROG Strix SCAR 16 (G635LX)

Add the AC and DC power limit definitions for the ASUS ROG Strix SCAR 16 2025 (G635LX), enabling the nv_tgp, nv_dynamic_boost and ppt_pl*_* tuning attributes on this model. Without an entry in the power_limits table the attributes are not exposed (has_valid_limit() returns false) and the firmware power knobs cannot be controlled.

The G635LX ships an NVIDIA RTX 5090 Laptop GPU (150 W base TGP + 25 W Dynamic Boost = 175 W max, per the ASUS specification) and an Intel Core Ultra 9 275HX, matching the ROG Strix SCAR 18 (G835LW). The limits are therefore taken from the G835LW sibling entry and the ASUS specification rather than dumped from this board's firmware.

Testing on a G635LX confirmed the attributes populate with this entry and that writing nv_dynamic_boost changes the measured GPU power draw (~151 W at minimum, ~169 W at maximum during inference), i.e. the limits reach firmware.

---
 drivers/platform/x86/asus-armoury.h | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
drivers/platform/x86/asus-armoury.h +29 -0
index c30d2b451..15584e775 100644
@@ -1840,6 +1840,35 @@ static const struct dmi_system_id power_limits[] = {
 			.requires_fan_curve = true,
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "G635LX"),
+		},
+		.driver_data = &(struct power_data) {
+			.ac_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 28,
+				.ppt_pl1_spl_def = 140,
+				.ppt_pl1_spl_max = 175,
+				.ppt_pl2_sppt_min = 28,
+				.ppt_pl2_sppt_max = 175,
+				.nv_dynamic_boost_min = 5,
+				.nv_dynamic_boost_max = 25,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+				.nv_tgp_min = 80,
+				.nv_tgp_max = 150,
+			},
+			.dc_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 25,
+				.ppt_pl1_spl_max = 55,
+				.ppt_pl2_sppt_min = 25,
+				.ppt_pl2_sppt_max = 70,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+			},
+			.requires_fan_curve = true,
+		},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_NAME, "G713PV"),
Signature · 1 line
2.53.0
maintainer
#1 lore raw
Quoted 6 lines · Avi Fenesh

Add the AC and DC power limit definitions for the ASUS ROG Strix SCAR 16 2025 (G635LX), enabling the nv_tgp, nv_dynamic_boost and ppt_pl*_* tuning attributes on this model. Without an entry in the power_limits table the attributes are not exposed (has_valid_limit() returns false) and the firmware power knobs cannot be controlled.

Quoted 7 lines

The G635LX ships an NVIDIA RTX 5090 Laptop GPU (150 W base TGP + 25 W Dynamic Boost = 175 W max, per the ASUS specification) and an Intel Core Ultra 9 275HX, matching the ROG Strix SCAR 18 (G835LW). The limits are therefore taken from the G835LW sibling entry and the ASUS specification rather than dumped from this board's firmware.

[...]

Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also fixes are mostly routed through for-next unless the fix is for a commit introduced in the most recent cycle or is clearly a regression fix.

The list of commits applied:
[1/1] platform/x86: asus-armoury: Add power limits for ROG Strix SCAR 16 (G635LX)

      commit: 861678dec600ab9e792fdabafefbe62ea855c193

--
i.