Skip to contentSkip to conversation

futex: Add EFAULT coverage for wake and cmp_requeue

PATCH Superseded Michael Menasherov via ltp 3 participants 8 messages Jun 21 – Jul 3

v16 of 17 Superseded Latest is v17 →

lore
Share & tools
lore
#0 lore raw

v16 cover futex: Add EFAULT coverage for wake and cmp_requeue

futex_wait06 and futex_wait07 were already merged. This series contains the two remaining patches.

Patch 1/2 (futex_wake05) is v16 — updated based on review feedback to add a kernel-space address test case and clarify the comment explaining the different code paths in get_futex_key().

Patch 2/2 (futex_cmp_requeue03) — updated to also cover PROT_NONE on uaddr2, and has not yet received a human review. Would appreciate a review of this patch as well.

GitHub PR: https://github.com/linux-test-project/ltp/pull/1301

Michael Menasherov (2):
futex_wake05: Add EFAULT error coverage test
futex_cmp_requeue03: Add EFAULT error coverage test

 runtest/syscalls                              |   2 +
 testcases/kernel/syscalls/futex/.gitignore    |   2 +
 .../syscalls/futex/futex_cmp_requeue03.c      | 108 ++++++++++++++++++
 .../kernel/syscalls/futex/futex_wake05.c      | 100 ++++++++++++++++
 4 files changed, 212 insertions(+)
 create mode 100644 testcases/kernel/syscalls/futex/futex_cmp_requeue03.c
 create mode 100644 testcases/kernel/syscalls/futex/futex_wake05.c
Signature · 5 lines
2.54.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

PATCH v16 1/2 futex_wake05: Add EFAULT error coverage test

futex(FUTEX_WAKE) has no existing test for EFAULT. Add coverage for unmapped, PROT_NONE, and kernel-space uaddr, each exercising a different code path in the kernel's address validation.

---
 runtest/syscalls                              |   1 +
 testcases/kernel/syscalls/futex/.gitignore    |   1 +
 .../kernel/syscalls/futex/futex_wake05.c      | 100 ++++++++++++++++++
 3 files changed, 102 insertions(+)
 create mode 100644 testcases/kernel/syscalls/futex/futex_wake05.c
runtest/syscalls +1 -0
index a021c79da..67509826f 100644
@@ -1878,6 +1878,7 @@ futex_wake01 futex_wake01
 futex_wake02 futex_wake02
 futex_wake03 futex_wake03
 futex_wake04 futex_wake04
+futex_wake05 futex_wake05
 futex_wait_bitset01 futex_wait_bitset01
 
 memfd_create01 memfd_create01
testcases/kernel/syscalls/futex/.gitignore +1 -0
index 74ac9a926..c11546e07 100644
@@ -15,3 +15,4 @@
 /futex_waitv03
 /futex_wait06
 /futex_wait07
+/futex_wake05
testcases/kernel/syscalls/futex/futex_wake05.c new file +100 -0

100 lines not on this page · raw message

Signature · 5 lines
2.54.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Re: [LTP] futex_wake05: Add EFAULT error coverage test

Hi Michael,

Quoted 1 line · Michael Menasherov

futex_wake05: Add EFAULT error coverage test

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw

Re: [LTP] [PATCH v16 1/2] futex_wake05: Add EFAULT error coverage test

In reply to Michael Menasherov via ltp

Hi Michael,

Quoted 3 lines

futex(FUTEX_WAKE) has no existing test for EFAULT. Add coverage for unmapped, PROT_NONE, and kernel-space uaddr, each exercising a different code path in the kernel's address validation.

Generally LGTM, few comments below.

Quoted 15 lines
testcases/kernel/syscalls/futex/futex_wake05.c new file +9 -0
new file mode 100644
index 000000000..597426f0a
@@ -0,0 +1,100 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (C) 2026 Red Hat, Inc.
+ * Copyright (C) 2026 Michael Menasherov <[email protected]>
+ */
+
+/*\
+ * Check that futex(FUTEX_WAKE) returns EFAULT when uaddr points to
+ * unmapped, PROT_NONE, or kernel-space memory.

testcases/kernel/syscalls/futex/futex_wake05.c line 19

Quoted 10 lines
testcases/kernel/syscalls/futex/futex_wake05.c new file +10 -0
+ *
+ * For opflags=0 (no FUTEX_PRIVATE_FLAG) futex_wake() takes the
+ * shared-futex path in get_futex_key() which must resolve the physical
+ * page.
+ *
+ * The three cases exercise different code paths: a kernel-space address
+ * is rejected by the kernel's user-space address check before physical
+ * page resolution; unmapped memory fails at find_vma() (no VMA exists);
+ * PROT_NONE memory fails at get_user_pages_fast() (VMA exists but page
+ * is inaccessible).

nit: It'd be more readable using list:

* The three cases exercise different code paths:

* - a kernel-space address * is rejected by the kernel's user-space address
* check before physical page resolution
* - unmapped memory fails at find_vma() (no VMA exists)
* - PROT_NONE memory fails at get_user_pages_fast() (VMA exists but page
* is inaccessible)

Quoted 30 lines
testcases/kernel/syscalls/futex/futex_wake05.c new file +30 -0
+ */
+
+#include <errno.h>
+#include <sys/mman.h>
+
+#include "futextest.h"
+
+static futex_t *unmapped_addr;
+static futex_t *prot_none_addr;
+static futex_t *kernel_addr = (futex_t *)-1L;
+
+static struct futex_test_variants variants[] = {
+#if (__NR_futex != __LTP__NR_INVALID_SYSCALL)
+	{ .fntype = FUTEX_FN_FUTEX, .desc = "syscall with old kernel spec"},
+#endif
+
+#if (__NR_futex_time64 != __LTP__NR_INVALID_SYSCALL)
+	{ .fntype = FUTEX_FN_FUTEX64, .desc = "syscall time64 with kernel spec"},
+#endif
+};
+
+static struct testcase {
+	const char *desc;
+	futex_t **addr;
+	int exp_errno;
+} testcases[] = {
+	{
+		.desc = "uaddr unmapped",
+		.addr = &unmapped_addr,
+		.exp_errno = EFAULT,

testcases/kernel/syscalls/futex/futex_wake05.c line 59

Quoted 10 lines
testcases/kernel/syscalls/futex/futex_wake05.c new file +10 -0
+	},
+	{
+		.desc = "uaddr PROT_NONE",
+		.addr = &prot_none_addr,
+		.exp_errno = EFAULT,
+	},
+	{
+		.desc = "uaddr kernel address",
+		.addr = &kernel_addr,
+		.exp_errno = EFAULT,

nit: If all errors are EFAULT why not use it directly in TST_EXP_FAIL?

But more important is that I got a different errno (EINVAL) on 7.0.x kernel on old kernel spec:

futex_wake05.c:77: TINFO: Testing variant: syscall with old kernel spec futex_wake05.c:68: TFAIL: uaddr kernel address expected EFAULT: EINVAL (22)

When compiling 32 bit, I get error on both specs:

PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig CFLAGS=-m32 LDFLAGS=-m32 ./configure
...
futex_wake05.c:77: TINFO: Testing variant: syscall with old kernel spec futex_wake05.c:68: TPASS: uaddr unmapped : EFAULT (14) futex_wake05.c:68: TPASS: uaddr PROT_NONE : EFAULT (14) futex_wake05.c:68: TFAIL: uaddr kernel address expected EFAULT: EINVAL (22) futex_wake05.c:77: TINFO: Testing variant: syscall time64 with kernel spec futex_wake05.c:68: TPASS: uaddr unmapped : EFAULT (14) futex_wake05.c:68: TPASS: uaddr PROT_NONE : EFAULT (14) futex_wake05.c:68: TFAIL: uaddr kernel address expected EFAULT: EINVAL (22)

I tested very old kernel 4.4 (SLE12-SP3 we still support) and it behaves the same. Do you really get EFAULT?

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#5 lore raw

PATCH v16 2/2 futex_cmp_requeue03: Add EFAULT error coverage test

In reply to Michael Menasherov via ltp

futex(FUTEX_CMP_REQUEUE) has no existing test for EFAULT. Add coverage for the cases where uaddr or uaddr2 points to unmapped or inaccessible (PROT_NONE) memory.

---
 runtest/syscalls                              |   1 +
 testcases/kernel/syscalls/futex/.gitignore    |   1 +
 .../syscalls/futex/futex_cmp_requeue03.c      | 108 ++++++++++++++++++
 3 files changed, 110 insertions(+)
 create mode 100644 testcases/kernel/syscalls/futex/futex_cmp_requeue03.c
runtest/syscalls +1 -0
index 67509826f..0cb4e3dba 100644
@@ -1864,6 +1864,7 @@ perf_event_open02 perf_event_open02
 
 futex_cmp_requeue01 futex_cmp_requeue01
 futex_cmp_requeue02 futex_cmp_requeue02
+futex_cmp_requeue03 futex_cmp_requeue03
 futex_wait01 futex_wait01
 futex_wait02 futex_wait02
 futex_wait03 futex_wait03
testcases/kernel/syscalls/futex/.gitignore +1 -0
index c11546e07..231b6bd25 100644
@@ -16,3 +16,4 @@
 /futex_wait06
 /futex_wait07
 /futex_wake05
+/futex_cmp_requeue03
testcases/kernel/syscalls/futex/futex_cmp_requeue03.c new file +108 -0

108 lines not on this page · raw message

Signature · 5 lines
2.54.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v16 2/2
#7 lore raw

Re: [LTP] [PATCH v16 2/2] futex_cmp_requeue03: Add EFAULT error coverage test

In reply to Michael Menasherov via ltp

Hi Michael,

...

Quoted 21 lines
testcases/kernel/syscalls/futex/futex_cmp_requeue03.c new file +21 -0
+static struct testcase {
+	const char *desc;
+	futex_t **uaddr;
+	futex_t **uaddr2;
+	int exp_errno;
+} testcases[] = {
+	{
+		.desc = "uaddr unmapped",
+		.uaddr = &unmapped_addr,
+		.uaddr2 = &futex_ptr,
+		.exp_errno = EFAULT,
+	},
+	{
+		.desc = "uaddr2 unmapped",
+		.uaddr = &futex_ptr,
+		.uaddr2 = &unmapped_addr,
+		.exp_errno = EFAULT,
+	},
+	{
+		.desc = "uaddr PROT_NONE",
+		.uaddr = &prot_none_addr,

testcases/kernel/syscalls/futex/futex_cmp_requeue03.c line 69

Quoted 10 lines
testcases/kernel/syscalls/futex/futex_cmp_requeue03.c new file +10 -0
+		.uaddr2 = &futex_ptr,
+		.exp_errno = EFAULT,
+	},
+	{
+		.desc = "uaddr2 PROT_NONE",
+		.uaddr = &futex_ptr,
+		.uaddr2 = &prot_none_addr,
+		.exp_errno = EFAULT,
+	},
+};

nit: also here I'd use EFAULT directly in TST_EXP_FAIL(), but that's a minor detail.

The rest LGTM.

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp