profiling: prevent stale prof_cpu_mask access on init failure
PATCH 1/1 profiling: prevent stale prof_cpu_mask access on init failure
From: Tristan Madani <[email protected]>
When profiling is enabled at runtime via /sys/kernel/profiling, profile_setup() sets prof_on and profile_init() allocates prof_cpu_mask and attempts to allocate prof_buffer. If all prof_buffer allocations fail, the error path frees prof_cpu_mask but leaves prof_on set.
Since profile_tick() runs from timer interrupt context and checks cpumask_available(prof_cpu_mask) without first checking prof_on, it can dereference the freed cpumask between the free and the next reboot.
Clear prof_on before freeing prof_cpu_mask so the profiling state remains consistent on allocation failure. Also gate the cpumask access in profile_tick() on prof_on to prevent accessing stale state during the teardown window.
--- kernel/profile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/profile.c +2 -1
@@ -123,6 +123,7 @@ int __ref profile_init(void)if (prof_buffer)return 0 ; + prof_on =0 ;free_cpumask_var (prof_cpu_mask);return -ENOMEM ; }
@@ -325,7 +326,7 @@ void profile_tick(int type) {struct pt_regs *regs =get_irq_regs (); -if (!user_mode (regs) &&cpumask_available (prof_cpu_mask) && +if (!user_mode (regs) && prof_on &&cpumask_available (prof_cpu_mask) &&cpumask_test_cpu (smp_processor_id (), prof_cpu_mask))profile_hit (type, (void *)profile_pc (regs)); }
Signature · 1 line
2.47.3
kernel/profile.c int __ref profile_init(void) · line 127
Quoted 10 lines · Tristan Madani
kernel/profile.c +1
-0@@ -123,6 +123,7 @@ int __ref profile_init(void)if (prof_buffer)return 0 ; + prof_on =0 ;free_cpumask_var (prof_cpu_mask);
Which tree are you talking about?
kernel/profile.c void profile_tick(int type) · line 330
Quoted 9 lines
kernel/profile.c +1
-1return -ENOMEM ; }@@ -325,7 +326,7 @@ void profile_tick(int type) {struct pt_regs *regs =get_irq_regs (); -if (!user_mode (regs) &&cpumask_available (prof_cpu_mask) && +if (!user_mode (regs) && prof_on &&cpumask_available (prof_cpu_mask) &&cpumask_test_cpu (smp_processor_id (), prof_cpu_mask))
NAK. This is a use-after-free read bug.
CPU0 CPU1
if (!user_mode(regs) && prof_on && cpumask_available(prof_cpu_mask) &&
prof_on = 0;
free_cpumask_var(prof_cpu_mask);
cpumask_test_cpu(smp_processor_id(), prof_cpu_mask)) // <= prof_cpu_mask was already freed.
Correct fix is to remove a commit which adds "free_cpumask_var(prof_cpu_mask);".
Quoted 2 lines
kernel/profile.c +0
-0profile_hit (type, (void *)profile_pc (regs)); }
Quoted 3 lines · Tetsuo Handa
NAK. This is a use-after-free read bug.
Correct fix is to remove a commit which adds "
free_cpumask_var(prof_cpu_mask);".
You're right, the flag check races with the free. v2 will just remove the free_cpumask_var() call instead.
Quoted 1 line
Which tree are you talking about?
This is for stable (6.1.y, 6.6.y, 6.8.y) where prof_cpu_mask still exists.
Thanks,
Tristan
PATCH v2 1/1 profiling: don't free prof_cpu_mask on init failure
In reply to Tristan MadaniFrom: Tristan Madani <[email protected]>
When profiling is enabled at runtime via /sys/kernel/profiling, profile_setup() sets prof_on and profile_init() allocates prof_cpu_mask then attempts to allocate prof_buffer. If all prof_buffer allocations fail, the error path frees prof_cpu_mask but leaves prof_on set.
Since profile_tick() runs from timer interrupt context and checks cpumask_available(prof_cpu_mask), it can access the freed cpumask between the free and the next reboot.
Remove the free_cpumask_var() call from the error path. The cpumask allocation already succeeded and is small; keeping it on this rare failure path is harmless.
---
Changes in v2:
- Remove the free_cpumask_var() call instead of adding a prof_on guard in profile_tick(), which still raced with the free (Tetsuo Handa)
kernel/profile.c | 1 - 1 file changed, 1 deletion(-)
kernel/profile.c +0 -1
@@ -123,7 +123,6 @@ int __ref profile_init(void)if (prof_buffer)return 0 ; -free_cpumask_var (prof_cpu_mask);return -ENOMEM ; }
Signature · 1 line
2.47.3
Re: [PATCH v2] profiling: don't free prof_cpu_mask on init failure
Quoted 11 lines · Tristan Madani
From: Tristan Madani <[email protected]>
When profiling is enabled at runtime via
/sys/kernel/profiling,profile_setup()setsprof_onandprofile_init()allocatesprof_cpu_maskthen attempts to allocateprof_buffer. If allprof_bufferallocations fail, the error path freesprof_cpu_maskbut leavesprof_onset.Since
profile_tick()runs from timer interrupt context and checkscpumask_available(prof_cpu_mask), it can access the freed cpumask between the free and the next reboot.
Quoted 5 lines
Remove the
free_cpumask_var()call from the error path. The cpumask allocation already succeeded and is small; keeping it on this rare failure path is harmless.Fixes 22b8ce94708f ("profiling: dynamically enable readprofile at runtime")
Why 22b8ce94708f ? That commit did not add free_cpumask_var(). Since free_cpumask_var() was removed by 7c51f7bbf057, your patch might want explanation about why you choose to only avoid UAF-read for stable kernels instead of try to apply 7c51f7bbf057.
Quoted 22 lines
Suggested-by Tetsuo Handa <[email protected]>Signed-off-by Tristan Madani <[email protected]>---
Changes in v2:
- Remove thefree_cpumask_var()call instead of adding aprof_onguard inprofile_tick(), which still raced with the free (Tetsuo Handa)kernel/profile.c | 1 - 1 file changed, 1 deletion(-)kernel/profile.c +0
-1@@ -123,7 +123,6 @@ int __ref profile_init(void)if (prof_buffer)return 0 ; -free_cpumask_var (prof_cpu_mask);return -ENOMEM ; }
Re: [PATCH v2] profiling: don't free prof_cpu_mask on init failure
Quoted 4 lines · Tetsuo Handa
Why
22b8ce94708f? That commit did not addfree_cpumask_var(). Sincefree_cpumask_var()was removed by7c51f7bbf057, your patch might want explanation about why you choose to only avoid UAF-read for stable kernels instead of try to apply7c51f7bbf057.
Thanks for the review. You're right, the Fixes tag should be c309b917cab5 ("cpumask: convert kernel/profile.c").
I went with the minimal fix you suggested since 7c51f7bbf057 touches two files and adds serialization, which felt heavier for a stable backport.
Would a v3 with the corrected Fixes tag and a note explaining the choice over 7c51f7bbf057 work, or would you prefer to just Cc stable on your commit?
Tristan
Re: [PATCH v2] profiling: don't free prof_cpu_mask on init failure
Quoted 3 lines · Tristan Madani
I went with the minimal fix you suggested since
7c51f7bbf057touches two files and adds serialization, which felt heavier for a stable backport.
OK.
Quoted 4 lines
Would a v3 with the corrected Fixes tag and a note explaining the choice over
7c51f7bbf057work, or would you prefer to just Cc stable on your commit?
Just as you like. I am not the person who makes decisions on for-stable-only patches.
Re: [PATCH v2] profiling: don't free prof_cpu_mask on init failure
In reply to Tristan MadaniQuoted 20 lines · On Mon, 22 Jun 2026 00:00:22 +0000 Tristan Madani <[email protected]> wrote:
From: Tristan Madani <[email protected]>
When profiling is enabled at runtime via
/sys/kernel/profiling,profile_setup()setsprof_onandprofile_init()allocatesprof_cpu_maskthen attempts to allocateprof_buffer. If allprof_bufferallocations fail, the error path freesprof_cpu_maskbut leavesprof_onset.Since
profile_tick()runs from timer interrupt context and checkscpumask_available(prof_cpu_mask), it can access the freed cpumask between the free and the next reboot.Remove the
free_cpumask_var()call from the error path. The cpumask allocation already succeeded and is small; keeping it on this rare failure path is harmless....
kernel/profile.c int __ref profile_init(void) · line 127
Quoted 6 lines
kernel/profile.c +0
-1@@ -123,7 +123,6 @@ int __ref profile_init(void)if (prof_buffer)return 0 ; -free_cpumask_var (prof_cpu_mask);return -ENOMEM ; }
Confused. Current mainline has no free_cpumask_var() here?
If we're to deliberately leak the mask here then let's have a little comment explaining the reasoning, so we don't later receive "profiling:
fix memory leak" patches.
Re: [PATCH v2] profiling: don't free prof_cpu_mask on init failure
Quoted 1 line · On Wed, 24 Jun 2026 18:11:13 -0700 Andrew Morton wrote:
Confused. Current mainline has no
free_cpumask_var()here?
Correct -- Tetsuo's 7c51f7bbf057 ("profiling: remove prof_cpu_mask") removed the variable and all its references in v6.11. This patch is for 6.1.y and 6.6.y where the old error-path free is still present.
Quoted 3 lines
If we're to deliberately leak the mask here then let's have a little comment explaining the reasoning, so we don't later receive "profiling:
fix memory leak" patches.
Good point. I can send v3 with:
- a comment above the return explaining the deliberate leak
- corrected Fixes tag (c309b917cab5, per Tetsuo's review)
- stable-only framing in the commit message
Alternatively, Cc stable on 7c51f7bbf057 would also fix this, though that commit removes prof_cpu_mask entirely, adds mutex serialization in ksysfs.c, and drops the hotplug online callback (2 files, +13/-40).
Happy to go either way.
Tristan