mm/damon: optimize out nr_accesses_bp
Subsystems (4)
SeongJae Park
maintainercover mm/damon: optimize out nr_accesses_bp
TLDR: Replace damon_region->nr_accesses_bp, which is easy to be wrong, with a simpler on-demand moving sum function, damon_nr_accesses_mvsum().
Background
==========
DAMON's monitoring output (access pattern snapshot, or more technically speaking, damon_region->nr_accesses) is completed once per aggregation interval, which is 100 ms by default. Users can arbitrarily increase the interval for demand. Under the suggested intervals auto-tuning setup, it can span up to 200 seconds. If the aggregation interval is too long, the snapshot users cannot use it in reasonable time. To mitigate this, we introduced a new field of damon_region, namely nr_accesses_bp. It contains a pseudo moving sum of nr_accesses in bp units and is updated for each sampling interval.
It turned out keeping it correctly updated every sampling interval is not that easy. From online parameter update feature development and more experimental hacks, we found it is easy to be corrupted. Once it is corrupted, DAMON's monitoring outputs become quite insane. Hence we added a few validation checks. It is easy to be corrupted because it requires every update per sampling interval to be correct.
Solution
========
There is no real reason to keep it updated every sampling interval. Due to the simple pseudo-moving sum mechanism and existing helper field (last_nr_accesses), we can also calculate the pseudo moving sum on demand in a much simpler way.
Implement a function for getting the pseudo moving sum on demand, and replace nr_accessses_bp uses with the new function. Also remove no more needed tests for nr_accesses_bp and the per-sampling interval update functions. Finally, remove the nr_accesses_bp. The new function is quite simple.
Discussion
==========
Depending on the use case, multiple nr_accesses readers could be executed in the same kdamond_fn() main loop iteration, which is executed once per sampling interval. Such readers include DAMON region exporting tracepoints (damon_[region_]aggregated and damos_before_apply), DAMOS, and DAMON sysfs interface logic for update_schemes_tried_regions command. In this case, the new function will be called multiple times and this could be overhead compared to the old logic, which simply reads the field without any additional work. Nonetheless, the new function is quite simple. And the new approach does nothing while there is no need to read. The old approach had to execute its update function for each region for every sampling interval. Hence the new approach is believed to be even more lightweight in common case, and the overhead is anyway negligible.
One more advantage of this change is that one field from the damon_region struct is removed. On setups that uses a high number of DAMON regions, this could be a potential memory space benefit.
Patches Sequence
================
Patch 1 introduces the new function for getting the pseudo moving sum of nr_accesses on demands. Patch 2 implements a unit test for the new function's internal logic. Patch 3 and 4 update monitoring logic and the new function to ready for safe use on the existing logic. Patches 5-7 replace uses of nr_accesses_bp in DAMOS, tracepoints and DAMON sysfs interface with the new function, respectively. Patches 8-10 removes nr_accesses_bp validation functions in DAMON core, one by one. Patches 11 and 12 further remove tests and test helper for nr_accesses_bp, respectively. Patches 13 removes the setups and updates or nr_accesses_bp field. Patches 14-16 cleans up function parameters that are no more being used due to the previous patch. Patch 17 removes the function that was used for updating nr_accesses_bp field with its unit test, which is the single remaining caller of the function. Finally, patch 18 removes damon_region->nr_accesses_bp field.
Changes from RFC v1.2
- RFC v1.2: https://lore.kernel.org/[email protected]
- Explicitly ignore nr_accesses from mvsum at the beginning of aggregation.
- Fix a typo in a commit message.
Changes from RFC v1.1
- RFC v1.1: https://lore.kernel.org/[email protected]
- Handle next_aggregation_sis < passed_sample_intervals in nr_accesses_mvsum().
- Always rescale ->last_nr_accesss for parameter changes.
- Remove unused attrs params from damon_update_region_access_rate() and its callers.
Changes from RFC v1
- RFC v1: https://lore.kernel.org/[email protected]
- Avoid divide-by-zero from zero aggregation interval.
- Call damon_nr_accesses_mvsum() for damos tracing only when it is enabled.
- Remove obsolete mentions of nr_accesses_bp in comments.
SeongJae Park (18):
mm/damon: introduce damon_nr_accesses_mvsum() mm/damon/tests/core-kunit: test damon_mvsum() mm/damon/core: always update ->last_nr_accesses for intervals change mm/damon/core: handle unreset nr_accesses in damon_nr_accesses_mvsum() mm/damon/core: use damon_nr_accesses_mvsum() in __damos_valid_target() mm/damon/core: use damon_nr_accesses_mvsum() for damos region tracing mm/damon/sysfs-schemes: use damon_nr_accesses_mvsum() for damo regions mm/damon/core: remove damon_warn_fix_nr_accesses_corruption() mm/damon/core: remove damon_verify_reset_aggregated() mm/damon/core: remove damon_verify_merge_regions_of() mm/damon/tests/core-kunit: remove nr_accesses_bp setup and tests selftests/damon/drgn_dump_damon_status: do not dump nr_accesses_bp mm/damon/core: remove nr_accesses_bp setups and updates mm/damon/core: remove attrs param from
damon_update_region_access_rate()
mm/damonn/paddr: remove attrs param from __damon_pa_check_access() mm/damon/vaddr: remove attrs param from __damon_va_check_access() mm/damon/core: remove damon_moving_sum() and its unit test mm/damon: remove damon_region->nr_accesses_bp
include/linux/damon.h | 15 +- include/trace/events/damon.h | 8 +- mm/damon/core.c | 201 +++++++----------- mm/damon/paddr.c | 9 +- mm/damon/sysfs-schemes.c | 6 +- mm/damon/tests/core-kunit.h | 37 ++-- mm/damon/vaddr.c | 12 +- .../selftests/damon/drgn_dump_damon_status.py | 1 - 8 files changed, 119 insertions(+), 170 deletions(-)
base-commit: e08d3bec1dc38cc991fc819afd698bf7bd07bd6d
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 1/18 mm/damon: introduce damon_nr_accesses_mvsum()
Introduce a new DAMON core function, damon_nr_accesses_mvsum(). It returns a pseudo moving sum value of a given region's nr_accesses for the last aggregation interval. The internal logic is the same to nr_accesses_bp. The difference is that nr_accesses_bp is updated for each sampling interval, while the new function needs to be executed only when requested. Hence the function's return value is the same as the value of nr_accesses_bp.
--- include/linux/damon.h | 2 ++ mm/damon/core.c | 62 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+)
include/linux/damon.h +2 -0
@@ -1013,6 +1013,8 @@ struct damon_probe *damon_new_probe(void);void damon_add_probe (struct damon_ctx *ctx,struct damon_probe *probe);struct damon_region *damon_new_region (unsigned long start,unsigned long end); +unsigned int damon_nr_accesses_mvsum (struct damon_region *r, +struct damon_ctx *ctx);int damon_set_regions (struct damon_target *t,struct damon_addr_range *ranges,unsigned int nr_ranges,unsigned long min_region_sz);
mm/damon/core.c +62 -0
68 lines not on this page · raw message
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [RFC PATCH v1.3 01/18] mm/damon: introduce damon_nr_accesses_mvsum()
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Potential 32-bit integer overflow in `damon_nr_accesses_mvsum()` when calculating…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Potential 32-bit integer overflow in damon_nr_accesses_mvsum() when calculating left_window_bp using mult_frac() for large interval ratios. --
commit e0ac3f6397c85ca0b28c3db5a3bfa0bbe79402ee
Author: SeongJae Park <[email protected]>
mm/damon: introduce damon_nr_accesses_mvsum()
This commit introduces a new DAMON core function, damon_nr_accesses_mvsum(), which returns a pseudo moving sum value of a given region's nr_accesses for the last aggregation interval.
Quoted 3 lines
mm/damon/core.c +0
-0
[ ... ]
Quoted 1 line
mm/damon/core.c +0
-0@@ -210,6 +210,68 @@ static struct damon_probe *damon_nth_probe(int n, struct damon_ctx *ctx)
[ ... ]
Quoted 6 lines
mm/damon/core.c +6
-0+unsigned int damon_nr_accesses_mvsum (struct damon_region *r, +struct damon_ctx *ctx) +{ +unsigned long sample_interval, aggr_interval; +unsigned long window_len, left_window, left_window_bp; +
mm/damon/core.c static struct damon_probe *damon_nth_probe(int n, struct damon_ctx *ctx) · line 269
Quoted 10 lines
mm/damon/core.c +10
-0+ sample_interval = ctx->attrs.sample_interval ? :1 ; + aggr_interval = ctx->attrs.aggr_interval ? :1 ; + window_len = aggr_interval / sample_interval; +if (time_after_eq (ctx->passed_sample_intervals, + ctx->next_aggregation_sis)) + left_window =0 ; +else + left_window = ctx->next_aggregation_sis - + ctx->passed_sample_intervals; + left_window_bp =mult_frac (left_window,10000 , window_len);
[Severity: Medium]
Can this cause a 32-bit integer overflow on 32-bit architectures?
The mult_frac(x, n, d) macro internally computes the remainder multiplied by n using the native type of x. Since left_window is an unsigned long, it will be 32 bits on 32-bit architectures.
If window_len (and thus left_window) exceeds 429,496, the multiplication left_window * 10000 will overflow the 32-bit integer maximum (~4.29 billion) before division.
This easily occurs if a user configures a long aggregation interval via sysfs. For example, a 1 hour aggregation interval (3,600,000,000 us) with a 5,000 us sampling interval gives a window_len of 720,000.
This overflow would result in an incorrect left_window_bp and consequently an inaccurate pseudo moving sum access score, which could improperly drive DAMOS policies.
Quoted 4 lines
mm/damon/core.c +4
-0+ +return damon_mvsum (r->nr_accesses, r->last_nr_accesses, + left_window_bp); +}
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
SeongJae Park
maintainerRe: [RFC PATCH v1.3 01/18] mm/damon: introduce damon_nr_accesses_mvsum()
Quoted 2 lines · On Mon, 22 Jun 2026 14:36:08 +0000 [email protected] wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Potential 32-bit integer overflow indamon_nr_accesses_mvsum()when calculatingleft_window_bpusingmult_frac()for large interval ratios.
Known low priority issue. Not a blocker.
Thanks,
SJ
[...]
SeongJae Park
maintainerRFC PATCH 2/18 mm/damon/tests/core-kunit: test damon_mvsum()
In reply to SeongJae ParkAdd a simple unit test for damon_nr_accesses_mvsum()'s internal core logic, damon_mvsum(). The test contains cases for just-started windows, partially completed windows, and just-completed windows.
--- mm/damon/tests/core-kunit.h | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)
mm/damon/tests/core-kunit.h +25 -0
@@ -623,6 +623,30 @@ static void damon_test_moving_sum(struct kunit *test) } } +static void damon_test_mvsum (struct kunit *test) +{ +unsigned long input_expects[] = { +/* current value, last value, remaining window (bp) */ +0 ,49 ,10000 ,49 ,/* 0 + 49 * 1 */ +3 ,10 ,7000 ,10 ,/* 3 + 10 * 0.7 */ +3 ,10 ,5000 ,8 ,/* 3 + 10 * 0.5 */ +32 ,100 ,1000 ,42 ,/* 32 + 100 * 0.1 */ +42 ,49 ,0 ,42 ,/* 42 + 49 * 0 */ + }; + +int i; + +for (i =0 ; i <ARRAY_SIZE (input_expects); i +=4 ) { +unsigned long current_nr = input_expects[i]; +unsigned long last_nr = input_expects[i +1 ]; +unsigned long left_window_bp = input_expects[i +2 ]; +unsigned long expect = input_expects[i +3 ]; + +KUNIT_EXPECT_EQ (test,damon_mvsum (current_nr, last_nr, + left_window_bp), expect); + } +} +static void damos_test_new_filter (struct kunit *test) {struct damos_filter *filter;
@@ -1501,6 +1525,7 @@ static struct kunit_case damon_test_cases[] = {KUNIT_CASE (damon_test_update_monitoring_result),KUNIT_CASE (damon_test_set_attrs),KUNIT_CASE (damon_test_moving_sum), +KUNIT_CASE (damon_test_mvsum),KUNIT_CASE (damos_test_new_filter),KUNIT_CASE (damos_test_commit_quota_goal), KUNIT_CASE(damos_test_commit_quota_goals),
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 3/18 mm/damon/core: always update ->last_nr_accesses for intervals change
In reply to SeongJae ParkEach iteration of kdamond_fn() main loop caches and use the next aggregation time (next_aggregation_sis) because it can be updated in the middle, inside kdamond_call(). If that happens, damon_update_monitoring_result() is called for scaling the access frequency information of each region according to the changed intervals. The function does not update damon_region->last_nr_accesses when it is at the end of the aggregation, because it will anyway be reset after the function is executed, in kdamond_reset_aggregated().
Let's suppose damon_nr_accesses_mvsum() is called with the not yet updated last_nr_accesses. It will use the fresh next_aggregation_sis in the context instead of the cached one, unlike kdamond_fn(). As a result, use of not updated last_nr_acceses with the updated next_aggregation_sis result in returning wrong value.
There is no such damon_nr_accesses_nvsum() call at the moment, so this is no problem. It is planned to add such calls, though. Prevent the issue by updating last_nr_accesses always. This adds overhead, but that's fine because the overhead is not big, and it is anyway not a fast path.
--- mm/damon/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/damon/core.c +2 -2
@@ -873,6 +873,8 @@ static void damon_update_monitoring_result(struct damon_region *r, struct damon_attrs *old_attrs, struct damon_attrs *new_attrs, bool aggregating) { + r->last_nr_accesses = damon_nr_accesses_for_new_attrs( + r->last_nr_accesses, old_attrs, new_attrs);if (!aggregating) { r->nr_accesses =damon_nr_accesses_for_new_attrs ( r->nr_accesses, old_attrs, new_attrs);
@@ -884,8 +886,6 @@ static void damon_update_monitoring_result(struct damon_region *r,* interval. In other words, make the status like * kdamond_reset_aggregated() is called. */ - r->last_nr_accesses =damon_nr_accesses_for_new_attrs ( - r->last_nr_accesses, old_attrs, new_attrs); r->nr_accesses_bp = r->last_nr_accesses *10000 ; r->nr_accesses =0 ; }
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [RFC PATCH v1.3 03/18] mm/damon/core: always update ->last_nr_accesses for intervals change
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] 32-bit integer overflow in damon_accesses_bp_to_nr_accesses() and damon_nr_accesses_to_accesses_bp() when interval ratios are large. --
commit d0875d13ff723f48c4ed975ef9fd7e92fde65c11
Author: SeongJae Park <[email protected]>
mm/damon/core: always update ->last_nr_accesses for intervals change
This commit ensures the last_nr_accesses value in a damon_region is always updated when intervals change to prevent stale values from causing incorrect calculations. It updates damon_update_monitoring_result() to unconditionally scale last_nr_accesses using damon_nr_accesses_for_new_attrs().
mm/damon/core.c static void damon_update_monitoring_result(struct damon_region *r, · line 877
Quoted 10 lines
mm/damon/core.c +2
-0@@ -873,6 +873,8 @@ static void damon_update_monitoring_result(struct damon_region *r, struct damon_attrs *old_attrs, struct damon_attrs *new_attrs, bool aggregating) { + r->last_nr_accesses = damon_nr_accesses_for_new_attrs( + r->last_nr_accesses, old_attrs, new_attrs);
[Severity: High]
This is a pre-existing issue, but does this calculation in the underlying functions risk a 32-bit integer overflow?
The new call to damon_nr_accesses_for_new_attrs() relies on damon_accesses_bp_to_nr_accesses() and damon_nr_accesses_to_accesses_bp().
Looking at damon_accesses_bp_to_nr_accesses():
mm/damon/core.c:damon_accesses_bp_to_nr_accesses() {
...
return accesses_bp * damon_max_nr_accesses(attrs) / 10000;
}If a user configures a small sample_interval (e.g., 5ms) and a large aggr_interval (e.g., 3600s), the ratio calculated by damon_max_nr_accesses() is 720,000. For an accesses_bp of 10000 (100%), the multiplication yields 7,200,000,000, which exceeds the 32-bit unsigned int maximum and silently truncates.
Similarly, in damon_nr_accesses_to_accesses_bp():
mm/damon/core.c:damon_nr_accesses_to_accesses_bp() {
...
return mult_frac(nr_accesses, 10000, damon_max_nr_accesses(attrs));
}The mult_frac macro uses the type of nr_accesses (unsigned int) for its internal calculations. Can this cause a similar 32-bit overflow when multiplying the remainder by 10000 if the remainder exceeds 429,496?
Quoted 3 lines
mm/damon/core.c +0
-0if (!aggregating) { r->nr_accesses =damon_nr_accesses_for_new_attrs ( r->nr_accesses, old_attrs, new_attrs);
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
SeongJae Park
maintainerRe: [RFC PATCH v1.3 03/18] mm/damon/core: always update ->last_nr_accesses for intervals change
Quoted 4 lines · On Mon, 22 Jun 2026 14:37:13 +0000 [email protected] wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] 32-bit integer overflow indamon_accesses_bp_to_nr_accesses()anddamon_nr_accesses_to_accesses_bp()when interval ratios are large.
Known low priority issue. Not a blocker of this patch.
Thanks,
SJ
[...]
SeongJae Park
maintainerRFC PATCH 4/18 mm/damon/core: handle unreset nr_accesses in damon_nr_accesses_mvsum()
In reply to SeongJae Parkdamon_set_attrs() works like reverting aggregations that were made so far for this aggregation window. If this is the end of the aggregation, however, kdamond_fn() will do the operations at the end of the aggregation interval, using cached timestamps. For such operations that rely on damon_region->nr_accesses, damon_update_monitoring_results() doesn't reset the nr_accesses if it is called at the end of the aggregation window.
damon_nr_accesses_mvsum() works with fresh timestamps, though. The nr_accesses that are not reset in this case can make the logic to unnecessarily count nr_accesses, resulting in returning higher-than-expected pseudo moving sum nr_accesses. No code is using damon_nr_accesses_mvsum() yet, so this is not causing a real problem. Following commits will add usage of the function, though. For safe usages, calculate the pseudo moving sum without nr_accesses if the remaining window is full.
--- mm/damon/core.c | 3 +++ 1 file changed, 3 insertions(+)
mm/damon/core.c +3 -0
@@ -268,6 +268,9 @@ unsigned int damon_nr_accesses_mvsum(struct damon_region *r, ctx->passed_sample_intervals; left_window_bp =mult_frac (left_window,10000 , window_len); +if (left_window_bp ==10000 ) +return r->last_nr_accesses; +return damon_mvsum (r->nr_accesses, r->last_nr_accesses, left_window_bp); }
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [RFC PATCH v1.3 04/18] mm/damon/core: handle unreset nr_accesses in damon_nr_accesses_mvsum()
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] damon_nr_accesses_mvsum() incorrectly returns stale access data from two aggregation intervals…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] damon_nr_accesses_mvsum() incorrectly returns stale access data from two aggregation intervals ago during the aggregation reset gap. --
commit 079525184ff6b3e5e3e7c3387647af444428cb84
Author: SeongJae Park <[email protected]>
mm/damon/core: handle unreset nr_accesses in damon_nr_accesses_mvsum()
This commit addresses an issue in damon_nr_accesses_mvsum() where unreset nr_accesses can unnecessarily inflate the pseudo moving sum. It adds a check to return last_nr_accesses directly if the remaining window is full.
mm/damon/core.c unsigned int damon_nr_accesses_mvsum(struct damon_region *r, · line 273
Quoted 11 lines
mm/damon/core.c +3
-0@@ -268,6 +268,9 @@ unsigned int damon_nr_accesses_mvsum(struct damon_region *r, ctx->passed_sample_intervals; left_window_bp =mult_frac (left_window,10000 , window_len); +if (left_window_bp ==10000 ) +return r->last_nr_accesses; +
[Severity: Medium]
Will this regression return stale access data from two aggregation intervals ago?
If damon_set_attrs() is executed at the end of an aggregation window, it advances ctx->next_aggregation_sis but intentionally does not reset r->nr_accesses.
During this unreset gap, r->nr_accesses correctly retains the fully-aggregated data of the just-finished window, while r->last_nr_accesses holds the value from two windows ago.
Because next_aggregation_sis was advanced, left_window_bp evaluates to 10000 in damon_nr_accesses_mvsum(). Does the new check fall back to the stale last_nr_accesses, skipping the most recent interval's data?
Quoted 3 lines
mm/damon/core.c +0
-0return damon_mvsum (r->nr_accesses, r->last_nr_accesses, left_window_bp); }
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
SeongJae Park
maintainerRe: [RFC PATCH v1.3 04/18] mm/damon/core: handle unreset nr_accesses in damon_nr_accesses_mvsum()
Quoted 33 lines · On Mon, 22 Jun 2026 14:42:11 +0000 [email protected] wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium]damon_nr_accesses_mvsum()incorrectly returns stale access data from two aggregation intervals ago during the aggregation reset gap. --commit
079525184ff6b3e5e3e7c3387647af444428cb84
Author: SeongJae Park <[email protected]>
mm/damon/core: handle unresetnr_accessesindamon_nr_accesses_mvsum()This commit addresses an issue in
damon_nr_accesses_mvsum()where unresetnr_accessescan unnecessarily inflate the pseudo moving sum. It adds a check to returnlast_nr_accessesdirectly if the remaining window is full.mm/damon/core.c unsigned int damon_nr_accesses_mvsum(struct damon_region *r, · line 273
Quoted 11 lines
mm/damon/core.c +3
-0@@ -268,6 +268,9 @@ unsigned int damon_nr_accesses_mvsum(struct damon_region *r, ctx->passed_sample_intervals; left_window_bp =mult_frac (left_window,10000 , window_len); +if (left_window_bp =10000 ) +return r->last_nr_accesses; +[Severity: Medium]
Will this regression return stale access data from two aggregation intervals ago?If
damon_set_attrs()is executed at the end of an aggregation window, it advancesctx->next_aggregation_sisbut intentionally does not resetr->nr_accesses.
Quoted 7 lines
During this unreset gap,
r->nr_accessescorrectly retains the fully-aggregated data of the just-finished window, whiler->last_nr_accessesholds the value from two windows ago.Because
next_aggregation_siswas advanced,left_window_bpevaluates to 10000 indamon_nr_accesses_mvsum(). Does the new check fall back to the stalelast_nr_accesses, skipping the most recent interval's data?
Too minor issue. I will keep this as is, and work on further improvement as I also mentioned on the commit message. No blocker for this patch.
Thanks,
SJ
[...]
SeongJae Park
maintainerRFC PATCH 5/18 mm/damon/core: use damon_nr_accesses_mvsum() in __damos_valid_target()
In reply to SeongJae Parkdamon_nr_accesses_mvsum() returns a value same to nr_accesses_bp. Also the function is more simple and therefore more tolerant to errors. Execution of the function would be more expensive than the simple read of the field, but because the function is quite simple, the overhead should be negligible. Use it in __damos_valid_target() instead of the nr_accesses_bp.
--- mm/damon/core.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
mm/damon/core.c +6 -5
@@ -2128,10 +2128,11 @@ static noinline_for_stack void kdamond_tune_intervals(struct damon_ctx *c)damon_set_attrs (c, &new_attrs); } -static bool __damos_valid_target (struct damon_region *r,struct damos *s) +static bool __damos_valid_target (struct damon_region *r,struct damos *s, +struct damon_ctx *c) {unsigned long sz; -unsigned int nr_accesses = r->nr_accesses_bp /10000 ; +unsigned int nr_accesses =damon_nr_accesses_mvsum (r, c); sz =damon_sz_region (r); return s->pattern.min_sz_region <= sz &&
@@ -2157,7 +2158,7 @@ static bool damos_quota_is_set(struct damos_quota *quota)static bool damos_valid_target (struct damon_ctx *c,struct damon_region *r,struct damos *s) { -bool ret =__damos_valid_target (r, s); +bool ret =__damos_valid_target (r, s, c);if (!ret || !damos_quota_is_set (&s->quota) || !c->ops.get_scheme_score)return ret;
@@ -2743,7 +2744,7 @@ static phys_addr_t damos_calc_eligible_bytes(struct damon_ctx *c,damon_for_each_region (r, t) {phys_addr_t addr, end_addr; -if (!__damos_valid_target (r, s)) +if (!__damos_valid_target (r, s, c))continue ;/* Convert from core address units to physical bytes */
@@ -3032,7 +3033,7 @@ static void damos_adjust_quota(struct damon_ctx *c, struct damos *s) (DAMOS_MAX_SCORE + 1));damon_for_each_target (t, c) {damon_for_each_region (r, t) { -if (!__damos_valid_target (r, s)) +if (!__damos_valid_target (r, s, c))continue ;if (damos_core_filter_out (c, t, r, s))continue ;
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [RFC PATCH v1.3 05/18] mm/damon/core: use damon_nr_accesses_mvsum() in __damos_valid_target()
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] 32-bit integer overflow in damon_nr_accesses_mvsum() leads to incorrect region access frequency…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] 32-bit integer overflow in damon_nr_accesses_mvsum() leads to incorrect region access frequency scores. --
commit 31c0062dc1352032d1779ac0035b6e2cd5a7461a
Author: SeongJae Park <[email protected]>
mm/damon/core: use damon_nr_accesses_mvsum() in __damos_valid_target()
This commit changes __damos_valid_target() to use damon_nr_accesses_mvsum() instead of reading the nr_accesses_bp field directly. This provides a more error-tolerant moving sum access score for DAMOS scheme logic.
Quoted 5 lines
mm/damon/core.c +0
-0
mm/damon/core.c static void kdamond_tune_intervals(struct damon_ctx *c) · line 2135
Quoted 10 lines
mm/damon/core.c +3
-2@@ -2128,10 +2128,11 @@ static void kdamond_tune_intervals(struct damon_ctx *c)damon_set_attrs (c, &new_attrs); } -static bool __damos_valid_target (struct damon_region *r,struct damos *s) +static bool __damos_valid_target (struct damon_region *r,struct damos *s, +struct damon_ctx *c) {unsigned long sz; -unsigned int nr_accesses = r->nr_accesses_bp /10000 ; +unsigned int nr_accesses =damon_nr_accesses_mvsum (r, c);
[Severity: High]
Does this introduction of damon_nr_accesses_mvsum() expose an integer overflow on 32-bit systems?
When calculating the access frequency score, damon_nr_accesses_mvsum() calls mult_frac() which performs an intermediate multiplication:
mm/damon/core.c:damon_nr_accesses_mvsum() {
...
left_window_bp = mult_frac(left_window, 10000, window_len);
...
}If a large tracking window is configured, for instance with an aggr_interval of 1,000,000 us and a sample_interval of 1 us, window_len becomes 1,000,000 and left_window can reach up to 999,999.
The intermediate multiplication for mult_frac() uses the type of left_window, which is unsigned long. On 32-bit architectures, this intermediate value (e.g., 999,999 * 10000 = 9,999,990,000) exceeds the 32-bit maximum of ULONG_MAX (4,294,967,295), causing a silent wrap-around.
This results in a completely incorrect left_window_bp value and drastically undervalues the access frequency of memory regions.
Since __damos_valid_target() directly ingests this faulty access score, could this regression lead DAMOS schemes to inappropriately skip highly active memory regions and break memory reclamation or migration mechanisms on 32-bit systems?
Quoted 3 lines
mm/damon/core.c +0
-0sz =damon_sz_region (r); return s->pattern.min_sz_region <= sz &&
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5
SeongJae Park
maintainerRe: [RFC PATCH v1.3 05/18] mm/damon/core: use damon_nr_accesses_mvsum() in __damos_valid_target()
Quoted 21 lines · On Mon, 22 Jun 2026 14:37:24 +0000 [email protected] wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] 32-bit integer overflow indamon_nr_accesses_mvsum()leads to incorrect region access frequency scores. --commit
31c0062dc1352032d1779ac0035b6e2cd5a7461a
Author: SeongJae Park <[email protected]>
mm/damon/core: usedamon_nr_accesses_mvsum()in__damos_valid_target()This commit changes
__damos_valid_target()to usedamon_nr_accesses_mvsum()instead of reading thenr_accesses_bpfield directly. This provides a more error-tolerant moving sum access score for DAMOS scheme logic.Quoted 8 lines
mm/damon/core.c +0
-0@@ -2128,10 +2128,11 @@ static void kdamond_tune_intervals(struct damon_ctx *c)damon_set_attrs (c, &new_attrs); }
Quoted 11 lines
mm/damon/core.c static noinline_for_stack void kdamond_tune_intervals(struct damon_ctx *c) · line 2135
Quoted 7 lines
mm/damon/core.c +3
-2-static bool __damos_valid_target (struct damon_region *r,struct damos *s) +static bool __damos_valid_target (struct damon_region *r,struct damos *s, +struct damon_ctx *c) {unsigned long sz; -unsigned int nr_accesses = r->nr_accesses_bp /10000 ; +unsigned int nr_accesses =damon_nr_accesses_mvsum (r, c);[Severity: High]
Does this introduction ofdamon_nr_accesses_mvsum()expose an integer overflow on 32-bit systems?
Known low priority issue. Not a blocker for this patch.
Thanks,
SJ
[...]
SeongJae Park
maintainerRFC PATCH 6/18 mm/damon/core: use damon_nr_accesses_mvsum() for damos region tracing
In reply to SeongJae Parkdamon_nr_accesses_mvsum() returns a value same to nr_accesses_bp. Also the function is more simple and therefore more tolerant to errors. Execution of the function would be more expensive than the simple read of the field, but because the function is quite simple, the overhead should be negligible. Use it in the DAMON region exporting trace points instead of the nr_accesses_bp.
--- include/trace/events/damon.h | 8 +++++--- mm/damon/core.c | 5 +++-- 2 files changed, 8 insertions(+), 5 deletions(-)
include/trace/events/damon.h +5 -3
@@ -78,9 +78,11 @@ TRACE_EVENT_CONDITION(damos_before_apply, TP_PROTO(unsigned int context_idx, unsigned int scheme_idx, unsigned int target_idx, struct damon_region *r, - unsigned int nr_regions, bool do_trace), + unsigned int nr_accesses, unsigned int nr_regions, + bool do_trace), -TP_ARGS (context_idx, scheme_idx, target_idx, r, nr_regions, do_trace), +TP_ARGS (context_idx, scheme_idx, target_idx, r, nr_accesses, + nr_regions, do_trace), TP_CONDITION(do_trace),
@@ -101,7 +103,7 @@ TRACE_EVENT_CONDITION(damos_before_apply, __entry->target_idx = target_idx; __entry->start = r->ar.start; __entry->end = r->ar.end; - __entry->nr_accesses = r->nr_accesses_bp /10000 ; + __entry->nr_accesses = nr_accesses; __entry->age = r->age; __entry->nr_regions = nr_regions; ),
mm/damon/core.c +3 -2
@@ -2442,7 +2442,7 @@ static void damos_apply_scheme(struct damon_ctx *c, struct damon_target *t,struct damos *siter;/* schemes iterator */ unsigned int sidx =0 ;struct damon_target *titer;/* targets iterator */ -unsigned int tidx =0 ; +unsigned int tidx =0 , nr_accesses =0 ;bool do_trace = false;/* get indices for trace_damos_before_apply() */
@@ -2457,6 +2457,7 @@ static void damos_apply_scheme(struct damon_ctx *c, struct damon_target *t,break ; tidx++; } + nr_accesses =damon_nr_accesses_mvsum (r, c); do_trace = true; }
@@ -2472,7 +2473,7 @@ static void damos_apply_scheme(struct damon_ctx *c, struct damon_target *t,if (damos_core_filter_out (c, t, r, s))return ;ktime_get_coarse_ts64 (&begin); -trace_damos_before_apply (cidx, sidx, tidx, r, +trace_damos_before_apply (cidx, sidx, tidx, r, nr_accesses,damon_nr_regions (t), do_trace); sz_applied = c->ops.apply_scheme (c, t, r, s, &sz_ops_filter_passed);
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 7/18 mm/damon/sysfs-schemes: use damon_nr_accesses_mvsum() for damo regions
In reply to SeongJae Parkdamon_nr_accesses_mvsum() returns a value same to nr_accesses_bp. Also the function is more simple and therefore more tolerant to errors. Execution of the function would be more expensive than the simple read of the field, but because the function is quite simple, the overhead should be negligible. Use it in the DAMON sysfs interface for scheme-tried regions, instead of the nr_accesses_bp.
--- mm/damon/sysfs-schemes.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
mm/damon/sysfs-schemes.c +3 -3
@@ -159,7 +159,7 @@ struct damon_sysfs_scheme_region { };static struct damon_sysfs_scheme_region *damon_sysfs_scheme_region_alloc ( -struct damon_region *region) +struct damon_region *region,struct damon_ctx *ctx) {struct damon_sysfs_scheme_region *sysfs_region =kmalloc_obj (*sysfs_region);
@@ -167,7 +167,7 @@ static struct damon_sysfs_scheme_region *damon_sysfs_scheme_region_alloc(return NULL ; sysfs_region->kobj = (struct kobject ){}; sysfs_region->ar = region->ar; - sysfs_region->nr_accesses = region->nr_accesses_bp /10000 ; + sysfs_region->nr_accesses =damon_nr_accesses_mvsum (region, ctx); sysfs_region->age = region->age; sysfs_region->probes =NULL ;INIT_LIST_HEAD (&sysfs_region->list);
@@ -3124,7 +3124,7 @@ void damos_sysfs_populate_region_dir(struct damon_sysfs_schemes *sysfs_schemes,if (total_bytes_only)return ; - region =damon_sysfs_scheme_region_alloc (r); + region =damon_sysfs_scheme_region_alloc (r, ctx);if (!region)return ; region->sz_filter_passed = sz_filter_passed;
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [RFC PATCH v1.3 07/18] mm/damon/sysfs-schemes: use damon_nr_accesses_mvsum() for damo regions
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] Integer overflow in `mult_frac` on 32-bit architectures when calculating `left_window_bp` in…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Integer overflow in mult_frac on 32-bit architectures when calculating left_window_bp in damon_nr_accesses_mvsum(). --
commit 3dcb4c6bbc65644874c65412bf73b8673d929524
Author: SeongJae Park <[email protected]>
mm/damon/sysfs-schemes: use damon_nr_accesses_mvsum() for damo regions
This commit switches the DAMON sysfs interface to use damon_nr_accesses_mvsum() instead of nr_accesses_bp for scheme-tried regions. The new function is chosen to be simpler and more tolerant to errors.
mm/damon/sysfs-schemes.c static struct damon_sysfs_scheme_region *damon_sysfs_scheme_region_alloc( · line 170
Quoted 10 lines
mm/damon/sysfs-schemes.c +1
-1@@ -167,7 +167,7 @@ static struct damon_sysfs_scheme_region *damon_sysfs_scheme_region_alloc(return NULL ; sysfs_region->kobj = (struct kobject ){}; sysfs_region->ar = region->ar; - sysfs_region->nr_accesses = region->nr_accesses_bp /10000 ; + sysfs_region->nr_accesses =damon_nr_accesses_mvsum (region, ctx);
[Severity: High]
By switching to damon_nr_accesses_mvsum(), does this expose a 32-bit integer overflow when calculating left_window_bp?
Inside damon_nr_accesses_mvsum() in mm/damon/core.c, the mult_frac(x, n, d) macro evaluates (x % d) * n / d using typeof(x), which is unsigned long for left_window:
mm/damon/core.c:damon_nr_accesses_mvsum() {
...
left_window_bp = mult_frac(left_window, 10000, window_len);
...
}If window_len (derived from aggr_interval / sample_interval) exceeds 429,496, multiplying (left_window % window_len) by 10,000 can exceed 4,294,967,295. On 32-bit architectures, this silently overflows the unsigned long maximum value.
This corrupted count would now be exposed to sysfs here, and it also affects DAMOS scheme applications in __damos_valid_target(), potentially leading to incorrect memory reclaim or migrations.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=7
SeongJae Park
maintainerRe: [RFC PATCH v1.3 07/18] mm/damon/sysfs-schemes: use damon_nr_accesses_mvsum() for damo regions
Quoted 2 lines · On Mon, 22 Jun 2026 14:36:20 +0000 [email protected] wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Integer overflow inmult_fracon 32-bit architectures when calculatingleft_window_bpindamon_nr_accesses_mvsum().
Known low priority issue. Not a blocker for this patch.
Thanks,
SJ
[...]
SeongJae Park
maintainerRFC PATCH 8/18 mm/damon/core: remove damon_warn_fix_nr_accesses_corruption()
In reply to SeongJae Parknr_accesses_bp is delicate. Once it is corrupted, the consequence is the bad madness of DAMON monitoring results. From developments of features of size, we historically found nr_accesses_bp can be corrupted by complicated bugs that are not easy to debug. Hence we added a function for finding the corruption and fixing it right away.
There are no more uses of nr_accesses_bp. Hence the function for corruption detection and fix is no more needed. Rip it out.
--- mm/damon/core.c | 14 -------------- 1 file changed, 14 deletions(-)
mm/damon/core.c +0 -14
@@ -2002,19 +2002,6 @@ int damos_walk(struct damon_ctx *ctx, struct damos_walk_control *control)return 0 ; } -/* -* Warn and fix corrupted ->nr_accesses[_bp] for investigations and preventing -* the problem being propagated. -*/ -static void damon_warn_fix_nr_accesses_corruption (struct damon_region *r) -{ -if (r->nr_accesses_bp == r->nr_accesses *10000 ) -return ; -WARN_ONCE (true,"invalid nr_accesses_bp at reset: %u %u\n" , - r->nr_accesses_bp, r->nr_accesses); - r->nr_accesses_bp = r->nr_accesses *10000 ; -} -#ifdef CONFIG_DAMON_DEBUG_SANITY static void damon_verify_reset_aggregated (struct damon_region *r,struct damon_ctx *c)
@@ -2056,7 +2043,6 @@ static void kdamond_reset_aggregated(struct damon_ctx *c)trace_damon_aggregated (ti, r,damon_nr_regions (t));trace_damon_region_aggregated (ti, r,damon_nr_regions (t), nr_probes); -damon_warn_fix_nr_accesses_corruption (r); r->last_nr_accesses = r->nr_accesses; r->nr_accesses =0 ;for (i =0 ; i <DAMON_MAX_PROBES ; i++)
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 9/18 mm/damon/core: remove damon_verify_reset_aggregated()
In reply to SeongJae Parknr_accesses_bp is no longer being used in real use cases. Remove its validation function.
--- mm/damon/core.c | 18 ------------------ 1 file changed, 18 deletions(-)
mm/damon/core.c +0 -18
@@ -2002,23 +2002,6 @@ int damos_walk(struct damon_ctx *ctx, struct damos_walk_control *control)return 0 ; } -#ifdef CONFIG_DAMON_DEBUG_SANITY -static void damon_verify_reset_aggregated (struct damon_region *r, -struct damon_ctx *c) -{ -WARN_ONCE (r->nr_accesses_bp != r->last_nr_accesses *10000 , -"nr_accesses_bp %u last_nr_accesses %u sis %lu %lu\n" , - r->nr_accesses_bp, r->last_nr_accesses, - c->passed_sample_intervals, c->next_aggregation_sis); -} -#else -static void damon_verify_reset_aggregated (struct damon_region *r, -struct damon_ctx *c) -{ -} -#endif - -/* * Reset the aggregated monitoring results ('nr_accesses' of each region). */
@@ -2047,7 +2030,6 @@ static void kdamond_reset_aggregated(struct damon_ctx *c) r->nr_accesses =0 ;for (i =0 ; i <DAMON_MAX_PROBES ; i++) r->probe_hits[i] =0 ; -damon_verify_reset_aggregated (r, c); } ti++; }
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 10/18 mm/damon/core: remove damon_verify_merge_regions_of()
In reply to SeongJae Parkdamon_verify_merge_regions_of() is only for nr_accesses_bp validation. But nr_accesses_bp is no more being used for a real purpose. Remove the validation.
--- mm/damon/core.c | 15 --------------- 1 file changed, 15 deletions(-)
mm/damon/core.c +0 -15
@@ -3117,20 +3117,6 @@ static void damon_merge_two_regions(struct damon_target *t,damon_destroy_region (r, t); } -#ifdef CONFIG_DAMON_DEBUG_SANITY -static void damon_verify_merge_regions_of (struct damon_region *r) -{ -WARN_ONCE (r->nr_accesses != r->nr_accesses_bp /10000 , -"nr_accesses (%u) != nr_accesses_bp (%u)\n" , - r->nr_accesses, r->nr_accesses_bp); -} -#else -static void damon_verify_merge_regions_of (struct damon_region *r) -{ -} -#endif - -/* * Merge adjacent regions having similar access frequencies *
@@ -3144,7 +3130,6 @@ static void damon_merge_regions_of(struct damon_target *t, unsigned int thres,struct damon_region *r, *prev =NULL , *next;damon_for_each_region_safe (r, next, t) { -damon_verify_merge_regions_of (r);if (abs (r->nr_accesses - r->last_nr_accesses) > thres) r->age =0 ;else if ((r->nr_accesses ==0 ) != (r->last_nr_accesses ==0 ))
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 11/18 mm/damon/tests/core-kunit: remove nr_accesses_bp setup and tests
In reply to SeongJae ParkDAMON core unit tests set up nr_accesses_bp for representing realistic damon_region, and also test the field. nr_acceses_bp is no longer being used for a real use case. Remove the setup and tests.
--- mm/damon/tests/core-kunit.h | 8 -------- 1 file changed, 8 deletions(-)
mm/damon/tests/core-kunit.h +0 -8
@@ -118,7 +118,6 @@ static void damon_test_aggregate(struct kunit *test)kunit_skip (test,"region alloc fail" ); } r->nr_accesses = accesses[it][ir]; - r->nr_accesses_bp = accesses[it][ir] *10000 ;damon_add_region (r, t); } it++;
@@ -155,7 +154,6 @@ static void damon_test_split_at(struct kunit *test)damon_free_target (t);kunit_skip (test,"region alloc fail" ); } - r->nr_accesses_bp =420000 ; r->nr_accesses =42 ; r->last_nr_accesses =15 ; r->age =10 ;
@@ -168,7 +166,6 @@ static void damon_test_split_at(struct kunit *test)KUNIT_EXPECT_EQ (test, r_new->ar.start,25ul );KUNIT_EXPECT_EQ (test, r_new->ar.end,100ul ); -KUNIT_EXPECT_EQ (test, r->nr_accesses_bp, r_new->nr_accesses_bp);KUNIT_EXPECT_EQ (test, r->nr_accesses, r_new->nr_accesses);KUNIT_EXPECT_EQ (test, r->last_nr_accesses, r_new->last_nr_accesses);KUNIT_EXPECT_EQ (test, r->age, r_new->age);
@@ -191,7 +188,6 @@ static void damon_test_merge_two(struct kunit *test)kunit_skip (test,"region alloc fail" ); } r->nr_accesses =10 ; - r->nr_accesses_bp =100000 ; r->age =9 ;damon_add_region (r, t); r2 =damon_new_region (100 ,300 );
@@ -200,7 +196,6 @@ static void damon_test_merge_two(struct kunit *test)kunit_skip (test,"second region alloc fail" ); } r2->nr_accesses =20 ; - r2->nr_accesses_bp =200000 ; r2->age =21 ;damon_add_region (r2, t);
@@ -208,7 +203,6 @@ static void damon_test_merge_two(struct kunit *test)KUNIT_EXPECT_EQ (test, r->ar.start,0ul );KUNIT_EXPECT_EQ (test, r->ar.end,300ul );KUNIT_EXPECT_EQ (test, r->nr_accesses,16u ); -KUNIT_EXPECT_EQ (test, r->nr_accesses_bp,160000u );KUNIT_EXPECT_EQ (test, r->age,17u ); i =0 ;
@@ -256,7 +250,6 @@ static void damon_test_merge_regions_of(struct kunit *test)kunit_skip (test,"region alloc fail" ); } r->nr_accesses = nrs[i]; - r->nr_accesses_bp = nrs[i] *10000 ;damon_add_region (r, t); }
@@ -556,7 +549,6 @@ static void damon_test_update_monitoring_result(struct kunit *test)kunit_skip (test,"region alloc fail" ); r->nr_accesses =15 ; - r->nr_accesses_bp =150000 ; r->age =20 ; new_attrs = (struct damon_attrs ){
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 12/18 selftests/damon/drgn_dump_damon_status: do not dump nr_accesses_bp
In reply to SeongJae Parkdrgn_dump_damon_status is dumping nr_accesses_bp field for future use case. nr_accesses_bp is not being used for a real purpose, though. Hence there will be no future test for it. Do not dump it.
--- tools/testing/selftests/damon/drgn_dump_damon_status.py | 1 - 1 file changed, 1 deletion(-)
tools/testing/selftests/damon/drgn_dump_damon_status.py +0 -1
@@ -59,7 +59,6 @@ def region_to_dict(region): ['ar', addr_range_to_dict], ['sampling_addr', int], ['nr_accesses', int], - ['nr_accesses_bp', int], ['age', int], ])
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 13/18 mm/damon/core: remove nr_accesses_bp setups and updates
In reply to SeongJae ParkDAMON core sets and updates nr_accesses_bp in multiple places. It explains how delicate it is. The field is no more being used for any real purpose, and replaced by a simpler function. Remove the setups and updates.
--- mm/damon/core.c | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-)
mm/damon/core.c +2 -20
@@ -304,7 +304,6 @@ struct damon_region *damon_new_region(unsigned long start, unsigned long end) region->ar.start = start; region->ar.end = end; region->nr_accesses =0 ; - region->nr_accesses_bp =0 ;for (i =0 ; i <DAMON_MAX_PROBES ; i++) region->probe_hits[i] =0 ;INIT_LIST_HEAD (®ion->list);
@@ -878,20 +877,17 @@ static void damon_update_monitoring_result(struct damon_region *r, { r->last_nr_accesses =damon_nr_accesses_for_new_attrs ( r->last_nr_accesses, old_attrs, new_attrs); -if (!aggregating) { +if (!aggregating) r->nr_accesses =damon_nr_accesses_for_new_attrs ( r->nr_accesses, old_attrs, new_attrs); - r->nr_accesses_bp = r->nr_accesses *10000 ; - }else { +else /* * if this is called in the middle of the aggregation, reset * the aggregations we made so far for this aggregation * interval. In other words, make the status like * kdamond_reset_aggregated() is called. */ - r->nr_accesses_bp = r->last_nr_accesses *10000 ; r->nr_accesses =0 ; - } r->age =damon_age_for_new_attrs (r->age, old_attrs, new_attrs); }
@@ -3106,7 +3102,6 @@ static void damon_merge_two_regions(struct damon_target *t, l->nr_accesses = (l->nr_accesses * sz_l + r->nr_accesses * sz_r) / (sz_l + sz_r); - l->nr_accesses_bp = l->nr_accesses *10000 ; l->age = (l->age * sz_l + r->age * sz_r) / (sz_l + sz_r); l->ar.end = r->ar.end;/* todo: do this for only installed probes */
@@ -3218,7 +3213,6 @@ static void damon_split_region_at(struct damon_target *t, new->age = r->age; new->last_nr_accesses = r->last_nr_accesses; - new->nr_accesses_bp = r->nr_accesses_bp; new->nr_accesses = r->nr_accesses;/* todo: do this for only installed probes */ memcpy (new->probe_hits, r->probe_hits,sizeof (r->probe_hits));
@@ -3787,18 +3781,6 @@ static unsigned int damon_moving_sum(unsigned int mvsum, unsigned int nomvsum,void damon_update_region_access_rate (struct damon_region *r,bool accessed,struct damon_attrs *attrs) { -unsigned int len_window =1 ; - -/* -* sample_interval can be zero, but cannot be larger than -* aggr_interval, owing to validation of damon_set_attrs(). -*/ -if (attrs->sample_interval) - len_window =damon_max_nr_accesses (attrs); - r->nr_accesses_bp =damon_moving_sum (r->nr_accesses_bp, - r->last_nr_accesses *10000 , len_window, - accessed ?10000 :0 ); -if (accessed) r->nr_accesses++; }
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 14/18 mm/damon/core: remove attrs param from damon_update_region_access_rate()
In reply to SeongJae Parkdamon_region_access_rate() is not using attrs parameter. Remove it.
--- include/linux/damon.h | 3 +-- mm/damon/core.c | 4 +--- mm/damon/paddr.c | 4 ++-- mm/damon/vaddr.c | 6 +++--- 4 files changed, 7 insertions(+), 10 deletions(-)
include/linux/damon.h +1 -2
@@ -1018,8 +1018,7 @@ unsigned int damon_nr_accesses_mvsum(struct damon_region *r,int damon_set_regions (struct damon_target *t,struct damon_addr_range *ranges,unsigned int nr_ranges,unsigned long min_region_sz); -void damon_update_region_access_rate (struct damon_region *r,bool accessed, -struct damon_attrs *attrs); +void damon_update_region_access_rate (struct damon_region *r,bool accessed);struct damos_filter *damos_new_filter (enum damos_filter_type type,bool matching,bool allow);
mm/damon/core.c +1 -3
@@ -3771,15 +3771,13 @@ static unsigned int damon_moving_sum(unsigned int mvsum, unsigned int nomvsum,* damon_update_region_access_rate() - Update the access rate of a region. * @r: The DAMON region to update for its access check result. * @accessed: Whether the region has accessed during last sampling interval. -* @attrs: The damon_attrs of the DAMON context. * * Update the access rate of a region with the region's last sampling interval * access check result. * * Usually this will be called by &damon_operations->check_accesses callback. */ -void damon_update_region_access_rate (struct damon_region *r,bool accessed, -struct damon_attrs *attrs) +void damon_update_region_access_rate (struct damon_region *r,bool accessed) {if (accessed) r->nr_accesses++;
mm/damon/paddr.c +2 -2
@@ -93,12 +93,12 @@ static void __damon_pa_check_access(struct damon_region *r,/* If the region is in the last checked page, reuse the result */ if (ALIGN_DOWN (last_addr, last_folio_sz) ==ALIGN_DOWN (sampling_addr, last_folio_sz)) { -damon_update_region_access_rate (r, last_accessed, attrs); +damon_update_region_access_rate (r, last_accessed);return ; } last_accessed =damon_pa_young (sampling_addr, &last_folio_sz); -damon_update_region_access_rate (r, last_accessed, attrs); +damon_update_region_access_rate (r, last_accessed); last_addr = sampling_addr; }
mm/damon/vaddr.c +3 -3
@@ -503,19 +503,19 @@ static void __damon_va_check_access(struct mm_struct *mm,static bool last_accessed;if (!mm) { -damon_update_region_access_rate (r, false, attrs); +damon_update_region_access_rate (r, false);return ; }/* If the region is in the last checked page, reuse the result */ if (same_target && (ALIGN_DOWN (last_addr, last_folio_sz) ==ALIGN_DOWN (r->sampling_addr, last_folio_sz))) { -damon_update_region_access_rate (r, last_accessed, attrs); +damon_update_region_access_rate (r, last_accessed);return ; } last_accessed =damon_va_young (mm, r->sampling_addr, &last_folio_sz); -damon_update_region_access_rate (r, last_accessed, attrs); +damon_update_region_access_rate (r, last_accessed); last_addr = r->sampling_addr; }
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 15/18 mm/damonn/paddr: remove attrs param from __damon_pa_check_access()
In reply to SeongJae ParkThe function is not using the parameter. Remove it.
--- mm/damon/paddr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
mm/damon/paddr.c +2 -3
@@ -82,7 +82,7 @@ static bool damon_pa_young(phys_addr_t paddr, unsigned long *folio_sz) }static void __damon_pa_check_access (struct damon_region *r, -struct damon_attrs *attrs,unsigned long addr_unit) +unsigned long addr_unit) {static phys_addr_t last_addr;static unsigned long last_folio_sz =PAGE_SIZE ;
@@ -111,8 +111,7 @@ static unsigned int damon_pa_check_accesses(struct damon_ctx *ctx)damon_for_each_target (t, ctx) {damon_for_each_region (r, t) { -__damon_pa_check_access ( - r, &ctx->attrs, ctx->addr_unit); +__damon_pa_check_access (r, ctx->addr_unit); max_nr_accesses =max (r->nr_accesses, max_nr_accesses); } }
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 16/18 mm/damon/vaddr: remove attrs param from __damon_va_check_access()
In reply to SeongJae ParkThe function is not using attrs parameter. Remove it.
--- mm/damon/vaddr.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
mm/damon/vaddr.c +2 -4
@@ -495,8 +495,7 @@ static bool damon_va_young(struct mm_struct *mm, unsigned long addr,* r the region to be checked */ static void __damon_va_check_access (struct mm_struct *mm, -struct damon_region *r,bool same_target, -struct damon_attrs *attrs) +struct damon_region *r,bool same_target) {static unsigned long last_addr;static unsigned long last_folio_sz =PAGE_SIZE ;
@@ -532,8 +531,7 @@ static unsigned int damon_va_check_accesses(struct damon_ctx *ctx) mm =damon_get_mm (t); same_target = false;damon_for_each_region (r, t) { -__damon_va_check_access (mm, r, same_target, - &ctx->attrs); +__damon_va_check_access (mm, r, same_target); max_nr_accesses =max (r->nr_accesses, max_nr_accesses); same_target = true; }
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 17/18 mm/damon/core: remove damon_moving_sum() and its unit test
In reply to SeongJae Parkdamon_moving_sum() is no longer being called for real purpose but its unit test. Testing a function that is not being used for real users makes no sense. Remove the test and the function.
--- mm/damon/core.c | 40 ------------------------------------- mm/damon/tests/core-kunit.h | 16 --------------- 2 files changed, 56 deletions(-)
mm/damon/core.c +0 -40
@@ -3727,46 +3727,6 @@ int damon_set_region_system_rams_default(struct damon_target *t,return damon_set_regions (t, &addr_range,1 , min_region_sz); } -/* -* damon_moving_sum() - Calculate an inferred moving sum value. -* @mvsum: Inferred sum of the last @len_window values. -* @nomvsum: Non-moving sum of the last discrete @len_window window values. -* @len_window: The number of last values to take care of. -* @new_value: New value that will be added to the pseudo moving sum. -* -* Moving sum (moving average * window size) is good for handling noise, but -* the cost of keeping past values can be high for arbitrary window size. This -* function implements a lightweight pseudo moving sum function that doesn't -* keep the past window values. -* -* It simply assumes there was no noise in the past, and get the no-noise -* assumed past value to drop from @nomvsum and @len_window. @nomvsum is a -* non-moving sum of the last window. For example, if @len_window is 10 and we -* have 25 values, @nomvsum is the sum of the 11th to 20th values of the 25 -* values. Hence, this function simply drops @nomvsum / @len_window from -* given @mvsum and add @new_value. -* -* For example, if @len_window is 10 and @nomvsum is 50, the last 10 values for -* the last window could be vary, e.g., 0, 10, 0, 10, 0, 10, 0, 0, 0, 20. For -* calculating next moving sum with a new value, we should drop 0 from 50 and -* add the new value. However, this function assumes it got value 5 for each -* of the last ten times. Based on the assumption, when the next value is -* measured, it drops the assumed past value, 5 from the current sum, and add -* the new value to get the updated pseduo-moving average. -* -* This means the value could have errors, but the errors will be disappeared -* for every @len_window aligned calls. For example, if @len_window is 10, the -* pseudo moving sum with 11th value to 19th value would have an error. But -* the sum with 20th value will not have the error. -* -* Return: Pseudo-moving average after getting the @new_value. -*/ -static unsigned int damon_moving_sum (unsigned int mvsum,unsigned int nomvsum, -unsigned int len_window,unsigned int new_value) -{ -return mvsum - nomvsum / len_window + new_value; -} -/** * damon_update_region_access_rate() - Update the access rate of a region. * @r: The DAMON region to update for its access check result.
mm/damon/tests/core-kunit.h +0 -16
@@ -600,21 +600,6 @@ static void damon_test_set_attrs(struct kunit *test)damon_destroy_ctx (c); } -static void damon_test_moving_sum (struct kunit *test) -{ -unsigned int mvsum =50000 , nomvsum =50000 , len_window =10 ; -unsigned int new_values[] = {10000 ,0 ,10000 ,0 ,0 ,0 ,10000 ,0 ,0 ,0 }; -unsigned int expects[] = {55000 ,50000 ,55000 ,50000 ,45000 ,40000 , -45000 ,40000 ,35000 ,30000 }; -int i; - -for (i =0 ; i <ARRAY_SIZE (new_values); i++) { - mvsum =damon_moving_sum (mvsum, nomvsum, len_window, - new_values[i]); -KUNIT_EXPECT_EQ (test, mvsum, expects[i]); - } -} -static void damon_test_mvsum (struct kunit *test) {unsigned long input_expects[] = {
@@ -1516,7 +1501,6 @@ static struct kunit_case damon_test_cases[] = {KUNIT_CASE (damon_test_nr_accesses_to_accesses_bp),KUNIT_CASE (damon_test_update_monitoring_result),KUNIT_CASE (damon_test_set_attrs), -KUNIT_CASE (damon_test_moving_sum),KUNIT_CASE (damon_test_mvsum),KUNIT_CASE (damos_test_new_filter), KUNIT_CASE(damos_test_commit_quota_goal),
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 18/18 mm/damon: remove damon_region->nr_accesses_bp
In reply to SeongJae ParkNo code touches damon_region->nr_accesses_bp field. Remove it.
--- include/linux/damon.h | 10 ---------- mm/damon/core.c | 3 +-- 2 files changed, 1 insertion(+), 12 deletions(-)
include/linux/damon.h +0 -10
@@ -47,8 +47,6 @@ struct damon_size_range {* @ar: The address range of the region. * @sampling_addr: Address of the sample for the next access check. * @nr_accesses: Access frequency of this region. -* @nr_accesses_bp: @nr_accesses in basis point (0.01%) that updated for -* each sampling interval. * @probe_hits: Number of probe-positive region samples. * @list: List head for siblings. * @age: Age of this region.
@@ -61,13 +59,6 @@ struct damon_size_range {* not be done with direct access but with the helper function, * damon_update_region_access_rate(). * -* @nr_accesses_bp is another representation of @nr_accesses in basis point -* (1 in 10,000) that updated for every &damon_attrs->sample_interval in a -* manner similar to moving sum. By the algorithm, this value becomes -* @nr_accesses * 10000 for every &struct damon_attrs->aggr_interval. This can -* be used when the aggregation interval is too huge and therefore cannot wait -* for it before getting the access monitoring results. -* * @age is initially zero, increased for each aggregation interval, and reset * to zero again if the access frequency is significantly changed. If two * regions are merged into a new region, both @nr_accesses and @age of the new
@@ -77,7 +68,6 @@ struct damon_region {struct damon_addr_range ar;unsigned long sampling_addr;unsigned int nr_accesses; -unsigned int nr_accesses_bp;unsigned char probe_hits[DAMON_MAX_PROBES ];struct list_head list;
mm/damon/core.c +1 -2
@@ -3587,8 +3587,7 @@ static int kdamond_fn(void *data)* aggregation, and make aggregation * information reset for all regions. Then, * following kdamond_reset_aggregated() call -* will make the region information invalid, -* particularly for ->nr_accesses_bp. +* will make the region information invalid. * * Reset ->next_aggregation_sis to avoid that. * It will anyway correctly updated after this
Signature · 1 line
2.47.3