a2dp: Fix handling of codec capability storage
Luiz Augusto von Dentz
maintainerPATCH v2 1/1 a2dp: Fix handling of codec capability storage
From: Luiz Augusto von Dentz <[email protected]>
Codec capability is one byte long (max 255) the storage format is 02hhx which means each byte ends up as 2 characters so the buffer needs to be doubled in order to handle capabilities of that size.
--- profiles/audio/a2dp.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
profiles/audio/a2dp.c +5 -5
@@ -971,7 +971,7 @@ static void store_remote_sep(void *data, void *user_data) {struct a2dp_remote_sep *sep = data;GKeyFile *key_file = user_data; -char seid[4 ], value[256 ]; +char seid[4 ], value[9 +512 ];struct avdtp_service_capability *service =avdtp_get_codec (sep->sep);struct avdtp_media_codec_capability *codec;unsigned int i;
@@ -2373,7 +2373,7 @@ static void load_remote_sep(struct a2dp_channel *chan, GKeyFile *key_file,uint8_t codec;uint8_t delay_reporting;GSList *l =NULL ; -char caps[256 ]; +char caps[513 ];uint8_t data[128 ];int i, size;
@@ -2386,10 +2386,10 @@ static void load_remote_sep(struct a2dp_channel *chan, GKeyFile *key_file,continue ;/* Try loading with delay_reporting first */ -if (sscanf (value,"%02hhx:%02hhx:%02hhx:%s" , &type, &codec, +if (sscanf (value,"%02hhx:%02hhx:%02hhx:%512s" , &type, &codec, &delay_reporting, caps) !=4 ) {/* Try old format */ -if (sscanf (value,"%02hhx:%02hhx:%s" , &type, &codec, +if (sscanf (value,"%02hhx:%02hhx:%512s" , &type, &codec, caps) !=3 ) {warn ("Unable to load Endpoint: seid %u" , rseid);g_free (value);
@@ -2398,7 +2398,7 @@ static void load_remote_sep(struct a2dp_channel *chan, GKeyFile *key_file, delay_reporting = false; } -for (i =0 , size =strlen (caps); i < size; i +=2 ) { +for (i =0 , size =strlen (caps); i < size && i >=2 ; i +=2 ) {uint8_t *tmp = data + i /2 ;if (sscanf (caps + i,"%02hhx" , tmp) !=1 ) {
Signature · 1 line
2.54.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1114843
---Test result---
Test Summary:
CheckPatch FAIL 0.92 seconds GitLint FAIL 0.67 seconds BuildEll PASS 20.21 seconds BluezMake PASS 619.69 seconds MakeCheck PASS 3.14 seconds MakeDistcheck PASS 237.22 seconds CheckValgrind PASS 206.49 seconds CheckSmatch PASS 328.16 seconds bluezmakeextell PASS 166.29 seconds IncrementalBuild PASS 623.46 seconds ScanBuild PASS 931.40 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,v2] a2dp: Fix handling of codec capability storage WARNING:BAD_SIGN_OFF: Use a single space after Reported-by:
#101:
ERROR:BAD_SIGN_OFF: Unrecognized email address: 'p0her (_@p0her_) in TeamH4C working with TrendAI Zero Day Initiative' #101:
/github/workspace/src/patch/14639629.patch total: 1 errors, 1 warnings, 36 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/patch/14639629.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v2] a2dp: Fix handling of codec capability storage
9: B1 Line exceeds max length (82>80): "Reported-by: p0her (_@p0her_) in TeamH4C working with TrendAI Zero Day Initiative"
https://github.com/bluez/bluez/pull/2251
---
Regards,
Linux Bluetooth
Quoted 18 lines · Luiz Augusto von Dentz
From: Luiz Augusto von Dentz <[email protected]>
Codec capability is one byte long (max 255) the storage format is 02hhx which means each byte ends up as 2 characters so the buffer needs to be doubled in order to handle capabilities of that size.
Day Initiative
Reported-by Michael Bommarito <[email protected]>---
profiles/audio/a2dp.c | 10 +++++-----1 file changed, 5 insertions(+), 5 deletions(-)profiles/audio/a2dp.c +0
-0
profiles/audio/a2dp.c static void store_remote_sep(void *data, void · line 975
Quoted 6 lines
profiles/audio/a2dp.c +1
-1@@ -971,7 +971,7 @@ static void store_remote_sep(void *data, void *user_data) { struct a2dp_remote_sep *sep = data; GKeyFile *key_file = user_data; -char seid[4 ], value[256 ]; +char seid[4 ], value[9 +512 ];
What's the "9" value from? Shouldn't it be 11 for the length of:
"%02hhx:%02hhx:%02hhx:"
The "Try loading with delay_reporting first" variant?
Quoted 46 lines
struct
avdtp_service_capability*service =avdtp_get_codec(sep->sep);
structavdtp_media_codec_capability*codec; unsigned int i;profiles/audio/a2dp.c +1
-1@@ -2373,7 +2373,7 @@ static void load_remote_sep(struct a2dp_channel *chan, GKeyFile *key_file, uint8_t codec; uint8_t delay_reporting; GSList *l = NULL; -char caps[256 ]; +char caps[513 ]; uint8_t data[128]; int i, size;profiles/audio/a2dp.c +0
-0@@ -2386,10 +2386,10 @@ static void load_remote_sep(struct a2dp_channel *chan, GKeyFile *key_file, continue;
/* Try loading withdelay_reportingfirst */profiles/audio/a2dp.c +0
-1- if (sscanf(value, "%02hhx:%02hhx:%02hhx:%s", &type,&codec,
profiles/audio/a2dp.c +1
-0+ if (sscanf(value, "%02hhx:%02hhx:%02hhx:%512s",&type, &codec,
&delay_reporting, caps) !=
4) {
/* Try old format */profiles/audio/a2dp.c +0
-1- if (sscanf(value, "%02hhx:%02hhx:%s", &type,&codec,
profiles/audio/a2dp.c +1
-0+ if (sscanf(value, "%02hhx:%02hhx:%512s",&type, &codec,
caps ) != 3) {
warn("Unable to load Endpoint: seid %u", rseid);
g_free(value);profiles/audio/a2dp.c +0
-0@@ -2398,7 +2398,7 @@ static void load_remote_sep(struct a2dp_channel *chan, GKeyFile *key_file, delay_reporting = false; }profiles/audio/a2dp.c +1
-1-for (i =0 , size =strlen (caps); i < size; i +=2 ) { + for (i = 0, size = strlen(caps); i < size && i >= 2;i += 2) {
uint8_t*tmp = data + i / 2;
if (sscanf(caps + i, "%02hhx", tmp)!= 1) {
Luiz Augusto von Dentz
maintainerHi Bastien,
Quoted 15 lines · Bastien Nocera
Quoted 13 lines · Luiz Augusto von Dentz
From: Luiz Augusto von Dentz <[email protected]>
Codec capability is one byte long (max 255) the storage format is 02hhx which means each byte ends up as 2 characters so the buffer needs to be doubled in order to handle capabilities of that size.
Day Initiative
Reported-by Michael Bommarito <[email protected]>--- profiles/audio/a2dp.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Quoted 14 lines
profiles/audio/a2dp.c static void store_remote_sep(void *data, void · line 975
Quoted 11 lines
profiles/audio/a2dp.c +1
-1@@ -971,7 +971,7 @@ static void store_remote_sep(void *data, void *user_data) {struct a2dp_remote_sep *sep = data;GKeyFile *key_file = user_data; -char seid[4 ], value[256 ]; +char seid[4 ], value[9 +512 ];What's the "9" value from? Shouldn't it be 11 for the length of:
"%02hhx:%02hhx:%02hhx:"
3 * 2 (%02hhx) + 3 (:) = 9
Quoted 48 lines
The "Try loading with
delay_reportingfirst" variant?Quoted 46 lines
profiles/audio/a2dp.c +0
-0struct avdtp_service_capability *service =avdtp_get_codec (sep->sep);struct avdtp_media_codec_capability *codec; unsigned int i;profiles/audio/a2dp.c +2
-3@@ -2373,7 +2373,7 @@ static void load_remote_sep(struct a2dp_channel *chan, GKeyFile *key_file, uint8_t codec;uint8_t delay_reporting;GSList *l =NULL ; -char caps[256 ]; +char caps[513 ];uint8_t data[128 ];int i, size;@@ -2386,10 +2386,10 @@ static void load_remote_sep(struct a2dp_channel *chan, GKeyFile *key_file, continue;/* Try loading with delay_reporting first */ -if (sscanf (value,"%02hhx:%02hhx:%02hhx:%s" , &type, &codec, + if (sscanf(value, "%02hhx:%02hhx:%02hhx:%512s", &type, &codec, &delay_reporting, caps) != 4) {/* Try old format */ - if (sscanf(value, "%02hhx:%02hhx:%s", &type,&codec,
+ if (sscanf(value, "%02hhx:%02hhx:%512s",
&type, &codec,
caps
) != 3) {
warn("Unable to load Endpoint: seid%u", rseid); g_free(value);profiles/audio/a2dp.c +1
-1@@ -2398,7 +2398,7 @@ static void load_remote_sep(struct a2dp_channel *chan, GKeyFile *key_file, delay_reporting = false; } -for (i =0 , size =strlen (caps); i < size; i +=2 ) { +for (i =0 , size =strlen (caps); i < size && i >=2 ; i +=2 ) {uint8_t *tmp = data + i /2 ;if (sscanf(caps + i, "%02hhx", tmp) != 1) {
Signature · 1 line
Luiz Augusto von Dentz
Quoted 35 lines · Luiz Augusto von Dentz
Hi Bastien,
Quoted 16 lines · Bastien Nocera
Quoted 14 lines · Luiz Augusto von Dentz
From: Luiz Augusto von Dentz <[email protected]>
Codec capability is one byte long (max 255) the storage format is 02hhx which means each byte ends up as 2 characters so the buffer needs to be doubled in order to handle capabilities of that size.
Reported-by p0her (_@p0her_) in TeamH4C working with TrendAIZero
Day InitiativeReported-by Michael Bommarito <[email protected]>---
profiles/audio/a2dp.c | 10 +++++-----1 file changed, 5 insertions(+), 5 deletions(-)Quoted 14 lines
profiles/audio/a2dp.c static void store_remote_sep(void *data, void · line 975
Quoted 11 lines
profiles/audio/a2dp.c +1
-1@@ -971,7 +971,7 @@ static void store_remote_sep(void *data, void *user_data) { struct a2dp_remote_sep *sep = data; GKeyFile *key_file = user_data; - char seid[4], value[256]; + char seid[4], value[9 + 512];What's the "9" value from? Shouldn't it be 11 for the length of:
"%02hhx:%02hhx:%02hhx:"
Quoted 1 line
3 * 2 (%02hhx) + 3 (:) = 9
If you're doing a fixup, might be a good idea to add as a comment, thanks!
Quoted 57 lines
Quoted 55 lines
The "Try loading with
delay_reportingfirst" variant?Quoted 52 lines
struct
avdtp_service_capability*service =avdtp_get_codec(sep->sep);
structavdtp_media_codec_capability*codec;
unsigned int i;profiles/audio/a2dp.c +0
-0@@ -2373,7 +2373,7 @@ static void load_remote_sep(struct
a2dp_channel
*chan, GKeyFile*key_file,
uint8_tcodec;
uint8_tdelay_reporting;
GSList *l = NULL;
- char caps[256];
+ char caps[513];
uint8_tdata[128];
int i, size;profiles/audio/a2dp.c +1
-1@@ -2386,10 +2386,10 @@ static void load_remote_sep(struct a2dp_channel *chan, GKeyFile *key_file, continue; /* Try loading with delay_reporting first */ - if (sscanf(value, "%02hhx:%02hhx:%02hhx:%s", &type, &codec, + if (sscanf(value, "%02hhx:%02hhx:%02hhx:%512s", &type, &codec,
&delay_reporting, caps) !=
4) {
/* Try old format */
- if (sscanf(value, "%02hhx:%02hhx:%s", &type,
&codec,
+ if (sscanf(value, "%02hhx:%02hhx:%512s", &type, &codec,
caps
) != 3) {
warn("Unable to load Endpoint: seid %u", rseid);
g_free(value);profiles/audio/a2dp.c +0
-0@@ -2398,7 +2398,7 @@ static void load_remote_sep(struct
a2dp_channel
*chan, GKeyFile*key_file,
delay_reporting= false;
}- for (i = 0, size = strlen(caps); i < size; i += 2) {
+ for (i = 0, size = strlen(caps); i < size && i >= 2;
i += 2) {
uint8_t*tmp = data + i / 2;if (
sscanf(caps + i, "%02hhx", tmp)!= 1) {
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 10 lines · On Mon, 22 Jun 2026 11:56:21 -0400 you wrote:
From: Luiz Augusto von Dentz <[email protected]>
Codec capability is one byte long (max 255) the storage format is 02hhx which means each byte ends up as 2 characters so the buffer needs to be doubled in order to handle capabilities of that size.
Reported-by Michael Bommarito <[email protected]>[...]
Here is the summary with links:
- [BlueZ,v2] a2dp: Fix handling of codec capability storage
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=912f5efb0dd9
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html