atm: fore200e: disable PCI device on DMA mask failure
Subsystems (3)
PATCH 1/1 atm: fore200e: disable PCI device on DMA mask failure
fore200e_pca_detect() enables the PCI device before setting the DMA mask. If dma_set_mask_and_coherent() fails, the current error path returns without disabling the device.
Reuse the existing out_disable unwind label for this failure path so pci_disable_device() is called after a successful pci_enable_device().
--- drivers/atm/fore200e.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/atm/fore200e.c +1 -1
@@ -2593,7 +2593,7 @@ static int fore200e_pca_detect(struct pci_dev *pci_dev,if (dma_set_mask_and_coherent (&pci_dev->dev,DMA_BIT_MASK (32 ))) { err = -EINVAL ; - goto out; + goto out_disable; } fore200e = kzalloc_obj(struct fore200e);
Signature · 1 line
2.47.1
Quoted 6 lines · Myeonghun Pak
fore200e_pca_detect()enables the PCI device before setting the DMA mask. Ifdma_set_mask_and_coherent()fails, the current error path returns without disabling the device.Reuse the existing
out_disableunwind label for this failure path sopci_disable_device()is called after a successfulpci_enable_device().
What tree is this against?
ommit 6deb53595092b1426885f6503d93eedc1e3ece77
Author: Jakub Kicinski <[email protected]> Date: Mon Apr 20 13:42:28 2026 -0700
net: remove unused ATM protocols and legacy ATM device drivers
Remove the ATM protocol modules and PCI/SBUS ATM device drivers that are no longer in active use.
The ATM core protocol stack, PPPoATM, BR2684, and USB DSL modem drivers (drivers/usb/atm/) are retained in-tree to maintain PPP over ATM (PPPoA) and PPPoE-over-BR2684 support for DSL connections. The Solos ADSL2+ PCI driver is also retained.
Removed ATM protocol modules:
- net/atm/clip.c - Classical IP over ATM (RFC 2225)
- net/atm/lec.c - LAN Emulation Client (LANE)
- net/atm/mpc.c, mpoa_caches.c, mpoa_proc.c - Multi-Protocol Over ATM
Removed PCI/SBUS ATM device drivers (drivers/atm/):
- adummy, atmtcp - software/testing ATM devices
- eni - Efficient Networks ENI155P (OC-3, ~1995)
- fore200e - FORE Systems 200E PCI/SBUS (OC-3, ~1999)
Please subscribe to the netdev Mailing list, so you know what is going on.
Andrew
---
pw-bot: reject
Hi Andrew,
Sorry for the noise.
This was against my local torvalds/linux v7.0 tree (028ef9c96e96), not the current netdev/net-next tree. I missed 6deb53595092 ("net: remove unused ATM protocols and legacy ATM device drivers"), which removes fore200e, so this patch is obsolete.
Please drop/ignore it. I will subscribe to netdev and check the current networking trees before sending future networking patches.
Thanks,
Myeonghun
2026년 6월 23일 (화) 오후 5:56, Andrew Lunn <[email protected]>님이 작성:
Quoted 45 lines · Myeonghun Pak
Quoted 6 lines
fore200e_pca_detect()enables the PCI device before setting the DMA mask. Ifdma_set_mask_and_coherent()fails, the current error path returns without disabling the device.Reuse the existing
out_disableunwind label for this failure path sopci_disable_device()is called after a successfulpci_enable_device().What tree is this against?
ommit
6deb53595092b1426885f6503d93eedc1e3ece77Author: Jakub Kicinski <[email protected]> Date: Mon Apr 20 13:42:28 2026 -0700net: remove unused ATM protocols and legacy ATM device drivers
Remove the ATM protocol modules and PCI/SBUS ATM device drivers that are no longer in active use.
The ATM core protocol stack, PPPoATM, BR2684, and USB DSL modem drivers (
drivers/usb/atm/) are retained in-tree to maintain PPP over ATM (PPPoA) and PPPoE-over-BR2684 support for DSL connections. The Solos ADSL2+ PCI driver is also retained.Removed ATM protocol modules:
-net/atm/clip.c- Classical IP over ATM (RFC 2225)
-net/atm/lec.c- LAN Emulation Client (LANE)
-net/atm/mpc.c,mpoa_caches.c,mpoa_proc.c- Multi-Protocol Over ATMRemoved PCI/SBUS ATM device drivers (
drivers/atm/):
- adummy, atmtcp - software/testing ATM devices
- eni - Efficient Networks ENI155P (OC-3, ~1995)
- fore200e - FORE Systems 200E PCI/SBUS (OC-3, ~1999)Please subscribe to the netdev Mailing list, so you know what is going on.
Andrew
---
pw-bot: reject