Skip to contentSkip to conversation

mm: memcg: remove stray text from obj_stock_pcp comment

PATCH Applied Guopeng Zhang 3 participants 4 messages Jun 23 – Jun 24

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: memcg: remove stray text from obj_stock_pcp comment

From: Guopeng Zhang <[email protected]>

A patch filename was accidentally inserted into the comment describing the nr_bytes field of struct obj_stock_pcp. Remove it.

No functional change.

---
 mm/memcontrol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memcontrol.c +1 -1
index 6dc4888a90f3..3eedfc4e84a0 100644
@@ -2039,7 +2039,7 @@ struct obj_stock_pcp {
 	/*
 	 * On rare archs with 256KiB base page size (hexagon and powerpc 44x)
 	 * keep nr_bytes to unsigned int as uint16_t cannot represent the full
-e patches/memcg-uint16_t-for-nr_bytes-in-obj_stock_pcp.patch	 * sub-page remainder. Such archs are not cacheline optimization target.
+	 * sub-page remainder. Such archs are not cacheline optimization targets.
 	 */
 	unsigned int nr_bytes[NR_OBJ_STOCK];
 #else
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Guopeng Zhang

From: Guopeng Zhang <[email protected]>

A patch filename was accidentally inserted into the comment describing the nr_bytes field of struct obj_stock_pcp. Remove it.

nit: perhaps add something like
"Fix a typo in the comment (target -> targets)"?

Quoted 4 lines

No functional change.

---

FWIW,

Thanks!

Quoted 16 lines
 mm/memcontrol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memcontrol.c +1 -1
index 6dc4888a90f3..3eedfc4e84a0 100644
@@ -2039,7 +2039,7 @@ struct obj_stock_pcp {
 	/*
 	 * On rare archs with 256KiB base page size (hexagon and powerpc 44x)
 	 * keep nr_bytes to unsigned int as uint16_t cannot represent the full
-e patches/memcg-uint16_t-for-nr_bytes-in-obj_stock_pcp.patch	 * sub-page remainder. Such archs are not cacheline optimization target.
+	 * sub-page remainder. Such archs are not cacheline optimization targets.
 	 */
 	unsigned int nr_bytes[NR_OBJ_STOCK];
 #else
Signature · 2 lines
Cheers,
Harry / Hyeonggon
#2 lore raw
Quoted 8 lines · Harry Yoo
Quoted 4 lines · Guopeng Zhang

From: Guopeng Zhang <[email protected]>

A patch filename was accidentally inserted into the comment describing the nr_bytes field of struct obj_stock_pcp. Remove it.

nit: perhaps add something like
"Fix a typo in the comment (target -> targets)"?

Hi Harry,

Thanks for the review and the Ack.

Yes, I also fixed the "target -> targets" typo, but missed mentioning it in the commit message. I'll be more careful about describing all changes clearly next time. If a respin is needed, I'll add it to the commit message and carry your Acked-by.

Thanks,
Guopeng

Quoted 25 lines
Quoted 4 lines

No functional change.

---

FWIW,

Thanks!

Quoted 16 lines
 mm/memcontrol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memcontrol.c +1 -1
index 6dc4888a90f3..3eedfc4e84a0 100644
@@ -2039,7 +2039,7 @@ struct obj_stock_pcp {
 	/*
 	 * On rare archs with 256KiB base page size (hexagon and powerpc 44x)
 	 * keep nr_bytes to unsigned int as uint16_t cannot represent the full
-e patches/memcg-uint16_t-for-nr_bytes-in-obj_stock_pcp.patch	 * sub-page remainder. Such archs are not cacheline optimization target.
+	 * sub-page remainder. Such archs are not cacheline optimization targets.
 	 */
 	unsigned int nr_bytes[NR_OBJ_STOCK];
 #else
#3 lore raw
Quoted 10 lines · Guopeng Zhang
Quoted 8 lines · Harry Yoo
Quoted 4 lines · Guopeng Zhang

From: Guopeng Zhang <[email protected]>

A patch filename was accidentally inserted into the comment describing the nr_bytes field of struct obj_stock_pcp. Remove it.

nit: perhaps add something like
"Fix a typo in the comment (target -> targets)"?

Hi Harry,

Hi Guopeng,

Quoted 4 lines

Thanks for the review and the Ack.

Yes, I also fixed the "target -> targets" typo, but missed mentioning it in the commit message.

No worries :)
It's not a big deal, just wanted to mention.

Quoted 2 lines

I'll be more careful about describing all changes
clearly next time.

Thanks!

Quoted 2 lines

If a respin is needed, I'll add it to the commit
message and carry your Acked-by.

I guess it's okay to not respin for this.

Thanks!

Quoted 28 lines

Thanks,
Guopeng

Quoted 25 lines
Quoted 4 lines

No functional change.

---

FWIW,

Thanks!

Quoted 16 lines
 mm/memcontrol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memcontrol.c +1 -1
index 6dc4888a90f3..3eedfc4e84a0 100644
@@ -2039,7 +2039,7 @@ struct obj_stock_pcp {
 	/*
 	 * On rare archs with 256KiB base page size (hexagon and powerpc 44x)
 	 * keep nr_bytes to unsigned int as uint16_t cannot represent the full
-e patches/memcg-uint16_t-for-nr_bytes-in-obj_stock_pcp.patch	 * sub-page remainder. Such archs are not cacheline optimization target.
+	 * sub-page remainder. Such archs are not cacheline optimization targets.
 	 */
 	unsigned int nr_bytes[NR_OBJ_STOCK];
 #else
Signature · 2 lines
Cheers,
Harry / Hyeonggon