Skip to contentSkip to conversation

drm/imagination: make pvr_fw_trace_init_mask_ops static

PATCH Superseded Ben Dooks 2 participants 6 messages Jun 23 – Jul 6

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 drm/imagination: make pvr_fw_trace_init_mask_ops static

The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c so make it static to avoid the following sparse warning:

drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?

---
 drivers/gpu/drm/imagination/pvr_fw_trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/imagination/pvr_fw_trace.c +1 -1
index 6bb5baa6c41b..805d9f9bc1dd 100644
@@ -71,7 +71,7 @@ pvr_fw_trace_init_mask_set(const char *val, const struct kernel_param *kp)
 	return 0;
 }
 
-const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
+static const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
 	.set = pvr_fw_trace_init_mask_set,
 	.get = param_get_hexint,
 };
Signature · 1 line
2.37.2.352.g3c44437643
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Ben Dooks

The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c so make it static to avoid the following sparse warning:

drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?

Thanks,
Alessio

Quoted 17 lines
---
 drivers/gpu/drm/imagination/pvr_fw_trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/imagination/pvr_fw_trace.c +1 -1
index 6bb5baa6c41b..805d9f9bc1dd 100644
@@ -71,7 +71,7 @@ pvr_fw_trace_init_mask_set(const char *val, const struct kernel_param *kp)
 	return 0;
 }
 
-const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
+static const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
 	.set = pvr_fw_trace_init_mask_set,
 	.get = param_get_hexint,
 };
maintainer
#2 lore raw

Hi Ben,

Quoted 9 lines · Alessio Belle
Quoted 6 lines · Ben Dooks

The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c so make it static to avoid the following sparse warning:

drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?

Actually, could you add a Fixes tag pointing at c6978643ea1c ("drm/imagination:
Validate fw trace group_mask")? You can then add the Reviewed-by tag as well for last.

Thanks,
Alessio

Quoted 22 lines

Thanks,
Alessio

Quoted 17 lines
---
 drivers/gpu/drm/imagination/pvr_fw_trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/imagination/pvr_fw_trace.c +1 -1
index 6bb5baa6c41b..805d9f9bc1dd 100644
@@ -71,7 +71,7 @@ pvr_fw_trace_init_mask_set(const char *val, const struct kernel_param *kp)
 	return 0;
 }
 
-const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
+static const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
 	.set = pvr_fw_trace_init_mask_set,
 	.get = param_get_hexint,
 };
author
#3 lore raw
Quoted 11 lines · Alessio Belle

Hi Ben,

Quoted 8 lines · Alessio Belle
Quoted 6 lines · Ben Dooks

The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c so make it static to avoid the following sparse warning:

drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?

Quoted 8 lines
Quoted 1 line

Actually, could you add a Fixes tag pointing at c6978643ea1c ("drm/imagination:
Validate fw trace group_mask")? You can then add the Reviewed-by tag as well for last.

Thanks,
Alessio

ok, done

Signature · 4 lines
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html
author
#4 lore raw
In reply to Ben Dooks
Quoted 5 lines · Ben Dooks

The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c so make it static to avoid the following sparse warning:

drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?

FYI the [email protected] is reporting recipient failure.

Does this need changing or removing?

Signature · 4 lines
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html
maintainer
#5 lore raw

Hi Ben,

Quoted 11 lines · Ben Dooks
Quoted 5 lines · Ben Dooks

The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c so make it static to avoid the following sparse warning:

drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?

FYI the [email protected] is reporting recipient failure.

Does this need changing or removing?

Matt has (unfortunately for us) left Imagination very recently. Maintainers list and mailmap have been updated on drm-misc-next, so once those changes have propagated this should sort itself for new patch series at least.

Thanks,
Alessio