kernel: remove redundant static variable initializations
cover kernel: remove redundant static variable initializations
This series removes explicit initializations of static bool variables to false within the kernel/ subsystem. In C, static variables without explicit initialization are implicitly placed in the .bss section and initialized to zero/false by default. Removing these explicit initializations follows the Linux kernel coding style and avoids cluttering the data section.
Igor Putko (2):
kernel/workqueue: remove redundant initialization for static variables kernel/stop_machine: remove redundant initialization for
stop_machine_initialized
kernel/stop_machine.c | 2 +- kernel/workqueue.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.34.1
PATCH 1/2 kernel/workqueue: remove redundant initialization for static variables
The static variables 'wq_topo_initialized' and 'wq_debug_force_rr_cpu' are implicitly initialized to false. Remove the explicit initialization to follow the Linux kernel coding style.
--- kernel/workqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/workqueue.c +2 -2
@@ -445,7 +445,7 @@ static unsigned int wq_cache_shard_size = 8;module_param_named (cache_shard_size, wq_cache_shard_size, uint,0444 );static bool wq_online;/* can kworkers be created yet? */ -static bool wq_topo_initialized__read_mostly = false; +static bool wq_topo_initialized__read_mostly ;static struct kmem_cache *pwq_cache;
@@ -490,7 +490,7 @@ static DEFINE_PER_CPU(int, wq_rr_cpu_last);#ifdef CONFIG_DEBUG_WQ_FORCE_RR_CPU static bool wq_debug_force_rr_cpu = true;#else -static bool wq_debug_force_rr_cpu = false; +static bool wq_debug_force_rr_cpu;#endif module_param_named (debug_force_rr_cpu, wq_debug_force_rr_cpu, bool,0644 );
Signature · 1 line
2.34.1
PATCH 2/2 kernel/stop_machine: remove redundant initialization for stop_machine_initialized
In reply to Igor PutkoThe static variable 'stop_machine_initialized' is implicitly initialized to false. Remove the explicit initialization to follow the Linux kernel coding style.
--- kernel/stop_machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/stop_machine.c +1 -1
@@ -47,7 +47,7 @@ struct cpu_stopper { }; static DEFINE_PER_CPU(struct cpu_stopper, cpu_stopper); -static bool stop_machine_initialized = false; +static bool stop_machine_initialized;void print_stop_info (const char *log_lvl,struct task_struct *task) {
Signature · 1 line
2.34.1
Re: [PATCH 2/2] kernel/stop_machine: remove redundant initialization for stop_machine_initialized
Quoted 3 lines · Igor Putko
The static variable '
stop_machine_initialized' is implicitly initialized to false. Remove the explicit initialization to follow the Linux kernel coding style.
Please don't do whitespace patches. We can fix this whenever real changes are required.