Skip to contentSkip to conversation

dt-bindings: mediatek: cec: Correct the compatibles for mt7623-mt8167

PATCH In review Luca Leonardo Scorcia 2 participants 2 messages Jun 23 – Jun 24

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: mediatek: cec: Correct the compatibles for mt7623-mt8167

The HDMI CEC driver for both mt7623 and mt8167 is actually the same as mt8173-cec and the mt7623n.dtsi board include file already uses mt8173-cec compatible as a fallback, but the documentation lists them as separate entries. Correct the binding by adding the correct fallback.

This change fixes a dtbs_check error.

---
 .../bindings/display/mediatek/mediatek,cec.yaml       | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/display/mediatek/mediatek,cec.yaml +7 -4
index 080cf321209e..4d741ba415e8 100644
@@ -15,10 +15,13 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - mediatek,mt7623-cec
-      - mediatek,mt8167-cec
-      - mediatek,mt8173-cec
+    oneOf:
+      - const: mediatek,mt8173-cec
+      - items:
+        - enum:
+          - mediatek,mt7623-cec
+          - mediatek,mt8167-cec
+        - const: mediatek,mt8173-cec
 
   reg:
     maxItems: 1
Signature · 1 line
2.43.0
#1 lore raw
Quoted 6 lines · Luca Leonardo Scorcia

The HDMI CEC driver for both mt7623 and mt8167 is actually the same as mt8173-cec and the mt7623n.dtsi board include file already uses mt8173-cec compatible as a fallback, but the documentation lists them as separate entries. Correct the binding by adding the correct fallback.

This change fixes a dtbs_check error.

which one? here you paste it (can be trimmed a bit)

Quoted 12 lines
---
 .../bindings/display/mediatek/mediatek,cec.yaml       | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/display/mediatek/mediatek,cec.yaml +0 -0
index 080cf321209e..4d741ba415e8 100644
@@ -15,10 +15,13 @@ description: |
 

Documentation/devicetree/bindings/display/mediatek/mediatek,cec.yaml description: | · line 21

Quoted 10 lines
Documentation/devicetree/bindings/display/mediatek/mediatek,cec.yaml +4 -4
 properties:
   compatible:
-    enum:
-      - mediatek,mt7623-cec
-      - mediatek,mt8167-cec
-      - mediatek,mt8173-cec
+    oneOf:
+      - const: mediatek,mt8173-cec
+      - items:
+        - enum:

"This change fixes a dtbs_check error."
... and introduces new other errors, so error count stays the same. Not great.

It does not look like you tested the bindings, at least after quick look. Please run 'make dt_binding_check' (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Don't rely on distro packages for dtschema and be sure you are using the latest released dtschema.

Best regards,
Krzysztof