riscv: dts: spacemit: serial/i2c/ethernet improvements for the K3 Pico-ITX board
Subsystems (3)
v2 cover riscv: dts: spacemit: serial/i2c/ethernet improvements for the K3 Pico-ITX board
This patch series tries to improve the K3 Pico-ITX board DTS by configuring the default baud rate for the serial port, enabling the 24c02 eeprom on i2c2, adding aliases for i2c2 and i2c8 ports, and enabling power saving features on the RTL8211F PHY.
Changes in v2:
- Collect Reviewed-by tag
- Fix issues reported by Sashiko AI in patch 2
- Link to v1: https://lore.kernel.org/linux-riscv/[email protected]
Aurelien Jarno (5):
riscv: dts: spacemit: set console baud rate on K3 Pico-ITX board
riscv: dts: spacemit: enable the i2c2 adapter on K3 Pico-ITX board
riscv: dts: spacemit: add 24c02 eeprom on K3 Pico-ITX board
riscv: dts: spacemit: add i2c aliases on K3 Pico-ITX board
riscv: dts: spacemit: improve RTL8211F PHY configuration on K3
Pico-ITX board
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 42 +++++++++++++++++++- arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi | 11 +++++ 2 files changed, 52 insertions(+), 1 deletion(-)
Signature · 1 line
2.53.0
PATCH v2 1/5 riscv: dts: spacemit: set console baud rate on K3 Pico-ITX board
Because the default console's baud rate is not set, defconfig kernels do not have any serial output on this platform. Set the baud rate to 115200, matching what is used by U-Boot etc on this platform.
--- arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
v2:
- Collect Reviewed-by tag
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts +1 -1
@@ -18,7 +18,7 @@ aliases { }; chosen { - stdout-path = "serial0"; + stdout-path = "serial0:115200n8"; }; memory@100000000 {
Signature · 1 line
2.53.0
PATCH v2 2/5 riscv: dts: spacemit: enable the i2c2 adapter on K3 Pico-ITX board
In reply to Aurelien JarnoDefine I2C2 pinctrl properties, and enable it on the K3 Pico-ITX board. It will be used by the 24c02 eeprom.
--- arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 6 ++++++ arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi | 11 +++++++++++ 2 files changed, 17 insertions(+)
v2:
- Rename pinctrl subnode from i2c2-0-pins to i2c2-1-pins
- Add a missing space after bias-pull-up
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts +6 -0
@@ -43,6 +43,12 @@ reg_aux_vcc5v: regulator-aux-vcc5v { }; }; +&i2c2 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c2_1_cfg>; + status = "okay"; +}; + &i2c8 { pinctrl-names = "default"; pinctrl-0 = <&i2c8_cfg>;
arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi +11 -0
@@ -78,6 +78,17 @@ gmac1-phy-0-pins { }; }; + /omit-if-no-ref/ + i2c2_1_cfg: i2c2-1-cfg { + i2c2-1-pins { + pinmux = <K3_PADCONF(46, 5)>, /* i2c2 scl */ + <K3_PADCONF(47, 5)>; /* i2c2 sda */ + + bias-pull-up = <0>; + drive-strength = <25>; + }; + }; + /omit-if-no-ref/ i2c8_cfg: i2c8-cfg { i2c8-pins {
Signature · 1 line
2.53.0
PATCH v2 3/5 riscv: dts: spacemit: add 24c02 eeprom on K3 Pico-ITX board
In reply to Aurelien JarnoThe K3 Pico-ITX board includes a 24c02 eeprom, that stores the product name, the part name, the MAC address of the network interfaces and the board's serial number. These values are also exposed via an onie,tlv-layout nvmem layout.
The eeprom is marked as read-only since its contents are not supposed to be modified.
--- arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 30 ++++++++++++++++++++ 1 file changed, 30 insertions(+)
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts +30 -0
@@ -47,6 +47,36 @@ &i2c2 { pinctrl-names = "default"; pinctrl-0 = <&i2c2_1_cfg>; status = "okay"; + + eeprom@50 { + compatible = "atmel,24c02"; + reg = <0x50>; + pagesize = <8>; + read-only; + size = <256>; + status = "okay"; + + nvmem-layout { + compatible = "onie,tlv-layout"; + + mac-address { + #nvmem-cell-cells = <1>; + }; + + num-macs { + }; + + part-number { + }; + + product-name { + }; + + serial-number { + }; + + }; + }; }; &i2c8 {
Signature · 1 line
2.53.0
PATCH v2 4/5 riscv: dts: spacemit: add i2c aliases on K3 Pico-ITX board
In reply to Aurelien JarnoAdd i2c aliases for i2c2 and i2c8 on K3 Pico-ITX board. This is useful to keep a stable number for the /dev entries after loading the i2c-dev module.
--- arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 2 ++ 1 file changed, 2 insertions(+)
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts +2 -0
@@ -14,6 +14,8 @@ / { aliases { ethernet0 = ð0; + i2c2 = &i2c2; + i2c8 = &i2c8; serial0 = &uart0; };
Signature · 1 line
2.53.0
PATCH v2 5/5 riscv: dts: spacemit: improve RTL8211F PHY configuration on K3 Pico-ITX board
In reply to Aurelien JarnoVendor kernel enabled ALDPS (Advanced Link Down Power Saving) on the RTL8211F PHY to save power when link down.
Vendor kernel also disabled the 125MHz clkout clock signal, and indeed the schematics confirms that it only goes to a test point (TP14), so let's do the same.
--- arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 2 ++ 1 file changed, 2 insertions(+)
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts +2 -0
@@ -234,6 +234,8 @@ phy0: phy@1 { reset-gpios = <&gpio 0 15 GPIO_ACTIVE_LOW>; reset-assert-us = <10000>; reset-deassert-us = <10000>; + realtek,aldps-enable; + realtek,clkout-disable; }; }; };
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v2 5/5] riscv: dts: spacemit: improve RTL8211F PHY configuration on K3 Pico-ITX board
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Adding vendor-specific properties (`realtek,aldps-enable` and `realtek,clkout-disable`) to a PHY…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Adding vendor-specific properties (realtek,aldps-enable and realtek,clkout-disable) to a PHY node with a generic compatible string bypasses DT schema validation and perpetuates probing fragility. --
commit 06c0a01ebf26666aceea3d45a75bbed3025600af
Author: Aurelien Jarno <[email protected]>
riscv: dts: spacemit: improve RTL8211F PHY configuration on K3 Pico-ITX board
This commit enables ALDPS and disables the clkout signal on the RTL8211F PHY for the K3 Pico-ITX board to save power and match hardware schematics.
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts phy0: phy@1 { · line 230
Quoted 10 lines
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts +2
-0@@ -226,6 +226,8 @@ phy0: phy@1 { reset-gpios = <&gpio 0 15 GPIO_ACTIVE_LOW>; reset-assert-us = <10000>; reset-deassert-us = <10000>; + realtek,aldps-enable; + realtek,clkout-disable;
[Severity: Medium]
Will adding these vendor-specific properties without specifying a Realtek PHY ID in the compatible string bypass device tree schema validation?
The realtek,rtl82xx.yaml schema is only selected if a Realtek PHY ID is present. Since the phy0 node only specifies ethernet-phy-ieee802.3-c22, the validation tools will ignore the new Realtek-specific properties, meaning typos or invalid types could pass silently during dtbs_check.
Also, since this node uses reset-gpios, if the PHY is kept in reset by hardware or the bootloader, could the MDIO framework fail to read its ID and probe it unless the exact PHY ID is provided in the compatible string?
Would it be better to update the compatible string to include the specific PHY ID (such as ethernet-phy-id001c.c916) alongside the generic one to ensure proper schema validation and reliable probing?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5
Re: [PATCH v2 5/5] riscv: dts: spacemit: improve RTL8211F PHY configuration on K3 Pico-ITX board
In reply to Aurelien JarnoHi Aurelien,
Quoted 2 lines · Aurelien Jarno
Vendor kernel enabled ALDPS (Advanced Link Down Power Saving) on the RTL8211F PHY to save power when link down.
for ALDPS, tested here do noticed it will configure RTL8211F PHY's
RTL8211F_PHYCR1 register via rtl8211f_config_aldps()
And plug out then in the cable, the network(eth0) will come back and still works fine, although I have no power consumption meter to test, but I think
it deserves:
Quoted 26 lines
Vendor kernel also disabled the 125MHz clkout clock signal, and indeed the schematics confirms that it only goes to a test point (TP14), so let's do the same.
Signed-off-by Aurelien Jarno <[email protected]>--- arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 2 ++ 1 file changed, 2 insertions(+)arch/riscv/boot/dts/spacemit/k3-pico-itx.dts +2
-0@@ -234,6 +234,8 @@ phy0: phy@1 { reset-gpios = <&gpio 0 15 GPIO_ACTIVE_LOW>; reset-assert-us = <10000>; reset-deassert-us = <10000>; + realtek,aldps-enable; + realtek,clkout-disable; }; }; };Signature · 1 line
2.53.0
Signature · 1 line
Yixun Lan (dlan)
hi Aurelien,
Quoted 10 lines · Aurelien Jarno
This patch series tries to improve the K3 Pico-ITX board DTS by configuring the default baud rate for the serial port, enabling the 24c02 eeprom on i2c2, adding aliases for i2c2 and i2c8 ports, and enabling power saving features on the RTL8211F PHY.
Changes in v2:
- Collect Reviewed-by tag
- Fix issues reported by Sashiko AI in patch 2
- Link to v1: https://lore.kernel.org/linux-riscv/[email protected]
for the series, looks good, so
Quoted 16 lines
Aurelien Jarno (5):
riscv: dts: spacemit: set console baud rate on K3 Pico-ITX board
riscv: dts: spacemit: enable the i2c2 adapter on K3 Pico-ITX board
riscv: dts: spacemit: add 24c02 eeprom on K3 Pico-ITX board
riscv: dts: spacemit: add i2c aliases on K3 Pico-ITX board
riscv: dts: spacemit: improve RTL8211F PHY configuration on K3
Pico-ITX boardarch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 42 +++++++++++++++++++- arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi | 11 +++++ 2 files changed, 52 insertions(+), 1 deletion(-)Signature · 1 line
2.53.0
Signature · 1 line
Yixun Lan (dlan)
Quoted 11 lines · Aurelien Jarno
This patch series tries to improve the K3 Pico-ITX board DTS by configuring the default baud rate for the serial port, enabling the 24c02 eeprom on i2c2, adding aliases for i2c2 and i2c8 ports, and enabling power saving features on the RTL8211F PHY.
Changes in v2:
- Collect Reviewed-by tag
- Fix issues reported by Sashiko AI in patch 2
- Link to v1: https://lore.kernel.org/linux-riscv/[email protected][...]
Applied, thanks!
[1/5] riscv: dts: spacemit: set console baud rate on K3 Pico-ITX board
https://git.kernel.org/pub/scm/linux/kernel/git/spacemit/linux.git/commit/?id=84a9b686f24490e9340961c913072df7fc9518a1 [2/5] riscv: dts: spacemit: enable the i2c2 adapter on K3 Pico-ITX board https://git.kernel.org/pub/scm/linux/kernel/git/spacemit/linux.git/commit/?id=e08ab32f61b1fc7c35253b708f3840530a2c13cc [3/5] riscv: dts: spacemit: add 24c02 eeprom on K3 Pico-ITX board https://git.kernel.org/pub/scm/linux/kernel/git/spacemit/linux.git/commit/?id=6e59ab1a2b4539cda3677d4927a08609be28de6c [4/5] riscv: dts: spacemit: add i2c aliases on K3 Pico-ITX board https://git.kernel.org/pub/scm/linux/kernel/git/spacemit/linux.git/commit/?id=ca259920d5551b0c68e5dc188a2f0118baa151ec [5/5] riscv: dts: spacemit: improve RTL8211F PHY configuration on K3 Pico-ITX board https://git.kernel.org/pub/scm/linux/kernel/git/spacemit/linux.git/commit/?id=ccbfb13d278abbde13e544316e961d3ab03a77c8
Best regards,
Signature · 1 line
Yixun Lan <[email protected]>