Skip to contentSkip to conversation

drm/amd/pm: drop unused smu pptable callbacks

PATCH In review Yang Wang 3 participants 3 messages Jun 24

Subsystems (3)
lore
Share & tools
lore

Yang Wang

author
#0 lore raw

PATCH 1/1 drm/amd/pm: drop unused smu pptable callbacks

struct pptable_funcs still carries callback slots that no longer have call paths, drop the following unused callback slots:

- baco_get_state()
- baco_set_state()
- set_power_state()
- get_clock_by_type_with_voltage()
- set_azalia_d3_pme()

---
 drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 29 -------------------
 drivers/gpu/drm/amd/pm/swsmu/inc/smu_v11_0.h  |  2 --
 drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h  |  2 --
 .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c |  1 -
 .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c   |  1 -
 .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c   |  1 -
 .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c    |  5 ----
 .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c   |  1 -
 .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c    |  1 -
 .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c    |  9 ------
 .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c  |  2 --
 11 files changed, 54 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h +0 -29
index d76e0b005308..38a8249570a9 100644
@@ -849,8 +849,6 @@ struct pptable_funcs {
 	 */
 	int (*set_default_dpm_table)(struct smu_context *smu);
 
-	int (*set_power_state)(struct smu_context *smu);
-
 	/**
 	 * @populate_umd_state_clk: Populate the UMD power state table with
 	 *                          defaults.
@@ -903,16 +901,6 @@ struct pptable_funcs {
 					      struct
 					      pp_clock_levels_with_latency
 					      *clocks);
-	/**
-	 * @get_clock_by_type_with_voltage: Get the speed and voltage of a clock
-	 *                                  domain.
-	 */
-	int (*get_clock_by_type_with_voltage)(struct smu_context *smu,
-					      enum amd_pp_clock_type type,
-					      struct
-					      pp_clock_levels_with_voltage
-					      *clocks);
-
 	/**
 	 * @get_power_profile_mode: Print all power profile modes to
 	 *                          buffer. Star current mode.
@@ -1354,11 +1342,6 @@ struct pptable_funcs {
 	 */
 	int (*register_irq_handler)(struct smu_context *smu);
 
-	/**
-	 * @set_azalia_d3_pme: Wake the audio decode engine from d3 sleep.
-	 */
-	int (*set_azalia_d3_pme)(struct smu_context *smu);
-
 	/**
 	 * @get_max_sustainable_clocks_by_dc: Get a copy of the max sustainable
 	 *                                    clock speeds table.
@@ -1375,18 +1358,6 @@ struct pptable_funcs {
 	 */
 	int (*get_bamaco_support)(struct smu_context *smu);
 
-	/**
-	 * @baco_get_state: Get the current BACO state.
-	 *
-	 * Return: Current BACO state.
-	 */
-	enum smu_baco_state (*baco_get_state)(struct smu_context *smu);
-
-	/**
-	 * @baco_set_state: Enter/exit BACO.
-	 */
-	int (*baco_set_state)(struct smu_context *smu, enum smu_baco_state state);
-
 	/**
 	 * @baco_enter: Enter BACO.
 	 */
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v11_0.h +0 -2
index dd94e8a9e218..c0accee9a9c8 100644
@@ -199,8 +199,6 @@ int smu_v11_0_gfx_off_control(struct smu_context *smu, bool enable);
 
 int smu_v11_0_register_irq_handler(struct smu_context *smu);
 
-int smu_v11_0_set_azalia_d3_pme(struct smu_context *smu);
-
 int smu_v11_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu,
 		struct pp_smu_nv_clock_table *max_clocks);
 
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h +0 -2
index 68f4de5f800c..7f21f867d73c 100644
@@ -180,8 +180,6 @@ int smu_v13_0_gfx_off_control(struct smu_context *smu, bool enable);
 
 int smu_v13_0_register_irq_handler(struct smu_context *smu);
 
-int smu_v13_0_set_azalia_d3_pme(struct smu_context *smu);
-
 int smu_v13_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu,
 					       struct pp_smu_nv_clock_table *max_clocks);
 
drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c +0 -1
index 051a0008aa10..99abfddff856 100644
@@ -1934,7 +1934,6 @@ static const struct pptable_funcs arcturus_ppt_funcs = {
 	.set_xgmi_pstate = smu_v11_0_set_xgmi_pstate,
 	.gfx_off_control = smu_v11_0_gfx_off_control,
 	.register_irq_handler = smu_v11_0_register_irq_handler,
-	.set_azalia_d3_pme = smu_v11_0_set_azalia_d3_pme,
 	.get_max_sustainable_clocks_by_dc = smu_v11_0_get_max_sustainable_clocks_by_dc,
 	.get_bamaco_support = smu_v11_0_get_bamaco_support,
 	.baco_enter = smu_v11_0_baco_enter,
drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c +0 -1
index 2f2a5953dbbc..52c23bd3b201 100644
@@ -3340,7 +3340,6 @@ static const struct pptable_funcs navi10_ppt_funcs = {
 	.set_xgmi_pstate = smu_v11_0_set_xgmi_pstate,
 	.gfx_off_control = smu_v11_0_gfx_off_control,
 	.register_irq_handler = smu_v11_0_register_irq_handler,
-	.set_azalia_d3_pme = smu_v11_0_set_azalia_d3_pme,
 	.get_max_sustainable_clocks_by_dc = smu_v11_0_get_max_sustainable_clocks_by_dc,
 	.get_bamaco_support = smu_v11_0_get_bamaco_support,
 	.baco_enter = navi10_baco_enter,
drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c +0 -1
index 70897c70db32..e5370267fda3 100644
@@ -3146,7 +3146,6 @@ static const struct pptable_funcs sienna_cichlid_ppt_funcs = {
 	.set_xgmi_pstate = smu_v11_0_set_xgmi_pstate,
 	.gfx_off_control = smu_v11_0_gfx_off_control,
 	.register_irq_handler = smu_v11_0_register_irq_handler,
-	.set_azalia_d3_pme = smu_v11_0_set_azalia_d3_pme,
 	.get_max_sustainable_clocks_by_dc = smu_v11_0_get_max_sustainable_clocks_by_dc,
 	.get_bamaco_support = smu_v11_0_get_bamaco_support,
 	.baco_enter = sienna_cichlid_baco_enter,
drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c +0 -5
index ac8f84f1e30e..f5155a4dc5a2 100644
@@ -1417,11 +1417,6 @@ int smu_v11_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu,
 	return 0;
 }
 
-int smu_v11_0_set_azalia_d3_pme(struct smu_context *smu)
-{
-	return smu_cmn_send_smc_msg(smu, SMU_MSG_BacoAudioD3PME, NULL);
-}
-
 int smu_v11_0_baco_set_armd3_sequence(struct smu_context *smu,
 				      enum smu_baco_seq baco_seq)
 {
drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c +0 -1
index 0349dba2503a..e5d319cda52b 100644
@@ -1444,7 +1444,6 @@ static int renoir_get_enabled_mask(struct smu_context *smu,
 }
 
 static const struct pptable_funcs renoir_ppt_funcs = {
-	.set_power_state = NULL,
 	.emit_clk_levels = renoir_emit_clk_levels,
 	.get_current_power_state = renoir_get_current_power_state,
 	.dpm_set_vcn_enable = renoir_dpm_set_vcn_enable,
drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c +0 -1
index 3a19f0ffcf3c..7c0d4e40b9b6 100644
@@ -2005,7 +2005,6 @@ static const struct pptable_funcs aldebaran_ppt_funcs = {
 	.disable_thermal_alert = smu_v13_0_disable_thermal_alert,
 	.set_xgmi_pstate = smu_v13_0_set_xgmi_pstate,
 	.register_irq_handler = smu_v13_0_register_irq_handler,
-	.set_azalia_d3_pme = smu_v13_0_set_azalia_d3_pme,
 	.get_max_sustainable_clocks_by_dc = smu_v13_0_get_max_sustainable_clocks_by_dc,
 	.get_bamaco_support = aldebaran_get_bamaco_support,
 	.get_dpm_ultimate_freq = aldebaran_get_dpm_ultimate_freq,
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c +0 -9
index d511f03354a6..67d20213ad07 100644
@@ -1321,15 +1321,6 @@ int smu_v13_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu,
 	return 0;
 }
 
-int smu_v13_0_set_azalia_d3_pme(struct smu_context *smu)
-{
-	int ret = 0;
-
-	ret = smu_cmn_send_smc_msg(smu, SMU_MSG_BacoAudioD3PME, NULL);
-
-	return ret;
-}
-
 static int smu_v13_0_wait_for_reset_complete(struct smu_context *smu,
 					     uint64_t event_arg)
 {
drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c +0 -2
index 9c09b2640a0c..edc5140f6ab6 100644
@@ -2891,8 +2891,6 @@ static const struct pptable_funcs smu_v14_0_2_ppt_funcs = {
 	.deep_sleep_control = smu_v14_0_deep_sleep_control,
 	.gfx_ulv_control = smu_v14_0_gfx_ulv_control,
 	.get_bamaco_support = smu_v14_0_get_bamaco_support,
-	.baco_get_state = smu_v14_0_baco_get_state,
-	.baco_set_state = smu_v14_0_baco_set_state,
 	.baco_enter = smu_v14_0_2_baco_enter,
 	.baco_exit = smu_v14_0_2_baco_exit,
 	.mode1_reset_is_support = smu_v14_0_2_is_mode1_reset_supported,
Signature · 1 line
2.47.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Yang Wang

struct pptable_funcs still carries callback slots that no longer have call paths, drop the following unused callback slots:

- baco_get_state()
- baco_set_state()
- set_power_state()
- get_clock_by_type_with_voltage()
- set_azalia_d3_pme()

Thanks,
Lijo

Quoted 210 lines
---
  drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 29 -------------------
  drivers/gpu/drm/amd/pm/swsmu/inc/smu_v11_0.h  |  2 --
  drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h  |  2 --
  .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c |  1 -
  .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c   |  1 -
  .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c   |  1 -
  .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c    |  5 ----
  .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c   |  1 -
  .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c    |  1 -
  .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c    |  9 ------
  .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c  |  2 --
  11 files changed, 54 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h +0 -29
index d76e0b005308..38a8249570a9 100644
@@ -849,8 +849,6 @@ struct pptable_funcs {
  	 */
  	int (*set_default_dpm_table)(struct smu_context *smu);
 
-	int (*set_power_state)(struct smu_context *smu);
-
  	/**
  	 * @populate_umd_state_clk: Populate the UMD power state table with
  	 *                          defaults.
@@ -903,16 +901,6 @@ struct pptable_funcs {
  					      struct
  					      pp_clock_levels_with_latency
  					      *clocks);
-	/**
-	 * @get_clock_by_type_with_voltage: Get the speed and voltage of a clock
-	 *                                  domain.
-	 */
-	int (*get_clock_by_type_with_voltage)(struct smu_context *smu,
-					      enum amd_pp_clock_type type,
-					      struct
-					      pp_clock_levels_with_voltage
-					      *clocks);
-
  	/**
  	 * @get_power_profile_mode: Print all power profile modes to
  	 *                          buffer. Star current mode.
@@ -1354,11 +1342,6 @@ struct pptable_funcs {
  	 */
  	int (*register_irq_handler)(struct smu_context *smu);
 
-	/**
-	 * @set_azalia_d3_pme: Wake the audio decode engine from d3 sleep.
-	 */
-	int (*set_azalia_d3_pme)(struct smu_context *smu);
-
  	/**
  	 * @get_max_sustainable_clocks_by_dc: Get a copy of the max sustainable
  	 *                                    clock speeds table.
@@ -1375,18 +1358,6 @@ struct pptable_funcs {
  	 */
  	int (*get_bamaco_support)(struct smu_context *smu);
 
-	/**
-	 * @baco_get_state: Get the current BACO state.
-	 *
-	 * Return: Current BACO state.
-	 */
-	enum smu_baco_state (*baco_get_state)(struct smu_context *smu);
-
-	/**
-	 * @baco_set_state: Enter/exit BACO.
-	 */
-	int (*baco_set_state)(struct smu_context *smu, enum smu_baco_state state);
-
  	/**
  	 * @baco_enter: Enter BACO.
  	 */
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v11_0.h +0 -2
index dd94e8a9e218..c0accee9a9c8 100644
@@ -199,8 +199,6 @@ int smu_v11_0_gfx_off_control(struct smu_context *smu, bool enable);
 
  int smu_v11_0_register_irq_handler(struct smu_context *smu);
 
-int smu_v11_0_set_azalia_d3_pme(struct smu_context *smu);
-
  int smu_v11_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu,
  		struct pp_smu_nv_clock_table *max_clocks);
 
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h +0 -2
index 68f4de5f800c..7f21f867d73c 100644
@@ -180,8 +180,6 @@ int smu_v13_0_gfx_off_control(struct smu_context *smu, bool enable);
 
  int smu_v13_0_register_irq_handler(struct smu_context *smu);
 
-int smu_v13_0_set_azalia_d3_pme(struct smu_context *smu);
-
  int smu_v13_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu,
  					       struct pp_smu_nv_clock_table *max_clocks);
 
drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c +0 -1
index 051a0008aa10..99abfddff856 100644
@@ -1934,7 +1934,6 @@ static const struct pptable_funcs arcturus_ppt_funcs = {
  	.set_xgmi_pstate = smu_v11_0_set_xgmi_pstate,
  	.gfx_off_control = smu_v11_0_gfx_off_control,
  	.register_irq_handler = smu_v11_0_register_irq_handler,
-	.set_azalia_d3_pme = smu_v11_0_set_azalia_d3_pme,
  	.get_max_sustainable_clocks_by_dc = smu_v11_0_get_max_sustainable_clocks_by_dc,
  	.get_bamaco_support = smu_v11_0_get_bamaco_support,
  	.baco_enter = smu_v11_0_baco_enter,
drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c +0 -1
index 2f2a5953dbbc..52c23bd3b201 100644
@@ -3340,7 +3340,6 @@ static const struct pptable_funcs navi10_ppt_funcs = {
  	.set_xgmi_pstate = smu_v11_0_set_xgmi_pstate,
  	.gfx_off_control = smu_v11_0_gfx_off_control,
  	.register_irq_handler = smu_v11_0_register_irq_handler,
-	.set_azalia_d3_pme = smu_v11_0_set_azalia_d3_pme,
  	.get_max_sustainable_clocks_by_dc = smu_v11_0_get_max_sustainable_clocks_by_dc,
  	.get_bamaco_support = smu_v11_0_get_bamaco_support,
  	.baco_enter = navi10_baco_enter,
drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c +0 -1
index 70897c70db32..e5370267fda3 100644
@@ -3146,7 +3146,6 @@ static const struct pptable_funcs sienna_cichlid_ppt_funcs = {
  	.set_xgmi_pstate = smu_v11_0_set_xgmi_pstate,
  	.gfx_off_control = smu_v11_0_gfx_off_control,
  	.register_irq_handler = smu_v11_0_register_irq_handler,
-	.set_azalia_d3_pme = smu_v11_0_set_azalia_d3_pme,
  	.get_max_sustainable_clocks_by_dc = smu_v11_0_get_max_sustainable_clocks_by_dc,
  	.get_bamaco_support = smu_v11_0_get_bamaco_support,
  	.baco_enter = sienna_cichlid_baco_enter,
drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c +0 -5
index ac8f84f1e30e..f5155a4dc5a2 100644
@@ -1417,11 +1417,6 @@ int smu_v11_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu,
  	return 0;
  }
 
-int smu_v11_0_set_azalia_d3_pme(struct smu_context *smu)
-{
-	return smu_cmn_send_smc_msg(smu, SMU_MSG_BacoAudioD3PME, NULL);
-}
-
  int smu_v11_0_baco_set_armd3_sequence(struct smu_context *smu,
  				      enum smu_baco_seq baco_seq)
  {
drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c +0 -1
index 0349dba2503a..e5d319cda52b 100644
@@ -1444,7 +1444,6 @@ static int renoir_get_enabled_mask(struct smu_context *smu,
  }
 
  static const struct pptable_funcs renoir_ppt_funcs = {
-	.set_power_state = NULL,
  	.emit_clk_levels = renoir_emit_clk_levels,
  	.get_current_power_state = renoir_get_current_power_state,
  	.dpm_set_vcn_enable = renoir_dpm_set_vcn_enable,
drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c +0 -1
index 3a19f0ffcf3c..7c0d4e40b9b6 100644
@@ -2005,7 +2005,6 @@ static const struct pptable_funcs aldebaran_ppt_funcs = {
  	.disable_thermal_alert = smu_v13_0_disable_thermal_alert,
  	.set_xgmi_pstate = smu_v13_0_set_xgmi_pstate,
  	.register_irq_handler = smu_v13_0_register_irq_handler,
-	.set_azalia_d3_pme = smu_v13_0_set_azalia_d3_pme,
  	.get_max_sustainable_clocks_by_dc = smu_v13_0_get_max_sustainable_clocks_by_dc,
  	.get_bamaco_support = aldebaran_get_bamaco_support,
  	.get_dpm_ultimate_freq = aldebaran_get_dpm_ultimate_freq,
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c +0 -9
index d511f03354a6..67d20213ad07 100644
@@ -1321,15 +1321,6 @@ int smu_v13_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu,
  	return 0;
  }
 
-int smu_v13_0_set_azalia_d3_pme(struct smu_context *smu)
-{
-	int ret = 0;
-
-	ret = smu_cmn_send_smc_msg(smu, SMU_MSG_BacoAudioD3PME, NULL);
-
-	return ret;
-}
-
  static int smu_v13_0_wait_for_reset_complete(struct smu_context *smu,
  					     uint64_t event_arg)
  {
drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c +0 -2
index 9c09b2640a0c..edc5140f6ab6 100644
@@ -2891,8 +2891,6 @@ static const struct pptable_funcs smu_v14_0_2_ppt_funcs = {
  	.deep_sleep_control = smu_v14_0_deep_sleep_control,
  	.gfx_ulv_control = smu_v14_0_gfx_ulv_control,
  	.get_bamaco_support = smu_v14_0_get_bamaco_support,
-	.baco_get_state = smu_v14_0_baco_get_state,
-	.baco_set_state = smu_v14_0_baco_set_state,
  	.baco_enter = smu_v14_0_2_baco_enter,
  	.baco_exit = smu_v14_0_2_baco_exit,
  	.mode1_reset_is_support = smu_v14_0_2_is_mode1_reset_supported,
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Yang Wang

AMD General

-----Original Message-----
From: Wang, Yang(Kevin) <[email protected]>
Sent: Wednesday, June 24, 2026 2:07 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Zhang, Hawking <[email protected]>; Feng, Kenneth <[email protected]>
Subject: [PATCH] drm/amd/pm: drop unused smu pptable callbacks

struct pptable_funcs still carries callback slots that no longer have call paths, drop the following unused callback slots:

- baco_get_state()
- baco_set_state()
- set_power_state()
- get_clock_by_type_with_voltage()
- set_azalia_d3_pme()

---
 drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 29 -------------------  drivers/gpu/drm/amd/pm/swsmu/inc/smu_v11_0.h  |  2 --  drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h  |  2 --  .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c |  1 -
 .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c   |  1 -
 .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c   |  1 -
 .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c    |  5 ----
 .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c   |  1 -
 .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c    |  1 -
 .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c    |  9 ------
 .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c  |  2 --
 11 files changed, 54 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h +0 -29
index d76e0b005308..38a8249570a9 100644
@@ -849,8 +849,6 @@ struct pptable_funcs {
         */
        int (*set_default_dpm_table)(struct smu_context *smu);
 
-       int (*set_power_state)(struct smu_context *smu);
-
        /**
         * @populate_umd_state_clk: Populate the UMD power state table with
         *                          defaults.
@@ -903,16 +901,6 @@ struct pptable_funcs {
                                              struct
                                              pp_clock_levels_with_latency
                                              *clocks);
-       /**
-        * @get_clock_by_type_with_voltage: Get the speed and voltage of a clock
-        *                                  domain.
-        */
-       int (*get_clock_by_type_with_voltage)(struct smu_context *smu,
-                                             enum amd_pp_clock_type type,
-                                             struct
-                                             pp_clock_levels_with_voltage
-                                             *clocks);
-
        /**
         * @get_power_profile_mode: Print all power profile modes to
         *                          buffer. Star current mode.
@@ -1354,11 +1342,6 @@ struct pptable_funcs {
         */
        int (*register_irq_handler)(struct smu_context *smu);
 
-       /**
-        * @set_azalia_d3_pme: Wake the audio decode engine from d3 sleep.
-        */
-       int (*set_azalia_d3_pme)(struct smu_context *smu);
-
        /**
         * @get_max_sustainable_clocks_by_dc: Get a copy of the max sustainable
         *                                    clock speeds table.
@@ -1375,18 +1358,6 @@ struct pptable_funcs {
         */
        int (*get_bamaco_support)(struct smu_context *smu);
 
-       /**
-        * @baco_get_state: Get the current BACO state.
-        *
-        * Return: Current BACO state.
-        */
-       enum smu_baco_state (*baco_get_state)(struct smu_context *smu);
-
-       /**
-        * @baco_set_state: Enter/exit BACO.
-        */
-       int (*baco_set_state)(struct smu_context *smu, enum smu_baco_state state);
-
        /**
         * @baco_enter: Enter BACO.
         */
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v11_0.h +0 -2
index dd94e8a9e218..c0accee9a9c8 100644
@@ -199,8 +199,6 @@ int smu_v11_0_gfx_off_control(struct smu_context *smu, bool enable);
 
 int smu_v11_0_register_irq_handler(struct smu_context *smu);
 
-int smu_v11_0_set_azalia_d3_pme(struct smu_context *smu);
-
 int smu_v11_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu,
                struct pp_smu_nv_clock_table *max_clocks);
 
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h +0 -2
index 68f4de5f800c..7f21f867d73c 100644
@@ -180,8 +180,6 @@ int smu_v13_0_gfx_off_control(struct smu_context *smu, bool enable);
 
 int smu_v13_0_register_irq_handler(struct smu_context *smu);
 
-int smu_v13_0_set_azalia_d3_pme(struct smu_context *smu);
-
 int smu_v13_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu,
                                               struct pp_smu_nv_clock_table *max_clocks);
 
drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c +0 -1
index 051a0008aa10..99abfddff856 100644
@@ -1934,7 +1934,6 @@ static const struct pptable_funcs arcturus_ppt_funcs = {
        .set_xgmi_pstate = smu_v11_0_set_xgmi_pstate,
        .gfx_off_control = smu_v11_0_gfx_off_control,
        .register_irq_handler = smu_v11_0_register_irq_handler,
-       .set_azalia_d3_pme = smu_v11_0_set_azalia_d3_pme,
        .get_max_sustainable_clocks_by_dc = smu_v11_0_get_max_sustainable_clocks_by_dc,
        .get_bamaco_support = smu_v11_0_get_bamaco_support,
        .baco_enter = smu_v11_0_baco_enter,
drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c +0 -1
index 2f2a5953dbbc..52c23bd3b201 100644
@@ -3340,7 +3340,6 @@ static const struct pptable_funcs navi10_ppt_funcs = {
        .set_xgmi_pstate = smu_v11_0_set_xgmi_pstate,
        .gfx_off_control = smu_v11_0_gfx_off_control,
        .register_irq_handler = smu_v11_0_register_irq_handler,
-       .set_azalia_d3_pme = smu_v11_0_set_azalia_d3_pme,
        .get_max_sustainable_clocks_by_dc = smu_v11_0_get_max_sustainable_clocks_by_dc,
        .get_bamaco_support = smu_v11_0_get_bamaco_support,
        .baco_enter = navi10_baco_enter,
drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c +0 -1
index 70897c70db32..e5370267fda3 100644
@@ -3146,7 +3146,6 @@ static const struct pptable_funcs sienna_cichlid_ppt_funcs = {
        .set_xgmi_pstate = smu_v11_0_set_xgmi_pstate,
        .gfx_off_control = smu_v11_0_gfx_off_control,
        .register_irq_handler = smu_v11_0_register_irq_handler,
-       .set_azalia_d3_pme = smu_v11_0_set_azalia_d3_pme,
        .get_max_sustainable_clocks_by_dc = smu_v11_0_get_max_sustainable_clocks_by_dc,
        .get_bamaco_support = smu_v11_0_get_bamaco_support,
        .baco_enter = sienna_cichlid_baco_enter, diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c

index ac8f84f1e30e..f5155a4dc5a2 100644

drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c +0 -4
@@ -1417,11 +1417,6 @@ int smu_v11_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu,
        return 0;
 }
 
-int smu_v11_0_set_azalia_d3_pme(struct smu_context *smu) -{
-       return smu_cmn_send_smc_msg(smu, SMU_MSG_BacoAudioD3PME, NULL);
-}
-
 int smu_v11_0_baco_set_armd3_sequence(struct smu_context *smu,
                                      enum smu_baco_seq baco_seq)
 {
drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c +0 -1
index 0349dba2503a..e5d319cda52b 100644
@@ -1444,7 +1444,6 @@ static int renoir_get_enabled_mask(struct smu_context *smu,  }
 
 static const struct pptable_funcs renoir_ppt_funcs = {
-       .set_power_state = NULL,
        .emit_clk_levels = renoir_emit_clk_levels,
        .get_current_power_state = renoir_get_current_power_state,
        .dpm_set_vcn_enable = renoir_dpm_set_vcn_enable, diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c

index 3a19f0ffcf3c..7c0d4e40b9b6 100644

drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c +0 -1
@@ -2005,7 +2005,6 @@ static const struct pptable_funcs aldebaran_ppt_funcs = {
        .disable_thermal_alert = smu_v13_0_disable_thermal_alert,
        .set_xgmi_pstate = smu_v13_0_set_xgmi_pstate,
        .register_irq_handler = smu_v13_0_register_irq_handler,
-       .set_azalia_d3_pme = smu_v13_0_set_azalia_d3_pme,
        .get_max_sustainable_clocks_by_dc = smu_v13_0_get_max_sustainable_clocks_by_dc,
        .get_bamaco_support = aldebaran_get_bamaco_support,
        .get_dpm_ultimate_freq = aldebaran_get_dpm_ultimate_freq, diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c

index d511f03354a6..67d20213ad07 100644

drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c +0 -8
@@ -1321,15 +1321,6 @@ int smu_v13_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu,
        return 0;
 }
 
-int smu_v13_0_set_azalia_d3_pme(struct smu_context *smu) -{
-       int ret = 0;
-
-       ret = smu_cmn_send_smc_msg(smu, SMU_MSG_BacoAudioD3PME, NULL);
-
-       return ret;
-}
-
 static int smu_v13_0_wait_for_reset_complete(struct smu_context *smu,
                                             uint64_t event_arg)
 {
drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c +0 -2
index 9c09b2640a0c..edc5140f6ab6 100644
@@ -2891,8 +2891,6 @@ static const struct pptable_funcs smu_v14_0_2_ppt_funcs = {
        .deep_sleep_control = smu_v14_0_deep_sleep_control,
        .gfx_ulv_control = smu_v14_0_gfx_ulv_control,
        .get_bamaco_support = smu_v14_0_get_bamaco_support,
-       .baco_get_state = smu_v14_0_baco_get_state,
-       .baco_set_state = smu_v14_0_baco_set_state,
        .baco_enter = smu_v14_0_2_baco_enter,
        .baco_exit = smu_v14_0_2_baco_exit,
        .mode1_reset_is_support = smu_v14_0_2_is_mode1_reset_supported,

--
2.47.3