Skip to contentSkip to conversation

checkpatches: suppress warnings about msleep()

PATCH Applied Stephen Hemminger 2 participants 2 messages Jun 24 – Jul 12

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 checkpatches: suppress warnings about msleep()

The DPDK checkpatch uses the underlying kernel tool which does some checks that are only relevant in kernel code. The warning about msleep() time only makes sense in the kernel.

Suppress feedback like:

WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see function description of msleep().
+ msleep(10);

---
 devtools/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
devtools/checkpatches.sh +1 -1
index f5dd77443f..071bdb2c15 100755
@@ -34,7 +34,7 @@ PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\
 SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
 LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
 NEW_TYPEDEFS,COMPARISON_TO_NULL,AVOID_BUG,EXPORT_SYMBOL,\
-BAD_REPORTED_BY_LINK"
+BAD_REPORTED_BY_LINK,MSLEEP"
 options="$options $DPDK_CHECKPATCH_OPTIONS"
 
 print_usage () {
Signature · 1 line
2.53.0
#1 lore raw

24/06/2026 18:25, Stephen Hemminger:

Quoted 11 lines

The DPDK checkpatch uses the underlying kernel tool which does some checks that are only relevant in kernel code. The warning about msleep() time only makes sense in the kernel.

Suppress feedback like:

WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see function description of msleep().

(quoted diff) +1 -0
+		msleep(10);

Applied, thanks.