Skip to contentSkip to conversation

staging: rtl8723bs: clean up code style in hal_intf.c

PATCH In review André Moreira 1 participant 2 messages Jun 24 Staging

lore
Share & tools
lore

André Moreira

author
#0 lore raw

PATCH 1/1 staging: rtl8723bs: clean up code style in hal_intf.c

Fix coding style issues regarding unneeded parentheses, Yoda conditions, and unnecessary braces for single-statement blocks. Also improve variable initialization.

Signed-off-by André Moreira <[email protected]>
---
 drivers/staging/rtl8723bs/hal/hal_intf.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/hal/hal_intf.c +3 -2
index 228297cee5d6e..496f18d40c5e3 100644
@@ -184,8 +184,9 @@ u32 rtw_hal_read_bbreg(struct adapter *padapter, u32 RegAddr, u32 BitMask)
 {
 	return PHY_QueryBBReg_8723B(padapter, RegAddr, BitMask);
 }
-void rtw_hal_write_bbreg(struct adapter *padapter, u32 RegAddr,
-			u32 BitMask, u32 Data)
+
+void rtw_hal_write_bbreg(struct adapter *padapter,
+			u32 RegAddr, u32 BitMask, u32 Data)
 {
 	PHY_SetBBReg_8723B(padapter, RegAddr, BitMask, Data);
 }
Signature · 1 line
2.43.0
author
#1 lore raw

Please ignore this patch. I accidentally missed several changes in this submission and sent an incomplete version.

Em qua., 24 de jun. de 2026 às 18:58, André Moreira <[email protected]> escreveu:

Quoted 29 lines

Fix coding style issues regarding unneeded parentheses, Yoda conditions, and unnecessary braces for single-statement blocks. Also improve variable initialization.

Signed-off-by André Moreira <[email protected]>
---
 drivers/staging/rtl8723bs/hal/hal_intf.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/hal/hal_intf.c +3 -3
index 228297cee5d6e..496f18d40c5e3 100644
@@ -184,8 +184,9 @@ u32 rtw_hal_read_bbreg(struct adapter *padapter, u32 RegAddr, u32 BitMask)
 {
        return PHY_QueryBBReg_8723B(padapter, RegAddr, BitMask);
 }
-void rtw_hal_write_bbreg(struct adapter *padapter, u32 RegAddr,
-                       u32 BitMask, u32 Data)
+
+void rtw_hal_write_bbreg(struct adapter *padapter,
+                       u32 RegAddr, u32 BitMask, u32 Data)
 {
        PHY_SetBBReg_8723B(padapter, RegAddr, BitMask, Data);
 }
--

2.43.0