Skip to contentSkip to conversation

dt-bindings: dma: xlnx,axi-dma: Restore xlnx,flush-fsync as u32

PATCH Applied Suraj Gupta 3 participants 3 messages Jun 25 – Jul 2

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: dma: xlnx,axi-dma: Restore xlnx,flush-fsync as u32

The DT schema conversion incorrectly changed xlnx,flush-fsync from a u32 property to a boolean. The original binding documented values 1, 2, and 3 to select which VDMA channel(s) flush on frame sync.
Restore the uint32 type with the documented enum values and fix the example accordingly.

Fixes 2d5c2952b972 ("dt-bindings: dma: xlnx,axi-dma: Convert to DT schema")

---

 Documentation/devicetree/bindings/dma/xilinx/xlnx,axi-dma.yaml | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/dma/xilinx/xlnx,axi-dma.yaml +8 -3
index 340ae9e91cb0..95b951eea1b7 100644
@@ -81,8 +81,13 @@ properties:
     description: Should be the number of framebuffers as configured in h/w.
 
   xlnx,flush-fsync:
-    type: boolean
-    description: Tells which channel to Flush on Frame sync.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum: [1, 2, 3]
+    description:
+      Tells which channel to flush on frame sync.
+      1 - flush both channels
+      2 - flush mm2s channel
+      3 - flush s2mm channel
 
   xlnx,sg-length-width:
     $ref: /schemas/types.yaml#/definitions/uint32
@@ -251,7 +256,7 @@ examples:
                       "m_axi_s2mm_aclk", "m_axis_mm2s_aclk",
                       "s_axis_s2mm_aclk";
         xlnx,num-fstores = <8>;
-        xlnx,flush-fsync;
+        xlnx,flush-fsync = <1>;
         xlnx,addrwidth = <32>;
 
         dma-channel-mm2s {
Signature · 1 line
2.43.0
maintainer Applied
#2 lore raw
In reply to Suraj Gupta
Quoted 8 lines · Suraj Gupta

The DT schema conversion incorrectly changed xlnx,flush-fsync from a u32 property to a boolean. The original binding documented values 1, 2, and 3 to select which VDMA channel(s) flush on frame sync.
Restore the uint32 type with the documented enum values and fix the example accordingly.

[...]

Applied, thanks!

[1/1] dt-bindings: dma: xlnx,axi-dma: Restore xlnx,flush-fsync as u32

      commit: 287bdea77529e6abac5fe15461d93c1acdcb07e9

Best regards,

Signature · 1 line
~Vinod