Skip to contentSkip to conversation

drm/amd/amdgpu: disable ASPM on VI if pcie dpm is disabled

PATCH In review Kenneth Feng 2 participants 2 messages Jun 25

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/amdgpu: disable ASPM on VI if pcie dpm is disabled

Disable ASPM on VI if PCIE dpm is disabled.
This is a workaround for issue: https://gitlab.freedesktop.org/drm/amd/-/work_items/5370#note_3528027
For the other projects, ASPM are still independant to PCIE dpm.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2 -1
index 70d07ca187a3..9a8f9c74b474 100644
@@ -1333,7 +1333,8 @@ static bool amdgpu_device_aspm_support_quirk(struct amdgpu_device *adev)
 	 * It's unclear if this is a platform-specific or GPU-specific issue.
 	 * Disable ASPM on SI for the time being.
 	 */
-	if (adev->family == AMDGPU_FAMILY_SI)
+	if (adev->family == AMDGPU_FAMILY_SI ||
+		(!(adev->pm.pp_feature & PP_PCIE_DPM_MASK) && adev->family == AMDGPU_FAMILY_VI))
 		return true;
 
 #if IS_ENABLED(CONFIG_X86)
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

AMD General

Btw, please use "Closed:" tag to link issue URL in commit messages.

Best Regards,
Kevin
________________________________
From: Kenneth Feng <[email protected]>
Sent: Thursday, June 25, 2026 6:02 PM
To: [email protected] <[email protected]>
Cc: Wang, Yang(Kevin) <[email protected]>; Feng, Kenneth <[email protected]>
Subject: [PATCH] drm/amd/amdgpu: disable ASPM on VI if pcie dpm is disabled

Disable ASPM on VI if PCIE dpm is disabled.
This is a workaround for issue: https://gitlab.freedesktop.org/drm/amd/-/work_items/5370#note_3528027
For the other projects, ASPM are still independant to PCIE dpm.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2 -1
index 70d07ca187a3..9a8f9c74b474 100644
@@ -1333,7 +1333,8 @@ static bool amdgpu_device_aspm_support_quirk(struct amdgpu_device *adev)
          * It's unclear if this is a platform-specific or GPU-specific issue.
          * Disable ASPM on SI for the time being.
          */
-       if (adev->family == AMDGPU_FAMILY_SI)
+       if (adev->family == AMDGPU_FAMILY_SI ||
+               (!(adev->pm.pp_feature & PP_PCIE_DPM_MASK) && adev->family == AMDGPU_FAMILY_VI))
                 return true;
 
 #if IS_ENABLED(CONFIG_X86)

--
2.34.1