Skip to contentSkip to conversation

ARM: remove unreachable invalid range check in kasan_init()

PATCH New Sang-Heon Jeon 1 participant 1 message Jun 25

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: remove unreachable invalid range check in kasan_init()

kasan_init() maps each memblock region with for_each_mem_range(), which guarantees pa_start < pa_end. Then it skips any region with pa_start >= arm_lowmem_limit, so pa_start < arm_lowmem_limit is guaranteed as well.

When pa_end <= arm_lowmem_limit, pa_start < pa_end means start < end, so the start >= end check is unreachable.

When pa_end > arm_lowmem_limit, end is clamped to __va(arm_lowmem_limit), and pa_start < arm_lowmem_limit means start < end, so the check is unreachable as well.

No functional change.

---
 arch/arm/mm/kasan_init.c | 6 ------
 1 file changed, 6 deletions(-)
arch/arm/mm/kasan_init.c +0 -6
index c6625e808bf8..1f7c74c5df9e 100644
@@ -262,12 +262,6 @@ void __init kasan_init(void)
 				&pa_start, &pa_end, &arm_lowmem_limit);
 			end = __va(arm_lowmem_limit);
 		}
-		if (start >= end) {
-			pr_info("Skipping invalid memory block %pa-%pa (virtual %p-%p)\n",
-				&pa_start, &pa_end, start, end);
-			continue;
-		}
-
 		create_mapping(start, end);
 	}
 
Signature · 1 line
2.43.0