Skip to contentSkip to conversation

nfs: specify NFS version including the minorversion

PATCH In review Avinesh Kumar via ltp 3 participants 3 messages Jun 26 – Jun 30

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfs: specify NFS version including the minorversion

From: Avinesh Kumar <[email protected]>

These entries were missed in commit
4e115dfeee4b ("nfs: use NFS version 4.0, including the minorversion")

hence tests run on NFSv4.2 instead of NFSv4.0 in these two scenarios.

---
 runtest/net.nfs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
runtest/net.nfs +2 -2
index 5d6adaa70..905fd5187 100644
@@ -58,8 +58,8 @@ nfs05_v41_ip6t nfs05.sh -6 -v 4.1 -t tcp
 nfs05_v42_ip6t nfs05.sh -6 -v 4.2 -t tcp
 
 nfs06_v30_v40_ip4  nfs06.sh -v "3,3,3,4.0,4.0,4.0" -t "udp,udp,tcp,tcp,tcp,tcp"
-nfs06_vall_ip4t nfs06.sh -v "3,4,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"
-nfs06_v4x_ip6t nfs06.sh -6 -v "4,4.1,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"
+nfs06_vall_ip4t nfs06.sh -v "3,4.0,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"
+nfs06_v4x_ip6t nfs06.sh -6 -v "4.0,4.1,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"
 
 nfs07_v30_ip4u nfs07.sh -v 3 -t udp
 nfs07_v30_ip4t nfs07.sh -v 3 -t tcp
Signature · 5 lines
2.54.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Avinesh,

Quoted 1 line · Avinesh Kumar

nfs: specify NFS version including the minorversion

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw
In reply to Avinesh Kumar via ltp

Hi Avinesh,

Quoted 4 lines

These entries were missed in commit
4e115dfeee4b ("nfs: use NFS version 4.0, including the minorversion")

hence tests run on NFSv4.2 instead of NFSv4.0 in these two scenarios.

Thanks for your fix, merged.

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp