Skip to contentSkip to conversation

ASoC: Intel: soc-acpi-ptl-match: add tas2783 support

PATCH In review Baojun Xu 4 participants 4 messages Jun 28 – Jun 29

Subsystems (4)
lore
Share & tools
lore

Baojun Xu

author
#0 lore raw

PATCH 1/1 ASoC: Intel: soc-acpi-ptl-match: add tas2783 support

Added tas2783 support in some projects.

---
 sound/soc/amd/acp/amd-acp70-acpi-match.c      | 64 ++++++++++++++++
 .../intel/common/soc-acpi-intel-ptl-match.c   | 74 +++++++++++++++++++
 2 files changed, 138 insertions(+)
sound/soc/amd/acp/amd-acp70-acpi-match.c +64 -0
index 18f2918d4ada..a04075730f4f 100644
@@ -45,6 +45,21 @@ static const struct snd_soc_acpi_endpoint spk_3_endpoint = {
 	.group_id = 1
 };
 
+static const struct snd_soc_acpi_endpoint tas2783_endpoints[] = {
+	{ /*Playback Endpoint*/
+		.num = 0,
+		.aggregated = 0,
+		.group_position = 0,
+		.group_id = 0,
+	},
+	{ /*Mic Capture Endpoint*/
+		.num = 1,
+		.aggregated = 0,
+		.group_position = 0,
+		.group_id = 0,
+	},
+};
+
 static const struct snd_soc_acpi_endpoint jack_amp_g1_dmic_endpoints[] = {
 	/* Jack Endpoint */
 	{
@@ -91,6 +106,15 @@ static const struct snd_soc_acpi_endpoint jack_dmic_endpoints[] = {
 	},
 };
 
+static const struct snd_soc_acpi_adr_device tas2783_0_adr[] = {
+	{
+		.adr = 0x0000300102278301ull,
+		.num_endpoints = ARRAY_SIZE(tas2783_endpoints),
+		.endpoints = tas2783_endpoints,
+		.name_prefix = "tas2783"
+	}
+};
+
 static const struct snd_soc_acpi_adr_device rt712_vb_1_group1_adr[] = {
 	{
 		.adr = 0x000130025D071201ull,
@@ -406,6 +430,15 @@ static const struct snd_soc_acpi_link_adr acp70_cs35l63x4_l0u0246[] = {
 	{}
 };
 
+static const struct snd_soc_acpi_link_adr tas2783_l0[] = {
+	{
+		.mask = BIT(0),
+		.num_adr = ARRAY_SIZE(tas2783_0_adr),
+		.adr_d = tas2783_0_adr,
+	},
+	{}
+};
+
 static const struct snd_soc_acpi_link_adr acp70_cs42l43_l0u1[] = {
 	{
 		.mask = BIT(0),
@@ -553,6 +586,32 @@ static const struct snd_soc_acpi_link_adr acp70_rt722_l0_rt1320_l1[] = {
 	{}
 };
 
+static const struct snd_soc_acpi_adr_device tas2783_2_adr[] = {
+	{
+		/* left */
+		.adr = 0x0000390102000001ull,
+		.num_endpoints = 1,
+		.endpoints = &spk_r_endpoint,
+		.name_prefix = "tas2783-1"
+	},
+	{
+		/* right */
+		.adr = 0x00003c0102000001ull,
+		.num_endpoints = 1,
+		.endpoints = &spk_r_endpoint,
+		.name_prefix = "tas2783-2"
+	},
+};
+
+static const struct snd_soc_acpi_link_adr acp70_tas2783_2[] = {
+	{
+		.mask = BIT(0),
+		.num_adr = ARRAY_SIZE(tas2783_2_adr),
+		.adr_d = tas2783_2_adr,
+	},
+	{}
+};
+
 static const struct snd_soc_acpi_adr_device rt1320_0_single_adr[] = {
 	{
 		.adr = 0x000030025D132001ull,
@@ -659,6 +718,11 @@ static const struct snd_soc_acpi_link_adr acp70_rt721_only[] = {
 };
 
 struct snd_soc_acpi_mach snd_soc_acpi_amd_acp70_sdw_machines[] = {
+	{
+		.link_mask = BIT(0),
+		.links = acp70_tas2783_2,
+		.drv_name = "amd_sdw",
+	},
 	{
 		.link_mask = BIT(0) | BIT(1),
 		.links = acp70_rt1320_l0_rt722_l1,
sound/soc/intel/common/soc-acpi-intel-ptl-match.c +74 -0

86 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw
Quoted 14 lines

-----Original Message-----
From: Baojun Xu <[email protected]>
Sent: Sunday, June 28, 2026 8:26 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; shenghao- [email protected]; [email protected]; [email protected]; linux- [email protected]; Yi, ChEN KAI <[email protected]>; Lo, Henry <[email protected]>; [email protected]; Holalu Yogendra, Niranjan <[email protected]>
Subject: [PATCH v1] ASoC: Intel: soc-acpi-ptl-match: add tas2783 support

Quoted 5 lines

Added tas2783 support in some projects.

---
 sound/soc/amd/acp/amd-acp70-acpi-match.c      | 64 ++++++++++++++++

"Intel" is added to the title, but the commit changes the AMD file, too

Quoted 19 lines
 .../intel/common/soc-acpi-intel-ptl-match.c   | 74 +++++++++++++++++++
 2 files changed, 138 insertions(+)
sound/soc/intel/common/soc-acpi-intel-ptl-match.c +0 -0
index f7694b2a2b02..6b27b09d9f98 100644
 static const struct snd_soc_acpi_link_adr ptl_cs42l43_agg_l3_cs35l56_l2[] = {
 	{
 		.mask = BIT(3),
@@ -464,6 +526,18 @@ struct snd_soc_acpi_mach
 snd_soc_acpi_intel_ptl_sdw_machines[] = {
 		.drv_name = "sof_sdw",
 		.sof_tplg_filename = "sof-ptl-rt722.tplg", /* Reuse the existing

tplg file */

sound/soc/intel/common/soc-acpi-intel-ptl-match.c +2 -0
 	},
+	{
+		.link_mask = BIT(1) | BIT(2),

sound/soc/intel/common/soc-acpi-intel-ptl-match.c struct snd_soc_acpi_mach snd_soc_acpi_intel_ptl_sdw_machines[] = { · line 540

Quoted 10 lines
sound/soc/intel/common/soc-acpi-intel-ptl-match.c +10 -0
+		.links = tas2783_link0,
+		.drv_name = "sof_sdw",
+		.sof_tplg_filename = "sof-ptl-tas2783-2ch.tplg",
+	},
+	{
+		.link_mask = BIT(2),
+		.links = tas2783_link1,
+		.drv_name = "sof_sdw",
+		.sof_tplg_filename = "sof-ptl-tas2783-2ch.tplg",
+	},

Is there any particular reason that you need to add the mach table for the audio configurations? For Intel PTL+ platforms, the SOF driver will generate the acpi mach table based on the reported acpi table and use function topology. That means we don't need to create new acpi mach table and topologies for new audio configurations.

Quoted 6 lines
sound/soc/intel/common/soc-acpi-intel-ptl-match.c +0 -1
 	{
 		.link_mask = BIT(1) | BIT(2) | BIT(3),
 		.links = ptl_sdw_rt713_vb_l2_rt1320_l13,
--

2.25.1

#2 lore raw
In reply to Baojun Xu
Quoted 1 line · Baojun Xu

Added tas2783 support in some projects.

...

sound/soc/amd/acp/amd-acp70-acpi-match.c static const struct snd_soc_acpi_endpoint jack_dmic_endpoints[] = { · line 114

Quoted 6 lines
sound/soc/amd/acp/amd-acp70-acpi-match.c +6 -0
+static const struct snd_soc_acpi_adr_device tas2783_0_adr[] = {
+	{
+		.adr = 0x0000300102278301ull,
+		.num_endpoints = ARRAY_SIZE(tas2783_endpoints),
+		.endpoints = tas2783_endpoints,
+		.name_prefix = "tas2783"

Leave trailing comma for the non-terminator entries.

Quoted 2 lines
(quoted diff) +2 -0
+	}
+};

...

sound/soc/amd/acp/amd-acp70-acpi-match.c static const struct snd_soc_acpi_link_adr acp70_rt722_l0_rt1320_l1[] = { · line 595

Quoted 7 lines
sound/soc/amd/acp/amd-acp70-acpi-match.c +7 -0
+static const struct snd_soc_acpi_adr_device tas2783_2_adr[] = {
+	{
+		/* left */
+		.adr = 0x0000390102000001ull,
+		.num_endpoints = 1,
+		.endpoints = &spk_r_endpoint,
+		.name_prefix = "tas2783-1"

Ditto.

sound/soc/amd/acp/amd-acp70-acpi-match.c static const struct snd_soc_acpi_link_adr acp70_rt722_l0_rt1320_l1[] = { · line 602

Quoted 7 lines
sound/soc/amd/acp/amd-acp70-acpi-match.c +7 -0
+	},
+	{
+		/* right */
+		.adr = 0x00003c0102000001ull,
+		.num_endpoints = 1,
+		.endpoints = &spk_r_endpoint,
+		.name_prefix = "tas2783-2"

Ditto.

Review

Quoted 2 lines
(quoted diff) +2 -0
+	},
+};

...

...and so on for Intel case.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#3 lore raw
In reply to Baojun Xu
Quoted 1 line · Baojun Xu

Added tas2783 support in some projects.

No patch "added" anything. The patch is a proposal to _add_. Please rephrase.

Next, why is Intel's soc-acpi-ptl-match altered when it seems the board is supported only by the AMD component? Commit's title does not help or clarify the situation either.

Quoted 6 lines
---
  sound/soc/amd/acp/amd-acp70-acpi-match.c      | 64 ++++++++++++++++
  .../intel/common/soc-acpi-intel-ptl-match.c   | 74 +++++++++++++++++++
  2 files changed, 138 insertions(+)