mm/damon: add kernel-doc comments for probes and rnd_state of damon_ctx
Subsystems (2)
SJ Park
maintainercover mm/damon: add kernel-doc comments for probes and rnd_state of damon_ctx
The two fields of damon_ctx struct don’t have their kernel-doc comments. That causes kernel document builds to warn. Fix those.
The broken commits are in the mm-stable tree. As the issue is not significant and the next merge window for 7.2 is expected to open today, apparently it is too late to squash these fixes to the broken commits. I hope these to be merged into 7.2 release after the merge window, so that those don't bother stable@.
SJ Park (2):
mm/damon: add a kernel-doc comment for damon_ctx->probes mm/damon: add a kernel-doc comment for damon_ctx->rnd_state
include/linux/damon.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
base-commit: 7875263842e9465bb31d0dbbcbd899610dfe43b4
Signature · 1 line
2.47.3
SJ Park
maintainerPATCH 1/2 mm/damon: add a kernel-doc comment for damon_ctx->probes
Fix below document build warning:
WARNING: ../include/linux/damon.h:909 struct member 'probes' not described in 'damon_ctx'
--- include/linux/damon.h | 1 + 1 file changed, 1 insertion(+)
include/linux/damon.h +1 -0
@@ -841,6 +841,7 @@ struct damon_attrs {* including damon_call() and damos_walk(). * * @ops: Set of monitoring operations for given use cases. +* @probes: Head of probes (&damon_probe) list. * @addr_unit: Scale factor for core to ops address conversion. * @min_region_sz: Minimum region size. * @pause: Pause kdamond main loop.
Signature · 1 line
2.47.3
SJ Park
maintainerPATCH 2/2 mm/damon: add a kernel-doc comment for damon_ctx->rnd_state
In reply to SJ ParkFix below kernel document build warning:
WARNING: ../include/linux/damon.h:909 struct member 'rnd_state' not described in 'damon_ctx'
--- include/linux/damon.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/damon.h +1 -1
@@ -847,6 +847,7 @@ struct damon_attrs {* @pause: Pause kdamond main loop. * @adaptive_targets: Head of monitoring targets (&damon_target) list. * @schemes: Head of schemes (&damos) list. +* @rnd_state: Per-ctx PRNG state for damon_rand(). */ struct damon_ctx {struct damon_attrs attrs;
@@ -904,7 +905,6 @@ struct damon_ctx {struct list_head adaptive_targets;struct list_head schemes; -/* Per-ctx PRNG state for damon_rand(); kdamond is the sole consumer. */ struct rnd_state rnd_state; };
Signature · 1 line
2.47.3