dt-bindings: Fix bracket
Subsystems (3)
PATCH 1/1 dt-bindings: Fix bracket
Add "(Alternate" to "ID)"
--- Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/net/microchip,lan95xx.yaml +1 -1
@@ -33,7 +33,7 @@ properties: - usb424,9906 # SMSC9505A USB Ethernet Device (HAL) - usb424,9907 # SMSC9500 USB Ethernet Device (Alternate ID) - usb424,9908 # SMSC9500A USB Ethernet Device (Alternate ID) - - usb424,9909 # SMSC9512/9514 USB Hub & Ethernet Device ID) + - usb424,9909 # SMSC9512/9514 USB Hub & Ethernet Device (Alternate ID) - usb424,9e00 # SMSC9500A USB Ethernet Device - usb424,9e01 # SMSC9505A USB Ethernet Device - usb424,9e08 # SMSC LAN89530 USB Ethernet Device
Signature · 1 line
2.54.0
Quoted 1 line · Manuel Ebner
Add "(Alternate" to "ID)"
Why?
I see what you did in the diff, so why repeating it?
Quoted 2 lines
Signed-off-by Manuel Ebner <[email protected]>
Best regards,
Krzysztof
Quoted 7 lines · Krzysztof Kozlowski
Quoted 1 line · Manuel Ebner
Add "(Alternate" to "ID)"
Why?
I see what you did in the diff, so why repeating it?
Heh, and the subject is "fix bracket" - what bracket?
Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Best regards,
Krzysztof
From: Manuel Ebner <[email protected]>
Sent: Saturday, June 27, 2026 11:20 AM
Quoted 3 lines
Add "(Alternate" to "ID)"
Signed-off-by Manuel Ebner <[email protected]>
Hi
as the title states that's fix path we also need a fixes tag here in the commit msg pointing out which patch is being fixed
I'll admit I don't know exactly whats the issue
Quoted 13 lines · Manuel Ebner
Add "(Alternate" to "ID)"
Signed-off-by Manuel Ebner <[email protected]>---
Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/net/microchip,lan95xx.yaml +0
-0
Documentation/devicetree/bindings/net/microchip,lan95xx.yaml properties: · line 36
Quoted 4 lines
Documentation/devicetree/bindings/net/microchip,lan95xx.yaml +0
-1@@ -33,7 +33,7 @@ properties: - usb424,9906 # SMSC9505A USB Ethernet Device (HAL) - usb424,9907 # SMSC9500 USB Ethernet Device (Alternate ID) - usb424,9908 # SMSC9500A USB Ethernet Device (Alternate ID) - - usb424,9909 # SMSC9512/9514 USB Hub & Ethernet Device ID)
There's an issue in this line with the brace and maybe with the text as well. I couldn't figure out what usb424,9909 is. Can somebody help me? Below are some possible fixes.
Quoted 7 lines
Documentation/devicetree/bindings/net/microchip,lan95xx.yaml +3
-0+ - usb424,9909 # SMSC9512/9514 USB Hub & Ethernet Device + - usb424,9909 # SMSC9512/9514 USB Hub & Ethernet Device (Alternate ID) + - usb424,9909 # SMSC9512/9514 USB Hub & Ethernet Device (SAL10)- usb424,9e00 # SMSC9500A USB Ethernet Device
- usb424,9e01 # SMSC9505A USB Ethernet Device
- usb424,9e08 # SMSC LAN89530 USB Ethernet Device
Thanks
Manuel