Skip to contentSkip to conversation

dt-bindings: Fix bracket

PATCH In review Manuel Ebner 3 participants 5 messages Jun 27 – Jun 29

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: Fix bracket

Add "(Alternate" to "ID)"

---
 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/net/microchip,lan95xx.yaml +1 -1
index accff93d38f8..62bf982aff2b 100644
@@ -33,7 +33,7 @@ properties:
           - usb424,9906   # SMSC9505A USB Ethernet Device (HAL)
           - usb424,9907   # SMSC9500 USB Ethernet Device (Alternate ID)
           - usb424,9908   # SMSC9500A USB Ethernet Device (Alternate ID)
-          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Device  ID)
+          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Device (Alternate ID)
           - usb424,9e00   # SMSC9500A USB Ethernet Device
           - usb424,9e01   # SMSC9505A USB Ethernet Device
           - usb424,9e08   # SMSC LAN89530 USB Ethernet Device
Signature · 1 line
2.54.0
#2 lore raw
Quoted 7 lines · Krzysztof Kozlowski
Quoted 1 line · Manuel Ebner

Add "(Alternate" to "ID)"

Why?

I see what you did in the diff, so why repeating it?

Heh, and the subject is "fix bracket" - what bracket?

Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Best regards,
Krzysztof

#4 lore raw
In reply to Manuel Ebner

I'll admit I don't know exactly whats the issue

Quoted 13 lines · Manuel Ebner

Add "(Alternate" to "ID)"

---
 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/net/microchip,lan95xx.yaml +0 -0
index accff93d38f8..62bf982aff2b 100644

Documentation/devicetree/bindings/net/microchip,lan95xx.yaml properties: · line 36

Quoted 4 lines
Documentation/devicetree/bindings/net/microchip,lan95xx.yaml +0 -1
@@ -33,7 +33,7 @@ properties:
            - usb424,9906   # SMSC9505A USB Ethernet Device (HAL)
            - usb424,9907   # SMSC9500 USB Ethernet Device (Alternate ID)
            - usb424,9908   # SMSC9500A USB Ethernet Device (Alternate ID)
-          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Device  ID)

There's an issue in this line with the brace and maybe with the text as well. I couldn't figure out what usb424,9909 is. Can somebody help me? Below are some possible fixes.

Quoted 7 lines
Documentation/devicetree/bindings/net/microchip,lan95xx.yaml +3 -0
+          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Device
+          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Device (Alternate ID)
+          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Device (SAL10)
 

           - usb424,9e00   # SMSC9500A USB Ethernet Device
           - usb424,9e01   # SMSC9505A USB Ethernet Device
           - usb424,9e08   # SMSC LAN89530 USB Ethernet Device

Thanks
Manuel