Skip to contentSkip to conversation

scsi: isci: remove unused macros from scu_task_context.h

PATCH Applied Piotr Zarycki 2 participants 2 messages Jun 29 – Aug 6

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: isci: remove unused macros from scu_task_context.h

Remove three accessor macros that are defined but never used:
- scu_get_command_request_subtype()
- scu_get_command_request_full_type()
- scu_get_command_protocl_engine_group()

Also remove SCU_CONTEXT_COMMAND_REQUEST_FULLTYPE_MASK and SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_MASK which were only referenced by the removed macros.

---
 drivers/scsi/isci/scu_task_context.h | 14 --------------
 1 file changed, 14 deletions(-)
drivers/scsi/isci/scu_task_context.h +0 -14
index 582d22d54689..f877a5ebbbe0 100644
@@ -193,21 +193,7 @@ typedef enum {
 
 #define SCU_CONTEXT_COMMAND_REQUEST_SUBTYPE_SHIFT        18
 #define SCU_CONTEXT_COMMAND_REQUEST_SUBTYPE_MASK         0x001C0000
-#define scu_get_command_request_subtype(x) \
-	((x) & SCU_CONTEXT_COMMAND_REQUEST_SUBTYPE_MASK)
-
-#define SCU_CONTEXT_COMMAND_REQUEST_FULLTYPE_MASK	 \
-	(\
-		SCU_CONTEXT_COMMAND_REQUEST_TYPE_MASK		  \
-		| SCU_CONTEXT_COMMAND_REQUEST_SUBTYPE_MASK	    \
-	)
-#define scu_get_command_request_full_type(x) \
-	((x) & SCU_CONTEXT_COMMAND_REQUEST_FULLTYPE_MASK)
-
 #define SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_SHIFT  16
-#define SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_MASK   0x00010000
-#define scu_get_command_protocl_engine_group(x)	\
-	((x) & SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_MASK)
 
 #define SCU_CONTEXT_COMMAND_LOGICAL_PORT_SHIFT           12
 #define SCU_CONTEXT_COMMAND_LOGICAL_PORT_MASK            0x00007000
Signature · 1 line
2.54.0
#1 lore raw
Quoted 10 lines · Piotr Zarycki

Remove three accessor macros that are defined but never used:
- scu_get_command_request_subtype()
- scu_get_command_request_full_type()
- scu_get_command_protocl_engine_group()

Also remove SCU_CONTEXT_COMMAND_REQUEST_FULLTYPE_MASK and SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_MASK which were only referenced by the removed macros.

[...]

Applied to 7.3/scsi-queue, thanks!

[1/1] scsi: isci: remove unused macros from scu_task_context.h

      https://git.kernel.org/mkp/scsi/c/d756863c9bdf
Signature · 1 line
Martin K. Petersen