Skip to contentSkip to conversation

arm: dts: mediatek: mt6589: Fix timer interrupt trigger type

PATCH In review Akari Tsuyukusa 1 participant 2 messages Jun 29 – Jul 23

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: dts: mediatek: mt6589: Fix timer interrupt trigger type

MT6589 uses IRQ_TYPE_LEVEL_LOW for arch timer, but I sent a patch using IRQ_TYPE_LEVEL_HIGH.
The timer worked correctly regardless of whether IRQ_TYPE_LEVEL_LOW or IRQ_TYPE_LEVEL_HIGH was used in the Device Tree, therefore, there is no actual impact. However, this is not a correct description of the hardware so correct it.

Fixes 2a5d54507c68 ("arm: dts: mediatek: mt6589: Add Arm Generic Timer node")
---
 arch/arm/boot/dts/mediatek/mt6589.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/mediatek/mt6589.dtsi +4 -4
index 46dea445742b..df3b7bfeac33 100644
@@ -45,10 +45,10 @@ cpu@3 {
 	timer {
 		compatible = "arm,armv7-timer";
 		interrupt-parent = <&gic>;
-		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
-			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
-			     <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
-			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
+		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
 		clock-frequency = <13000000>;
 		arm,cpu-registers-not-fw-configured;
 	};
Signature · 1 line
2.54.0
#1 lore raw

Dear maintainers,

Quoted 10 lines · Akari Tsuyukusa

MT6589 uses IRQ_TYPE_LEVEL_LOW for arch timer, but I sent a patch using IRQ_TYPE_LEVEL_HIGH.
The timer worked correctly regardless of whether IRQ_TYPE_LEVEL_LOW or IRQ_TYPE_LEVEL_HIGH was used in the Device Tree, therefore, there is no actual impact. However, this is not a correct description of the hardware so correct it.

Fixes 2a5d54507c68 ("arm: dts: mediatek: mt6589: Add Arm Generic Timer node")

Could you please apply this patch?

Best Regards,
Akari