Skip to contentSkip to conversation

mm/damon/vaddr: remove redundant RCU lock

PATCH In review IgorpetinDev 3 participants 14 messages Jun 29 – Jun 30

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/damon/vaddr: remove redundant RCU lock

__damon_va_three_regions() is called only by damon_va_three_regions(), which already holds mmap_read_lock(). Since mmap_read_lock() is held, the maple tree and VMA list are protected from concurrent changes. Remove the unnecessary rcu_read_lock() and rcu_read_unlock() calls.

---
 mm/damon/vaddr.c | 2 --
 1 file changed, 2 deletions(-)
mm/damon/vaddr.c +0 -2
index d27147603..345b89b5d 100644
@@ -84,7 +84,6 @@ static int __damon_va_three_regions(struct mm_struct *mm,
 	 * If this is too slow, it can be optimised to examine the maple
 	 * tree gaps.
 	 */
-	rcu_read_lock();
 	for_each_vma(vmi, vma) {
 		unsigned long gap;
 
@@ -105,7 +104,6 @@ static int __damon_va_three_regions(struct mm_struct *mm,
 next:
 		prev = vma;
 	}
-	rcu_read_unlock();
 
 	if (!sz_range(&second_gap) || !sz_range(&first_gap))
 		return -EINVAL;
Signature · 1 line
2.47.3
#1 lore raw
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:

New issues:
- [Medium] The removal of rcu_read_lock() breaks the KUnit test damon_test_three_regions_in_vmas(), causing a lockdep splat.

Pre-existing issues:
- [High] VMA tree iteration on an external mm_struct is performed without checking if the address space is stable, risking a crash on unstable MMs. --

commit e3efcd87bda8a6d5dd6bcc064e6f5876f9980a31
Author: IgorpetinDev <[email protected]>

mm/damon/vaddr: remove redundant RCU lock

This patch removes the rcu_read_lock() and rcu_read_unlock() calls from __damon_va_three_regions(), assuming that the mmap_read_lock is always held by the caller.

Quoted 2 lines

__damon_va_three_regions() is called only by damon_va_three_regions(), which already holds mmap_read_lock(). Since mmap_read_lock() is held,

[Severity: High]
This is a pre-existing issue, but when damon_va_three_regions() acquires the mmap_read_lock on an external task's mm_struct, is it safe to begin traversing the VMA tree without first verifying address space stability?

If the target process is concurrently undergoing an OOM kill or failed a dup_mmap(), the mm_struct could be flagged MMF_UNSTABLE and the maple tree could contain XA_ZERO_ENTRY markers. Should damon_va_three_regions() call check_stable_address_space() before __damon_va_three_regions() traverses the tree, to prevent a potential kernel panic from dereferencing invalid markers?

mm/damon/vaddr.c static int __damon_va_three_regions(struct mm_struct *mm, · line 85

Quoted 10 lines
mm/damon/vaddr.c +0 -1
index e73ec1ce016e5..882cc7cb09027 100644
@@ -82,7 +82,6 @@ static int __damon_va_three_regions(struct mm_struct *mm,
 	 * If this is too slow, it can be optimised to examine the maple
 	 * tree gaps.
 	 */
-	rcu_read_lock();
 	for_each_vma(vmi, vma) {

[Severity: Medium]
Will the removal of this lock break the KUnit test damon_test_three_regions_in_vmas() located in mm/damon/tests/vaddr-kunit.h?

The test framework calls __damon_va_three_regions() directly using a dummy mm_struct and a maple tree initialized without the MT_FLAGS_LOCK_EXTERN flag. Since the test environment doesn't hold the internal maple tree lock or an external mmap_lock, won't removing this rcu_read_lock() cause a lockdep warning (suspicious rcu_dereference_check usage) when for_each_vma() attempts to traverse the tree?

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
maintainer
#2 lore raw
Quoted 26 lines · On Mon, 29 Jun 2026 17:06:27 +0000 [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:

New issues:
- [Medium] The removal of rcu_read_lock() breaks the KUnit test damon_test_three_regions_in_vmas(), causing a lockdep splat.

Pre-existing issues:
- [High] VMA tree iteration on an external mm_struct is performed without checking if the address space is stable, risking a crash on unstable MMs. --

commit e3efcd87bda8a6d5dd6bcc064e6f5876f9980a31
Author: IgorpetinDev <[email protected]>

mm/damon/vaddr: remove redundant RCU lock

This patch removes the rcu_read_lock() and rcu_read_unlock() calls from __damon_va_three_regions(), assuming that the mmap_read_lock is always held by the caller.

Quoted 2 lines

__damon_va_three_regions() is called only by damon_va_three_regions(), which already holds mmap_read_lock(). Since mmap_read_lock() is held,

[Severity: High]
This is a pre-existing issue, but when damon_va_three_regions() acquires the mmap_read_lock on an external task's mm_struct, is it safe to begin traversing the VMA tree without first verifying address space stability?

Quoted 6 lines

If the target process is concurrently undergoing an OOM kill or failed a dup_mmap(), the mm_struct could be flagged MMF_UNSTABLE and the maple tree could contain XA_ZERO_ENTRY markers. Should damon_va_three_regions() call check_stable_address_space() before __damon_va_three_regions() traverses the tree, to prevent a potential kernel panic from dereferencing invalid markers?

A similar question was asked [1] before. As I also replied at that time, I believe this is safe. Correct me if I'm wrong.

Quoted 17 lines

mm/damon/vaddr.c static int __damon_va_three_regions(struct mm_struct *mm, · line 85

Quoted 11 lines
mm/damon/vaddr.c +0 -1
index e73ec1ce016e5..882cc7cb09027 100644
@@ -82,7 +82,6 @@ static int __damon_va_three_regions(struct mm_struct *mm,
 	 * If this is too slow, it can be optimised to examine the maple
 	 * tree gaps.
 	 */
-	rcu_read_lock();
 	for_each_vma(vmi, vma) {

[Severity: Medium]
Will the removal of this lock break the KUnit test damon_test_three_regions_in_vmas() located in mm/damon/tests/vaddr-kunit.h?

Quoted 6 lines

The test framework calls __damon_va_three_regions() directly using a dummy mm_struct and a maple tree initialized without the MT_FLAGS_LOCK_EXTERN flag. Since the test environment doesn't hold the internal maple tree lock or an external mmap_lock, won't removing this rcu_read_lock() cause a lockdep warning (suspicious rcu_dereference_check usage) when for_each_vma() attempts to traverse the tree?

Sounds like making sense to me. IgorpetinDev, what do you think?

[1] https://lore.kernel.org/damon/[email protected]/

Thanks,
SJ

[...]

maintainer
#3 lore raw
In reply to IgorpetinDev
Quoted 6 lines · On Mon, 29 Jun 2026 19:53:49 +0300 IgorpetinDev <[email protected]> wrote:

__damon_va_three_regions() is called only by damon_va_three_regions(), which already holds mmap_read_lock(). Since mmap_read_lock() is held, the maple tree and VMA list are protected from concurrent changes. Remove the unnecessary rcu_read_lock() and rcu_read_unlock() calls.

We prefer using a real name. I show you used 'Igor Putko' as your name before. Any reason to change the name?

Quoted 17 lines
---
 mm/damon/vaddr.c | 2 --
 1 file changed, 2 deletions(-)
mm/damon/vaddr.c +0 -1
index d27147603..345b89b5d 100644
@@ -84,7 +84,6 @@ static int __damon_va_three_regions(struct mm_struct *mm,
 	 * If this is too slow, it can be optimised to examine the maple
 	 * tree gaps.
 	 */
-	rcu_read_lock();
 	for_each_vma(vmi, vma) {
 		unsigned long gap;
 

mm/damon/vaddr.c static int __damon_va_three_regions(struct mm_struct *mm, · line 108

Quoted 4 lines
mm/damon/vaddr.c +0 -1
@@ -105,7 +104,6 @@ static int __damon_va_three_regions(struct mm_struct *mm,
 next:
 		prev = vma;
 	}
-	rcu_read_unlock();

As Sashiko also commented, this may cause lockdep warning. Actually this was added to fix it. Refer to the previous discussions [1] for more details.

How about moving rcu_read_[un]lock() to the caller test code?

[1] https://lore.kernel.org/[email protected]

Thanks,
SJ

[...]

#4 lore raw

Hi SJ,

Quoted 1 line · SJ Park

We prefer using a real name. I show you used 'Igor Putko' as your name

before.

Quoted 1 line

Any reason to change the name?

Apologies for the confusion. I recently reinstalled my OS and misconfigured my git setup. I will revert back to 'Igor Putko' for the v2 submission.

Quoted 1 line

As Sashiko also commented, this may cause lockdep warning. Actually this

was

Quoted 3 lines

added to fix it. Refer to the previous discussions [1] for more details.

How about moving rcu_read_[un]lock() to the caller test code?

That makes total sense. I will move the rcu_read_lock() and rcu_read_unlock()
calls directly into the KUnit test code in mm/damon/tests/vaddr-kunit.h to prevent the lockdep splat.

Regarding the pre-existing high-severity issue reported by Sashiko AI about missing check_stable_address_space(), I believe it is out of scope for this particular cleanup and should be addressed in a separate, dedicated patch.

I will send the v2 shortly.

Thanks,
Igor

Quoted 52 lines · SJ Park
Quoted 6 lines · On Mon, 29 Jun 2026 19:53:49 +0300 IgorpetinDev <[email protected]> wrote:

__damon_va_three_regions() is called only by damon_va_three_regions(), which already holds mmap_read_lock(). Since mmap_read_lock() is held, the maple tree and VMA list are protected from concurrent changes. Remove the unnecessary rcu_read_lock() and rcu_read_unlock() calls.

We prefer using a real name. I show you used 'Igor Putko' as your name before.
Any reason to change the name?

mm/damon/vaddr.c static int __damon_va_three_regions(struct mm_struct

Quoted 9 lines
---
 mm/damon/vaddr.c | 2 --
 1 file changed, 2 deletions(-)
mm/damon/vaddr.c +0 -0
index d27147603..345b89b5d 100644
@@ -84,7 +84,6 @@ static int __damon_va_three_regions(struct mm_struct

*mm,

mm/damon/vaddr.c static int __damon_va_three_regions(struct mm_struct

Quoted 8 lines
mm/damon/vaddr.c +0 -1
       * If this is too slow, it can be optimised to examine the maple
       * tree gaps.
       */
-     rcu_read_lock();
      for_each_vma(vmi, vma) {
              unsigned long gap;
 
@@ -105,7 +104,6 @@ static int __damon_va_three_regions(struct mm_struct

*mm,

mm/damon/vaddr.c static int __damon_va_three_regions(struct mm_struct *mm, · line 108

Quoted 4 lines
mm/damon/vaddr.c +0 -1
 next:
              prev = vma;
      }
-     rcu_read_unlock();

As Sashiko also commented, this may cause lockdep warning. Actually this was
added to fix it. Refer to the previous discussions [1] for more details.

How about moving rcu_read_[un]lock() to the caller test code?

[1] https://lore.kernel.org/[email protected]

Thanks,
SJ

[...]

author
#5 lore raw

PATCH 1/1 mm/damon/vaddr: remove redundant RCU lock

In reply to IgorpetinDev

From: IgorpetinDev <[email protected]>

__damon_va_three_regions() is called only by damon_va_three_regions(), which already holds mmap_read_lock(). Since mmap_read_lock() is held, the maple tree and VMA list are protected from concurrent changes. Remove the unnecessary rcu_read_lock() and rcu_read_unlock() calls.

---
 mm/damon/vaddr.c | 2 --
 1 file changed, 2 deletions(-)
mm/damon/vaddr.c +0 -2
index d27147603..345b89b5d 100644
@@ -84,7 +84,6 @@ static int __damon_va_three_regions(struct mm_struct *mm,
 	 * If this is too slow, it can be optimised to examine the maple
 	 * tree gaps.
 	 */
-	rcu_read_lock();
 	for_each_vma(vmi, vma) {
 		unsigned long gap;
 
@@ -105,7 +104,6 @@ static int __damon_va_three_regions(struct mm_struct *mm,
 next:
 		prev = vma;
 	}
-	rcu_read_unlock();
 
 	if (!sz_range(&second_gap) || !sz_range(&first_gap))
 		return -EINVAL;
Signature · 1 line
2.47.3
#6 lore raw
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:

New issues:
- [Medium] Removing rcu_read_lock() breaks the KUnit test damon_test_three_regions_in_vmas(), causing a lockdep splat.

Pre-existing issues:
- [High] VMA iteration on an external mm_struct is performed without checking for address space stability. --

commit d9d9a562dbd8520f8d06d146def9565fda08562d
Author: IgorpetinDev <[email protected]>

mm/damon/vaddr: remove redundant RCU lock

This commit removes the rcu_read_lock() and rcu_read_unlock() calls from __damon_va_three_regions(). The commit message states that since mmap_read_lock() is already held by the caller, the maple tree and VMA list are protected from concurrent changes, making the RCU locks redundant.

mm/damon/vaddr.c static int __damon_va_three_regions(struct mm_struct *mm, · line 85

Quoted 10 lines
mm/damon/vaddr.c +0 -1
index e73ec1ce016e5..882cc7cb09027 100644
@@ -82,7 +82,6 @@ static int __damon_va_three_regions(struct mm_struct *mm,
 	 * If this is too slow, it can be optimised to examine the maple
 	 * tree gaps.
 	 */
-	rcu_read_lock();
 	for_each_vma(vmi, vma) {

[Severity: Medium]
Will removing this rcu_read_lock() cause a lockdep splat in the KUnit tests?

Looking at damon_test_three_regions_in_vmas() in mm/damon/tests/vaddr-kunit.h, it calls __damon_va_three_regions() directly on a mocked maple tree:

	__damon_va_three_regions(&mm, regions);

Because this KUnit test doesn't hold mmap_read_lock() or configure an external tree lock, removing the localized rcu_read_lock() here will cause for_each_vma() to trigger RCU lockdep assertions for suspicious RCU usage.

[Severity: High]
This isn't a bug introduced by this patch, but does this function safely iterate over an external mm_struct?

Looking at the caller damon_va_three_regions() in mm/damon/vaddr.c, it acquires mmap_read_lock() on an external mm, but check_stable_address_space(mm) is never called before iterating the VMAs.

If the target process fails dup_mmap() during fork or is processed by the OOM reaper, its mm is flagged MMF_UNSTABLE and the maple tree slots may contain XA_ZERO_ENTRY markers. Iterating over these markers without checking address space stability can cause the iterator to return invalid VMA pointers, which will cause a panic when dereferenced.

[ ... ]

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
author
#7 lore raw

PATCH v2 1/1 mm/damon/vaddr: remove redundant RCU lock

In reply to IgorpetinDev

__damon_va_three_regions() is called only by damon_va_three_regions(), which already holds mmap_read_lock(). Since mmap_read_lock() is held, the maple tree and VMA list are protected from concurrent changes. Remove the unnecessary rcu_read_lock() and rcu_read_unlock() calls.

---
 mm/damon/tests/vaddr-kunit.h | 2 ++
 mm/damon/vaddr.c             | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)
mm/damon/tests/vaddr-kunit.h +2 -0
index 563fbc7e3..70cb7825e 100644
@@ -81,7 +81,9 @@ static void damon_test_three_regions_in_vmas(struct kunit *test)
 	if (__link_vmas(&mm.mm_mt, vmas, ARRAY_SIZE(vmas)))
 		kunit_skip(test, "Failed to create VMA tree");
 
+	rcu_read_lock();
 	__damon_va_three_regions(&mm, regions);
+	rcu_read_unlock();
 
 	KUNIT_EXPECT_EQ(test, 10ul, regions[0].start);
 	KUNIT_EXPECT_EQ(test, 25ul, regions[0].end);
mm/damon/vaddr.c +0 -2
index d27147603..345b89b5d 100644
@@ -84,7 +84,6 @@ static int __damon_va_three_regions(struct mm_struct *mm,
 	 * If this is too slow, it can be optimised to examine the maple
 	 * tree gaps.
 	 */
-	rcu_read_lock();
 	for_each_vma(vmi, vma) {
 		unsigned long gap;
 
@@ -105,7 +104,6 @@ static int __damon_va_three_regions(struct mm_struct *mm,
 next:
 		prev = vma;
 	}
-	rcu_read_unlock();
 
 	if (!sz_range(&second_gap) || !sz_range(&first_gap))
 		return -EINVAL;
Signature · 1 line
2.47.3
#8 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] VMA iteration on an external mm_struct is performed without checking check_stable_address_space(mm), which can lead to iterating a corrupted maple tree. --

commit fdc4435ee0611e8373511ef284a90ecc98420eec
Author: Igor Putko <[email protected]>

mm/damon/vaddr: remove redundant RCU lock

This commit removes rcu_read_lock() and rcu_read_unlock() from __damon_va_three_regions() and adds them to its kunit test. It asserts that mmap_read_lock() is sufficient to protect the maple tree during VMA iteration.

Quoted 4 lines
mm/damon/vaddr.c +0 -0
index e73ec1ce016e5..882cc7cb09027 100644

[ ... ]

mm/damon/vaddr.c static int __damon_va_three_regions(struct mm_struct *mm, · line 85

Quoted 6 lines
mm/damon/vaddr.c +0 -1
@@ -82,7 +82,6 @@ static int __damon_va_three_regions(struct mm_struct *mm,
 	 * If this is too slow, it can be optimised to examine the maple
 	 * tree gaps.
 	 */
-	rcu_read_lock();
 	for_each_vma(vmi, vma) {

[Severity: High]
This is a pre-existing issue, but while reviewing the VMA traversal here, I noticed a potential problem with how the mmap_read_lock is used by the callers of this function.

When traversing VMAs on an external mm_struct, does this code need to check check_stable_address_space(mm) before iterating?

Looking at damon_va_three_regions() and damon_va_walk_page_range(), they acquire mmap_read_lock(mm) and proceed directly to VMA traversal:

mm/damon/vaddr.c:damon_va_three_regions() {
	...
	mmap_read_lock(mm);
	rc = __damon_va_three_regions(mm, regions);
	mmap_read_unlock(mm);
	...
}

If the OOM reaper runs on the target process, it can mark the mm as unstable and leave XA_ZERO_ENTRY markers in the maple tree. Iterating this corrupted tree without first verifying check_stable_address_space(mm) can lead to kernel crashes.

Could this be triggered under system memory pressure while DAMON is monitoring?

Quoted 1 line
mm/damon/vaddr.c +0 -0
 		unsigned long gap;
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
maintainer
#9 lore raw
In reply to Igor Putko

Hello Igor,

Thank you for this patch.

From next time, please give enough time for others to comment before posting a new revision of the patch.

Also, please post a new revision as a new thread with a changelog [1] including links to previous revisions, rather than a reply to the previous revision.

Quoted 4 lines · On Tue, 30 Jun 2026 16:02:53 +0300 Igor Putko <[email protected]> wrote:

__damon_va_three_regions() is called only by damon_va_three_regions(), which already holds mmap_read_lock(). Since mmap_read_lock() is held, the maple tree and VMA list are protected from concurrent changes. Remove the unnecessary rcu_read_lock() and rcu_read_unlock() calls.

This is not explaining the test part change. Could you please update for that?

Also, have you had a chance to theoretically or experiemently confirm the problem [2] that motivated to add the rcu_read_lock() at that place is not reintroduced by this change? If so, could you please add that to the commit log, too?

Thanks,
SJ

[1] https://docs.kernel.org/process/submitting-patches.html#commentary
[2] https://lore.kernel.org/[email protected]

[...]

author
#10 lore raw
In reply to IgorpetinDev

Hi SJ,

Quoted 2 lines · SJ Park

We prefer using a real name. I show you used 'Igor Putko' as your name before. Any reason to change the name?

Apologies for the confusion. I recently reinstalled my OS and misconfigured my git setup. I will revert back to 'Igor Putko' for the v2 submission.

Quoted 4 lines

As Sashiko also commented, this may cause lockdep warning. Actually this was added to fix it. Refer to the previous discussions [1] for more details.

How about moving rcu_read_[un]lock() to the caller test code?

That makes total sense. I will move the rcu_read_lock() and rcu_read_unlock() calls directly into the KUnit test code in mm/damon/tests/vaddr-kunit.h to prevent the lockdep splat.

Regarding the pre-existing high-severity issue reported by Sashiko AI about missing check_stable_address_space(), I believe it is out of scope for this particular cleanup and should be addressed in a separate, dedicated patch.

I have just sent the v2 patch out.

Thanks,
Igor

maintainer
#11 lore raw
Quoted 8 lines · On Tue, 30 Jun 2026 16:07:43 +0300 Igor Putko <[email protected]> wrote:

Hi SJ,

Quoted 2 lines · SJ Park

We prefer using a real name. I show you used 'Igor Putko' as your name before. Any reason to change the name?

Apologies for the confusion. I recently reinstalled my OS and misconfigured my git setup. I will revert back to 'Igor Putko' for the v2 submission.

No worries! I'm glad that I helped you finding a misconfiguration!

Quoted 6 lines
Quoted 5 lines

As Sashiko also commented, this may cause lockdep warning. Actually this was added to fix it. Refer to the previous discussions [1] for more details.

How about moving rcu_read_[un]lock() to the caller test code?

Quoted 7 lines

That makes total sense. I will move the rcu_read_lock() and rcu_read_unlock() calls directly into the KUnit test code in mm/damon/tests/vaddr-kunit.h to prevent the lockdep splat.

Regarding the pre-existing high-severity issue reported by Sashiko AI about missing check_stable_address_space(), I believe it is out of scope for this particular cleanup and should be addressed in a separate, dedicated patch.

I was thinking it is not a real issue. Do you think it is a real?

Quoted 2 lines

I have just sent the v2 patch out.

From next time, please give enough time before sending a new revision (say, ~12 hours at least?), to ensure the discussion on the previous revision is concluded.

Thanks,
SJ

[...]

author
#12 lore raw
In reply to IgorpetinDev

Hi SJ,

Thanks for the reply and the pointers!
Regarding the issue Sashiko AI flagged - I dug into damon/vaddr.c, and I think it's a real bug, but it's isolated to __damon_va_three_regions().
damon_va_walk_page_range() is fine here, since lock_vma_under_rcu() handles stability on its own. __damon_va_three_regions() is the problematic one: right after mmap_read_lock(mm) is taken in the caller, it sets up a VMA_ITERATOR and runs for_each_vma(). But mmap_read_lock doesn't stop the OOM reaper from running concurrently, setting MMF_UNSTABLE, and leaving empty markers in the maple tree. Walking the tree in that state without a check_stable_address_space(mm) call could lead to a NULL pointer dereference. Since this looks like a separate issue, I'll prepare a dedicated fix and send it as its own patch thread, so it doesn't hold up the current cleanup. Let me know if that approach works for you.

Thanks,
Igor

maintainer
#13 lore raw
Quoted 3 lines · On Tue, 30 Jun 2026 17:25:22 +0300 Igor Putko <[email protected]> wrote:

Hi SJ,

Thanks for the reply and the pointers!

Thank you for quick reply. Nonetheless, from the next time, please reply to a mail you are replying to, without top-posting [1]. Also, please wrap long lines for reasonable length of columns (say, 80 columns?)

Quoted 2 lines

Regarding the issue Sashiko AI flagged - I dug into damon/vaddr.c, and I think it's a real bug, but it's isolated to __damon_va_three_regions().
damon_va_walk_page_range() is fine here, since lock_vma_under_rcu() handles stability on its own. __damon_va_three_regions() is the problematic one: right after mmap_read_lock(mm) is taken in the caller, it sets up a VMA_ITERATOR and runs for_each_vma(). But mmap_read_lock doesn't stop the OOM reaper from running concurrently, setting MMF_UNSTABLE, and leaving empty markers in the maple tree. Walking the tree in that state without a check_stable_address_space(mm) call could lead to a NULL pointer dereference.

Thank you for detailed explanation.

Quoted 1 line

Since this looks like a separate issue, I'll prepare a dedicated fix and send it as its own patch thread, so it doesn't hold up the current cleanup. Let me know if that approach works for you.

Makes sense!

[1] https://subspace.kernel.org/etiquette.html

Thanks,
SJ

[...]