tst_test.sh: Replace GNU word boundary \b with \< in grep
PATCH 1/1 tst_test.sh: Replace GNU word boundary \b with \< in grep
From: Terence Tritton <[email protected]>
The regex word boundary extension '\b' is a GNU extension and is not supported by Toybox and lightweight POSIX regex implementations (such as Bionic libc), causing grep to fail with:
grep: bad regex '^[^#]*\bTST_': trailing backslash (\)
Replace '\b' with '\<' to ensure shell tests run correctly on lightweight environments such as Android (Toybox).
--- testcases/lib/tst_test.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
testcases/lib/tst_test.sh +2 -2
@@ -679,7 +679,7 @@ tst_run() local ret if [ -n "$TST_TEST_PATH" ]; then - for _tst_i in $(grep '^[^#]*\bTST_' "$TST_TEST_PATH" | sed "s/.*TST_//; s/$_tst_pattern//"); do + for _tst_i in $(grep '^[^#]*\<TST_' "$TST_TEST_PATH" | sed "s/.*TST_//; s/$_tst_pattern//"); do case "$_tst_i" in ALL_FILESYSTEMS|DISABLE_APPARMOR|DISABLE_SELINUX);; SETUP|CLEANUP|TESTFUNC|ID|CNT|MIN_KVER);;
@@ -701,7 +701,7 @@ tst_run() esac done - for _tst_i in $(grep '^[^#]*\b_tst_' "$TST_TEST_PATH" | sed "s/.*_tst_//; s/$_tst_pattern//"); do + for _tst_i in $(grep '^[^#]*\<_tst_' "$TST_TEST_PATH" | sed "s/.*_tst_//; s/$_tst_pattern//"); do tst_res TWARN "Private variable or function _tst_$_tst_i used!" done fi
Signature · 4 lines
2.45.2 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Terence, Wake,
Quoted 5 lines
The regex word boundary extension '\b' is a GNU extension and is not supported by Toybox and lightweight POSIX regex implementations (such as Bionic libc), causing grep to fail with:
grep: bad regex '^[^#]*\bTST_': trailing backslash (\)
Thanks, merged.
Quoted 2 lines
Replace '\b' with '\<' to ensure shell tests run correctly on lightweight environments such as Android (Toybox).
Out of curiosity, in the end you plan to use LTP shell tests? Although skipped tests did not mention any shell test, we did not expect you'd be running it. FYI tst_test.sh (aka "new API") is being slowly replaced by new "shell loader" API [2] (or tests are rewritten in C).
I also wonder if you use our new runner kirk already [3].
Kind regards,
Petr
[1] https://android.googlesource.com/platform/external/ltp/+/refs/heads/main/android/skipped-tests.txt
[2] https://linux-test-project.readthedocs.io/en/latest/developers/api_shell_tests.html
[3] https://github.com/linux-test-project/kirk
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Petr,
Quoted 2 lines · Petr Vorel
Thanks, merged.
Thanks for the fast merge!
Quoted 4 lines
Out of curiosity, in the end you plan to use LTP shell tests? Although skipped tests did not mention any shell test, we did not expect you'd be running it. FYI
tst_test.sh(aka "new API") is being slowly replaced by new "shell loader" API [2] (or tests are rewritten in C).
While Android VTS mostly runs C binaries, some test suites (like controllers.memcg_control) still source tst_test.sh. Since Android's Toybox uses Bionic libc, which strictly implements POSIX regex without GNU \b, this fix prevents regex parsing failures. It is great news that more tests are migrating to pure C.
Quoted 1 line
I also wonder if you use our new runner kirk already [3].
We haven't adopted kirk yet, as our LTP execution is deeply integrated into Google's Trade Federation (Tradefed) and VTS automation (via atest). We will definitely keep an eye on it as it evolves.
Kind regards,
Wake
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp