Skip to contentSkip to conversation

media: atomisp: fix block comment formatting style

PATCH Superseded Bohdan D. Marcus 3 participants 3 messages Jun 30 – Jul 1

Subsystems (4)
Media (V4L/DVB) Staging Intel MID (Mobile Internet Device) platform Staging - atomisp driver

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Bohdan D. Marcus

author
#0 lore raw

PATCH v2 1/1 media: atomisp: fix block comment formatting style

Fix a block comment formatting warning reported by checkpatch.pl in atomisp_cmd.c to conform to the Linux kernel coding style.

Signed-off-by Bohdan D. Marcus <[email protected]>
---
 drivers/staging/media/atomisp/pci/atomisp_cmd.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/staging/media/atomisp/pci/atomisp_cmd.c +6 -3
index 6cd500d9fd26..20abc2c0de80 100644
@@ -2520,9 +2520,12 @@ int atomisp_css_cp_dvs2_coefs(struct atomisp_sub_device *asd,
 		if (sizeof(*cur) != sizeof(dvs2_coefs.grid) ||
 		    memcmp(&dvs2_coefs.grid, cur, sizeof(dvs2_coefs.grid))) {
 			dev_err(asd->isp->dev, "dvs grid mismatch!\n");
-			/* If the grid info in the argument differs from the current
-			grid info, we tell the caller to reset the grid size and
-			try again. */
+						/*
+						 * If the grid info in the argument differs
+						 * from the current grid info, we tell the
+						 * caller to reset the grid size and try
+						 * again.
+						 */
 			return -EAGAIN;
 		}
Signature · 1 line
2.55.0
#1 lore raw
Quoted 2 lines · Bohdan D. Marcus

Fix a block comment formatting warning reported by checkpatch.pl in atomisp_cmd.c to conform to the Linux kernel coding style.

Run checkpatch on your patch.

Quoted 2 lines
Signed-off-by Bohdan D. Marcus <[email protected]>

---

There is a specific format for v2 patches.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

But the main thing is to wait a day between resends otherwise it's overwhelming for reviewers.

regards,
dan carpenter

#2 lore raw
In reply to Bohdan D. Marcus
Quoted 2 lines · Bohdan D. Marcus

Fix a block comment formatting warning reported by checkpatch.pl in atomisp_cmd.c to conform to the Linux kernel coding style.

Wrap the commit message at ~72 characters per line.

...

drivers/staging/media/atomisp/pci/atomisp_cmd.c int atomisp_css_cp_dvs2_coefs(struct atomisp_sub_device *asd, · line 2528

Quoted 9 lines
drivers/staging/media/atomisp/pci/atomisp_cmd.c +6 -3
-                       /* If the grid info in the argument differs from the current
-                       grid info, we tell the caller to reset the grid size and
-                       try again. */
+                                               /*
+                                                * If the grid info in the argument differs
+                                                * from the current grid info, we tell the
+                                                * caller to reset the grid size and try
+                                                * again.
+                                                */

Indentation is broken AFAICS.

Quoted 2 lines
                        return -EAGAIN;
                }

Also, is this the only single issue of a kind in the whole (almost 100kLoC) driver?!

Signature · 2 lines
With Best Regards,
Andy Shevchenko