Skip to contentSkip to conversation

media: qcom: iris: use disable_irq() during power-off

PATCH In review Hungyu Lin 2 participants 2 messages Jun 30

Subsystems (5)
lore
Share & tools
lore

Hungyu Lin

author
#0 lore raw

PATCH v6 1/1 media: qcom: iris: use disable_irq() during power-off

The IRQ is registered as a threaded IRQ.

Using disable_irq_nosync() in iris_vpu_power_off() does not wait for an already queued threaded IRQ handler to complete before returning.

As a result, a threaded IRQ handler may still run after the VPU has been powered down and access hardware registers after power-off.

Replace disable_irq_nosync() with disable_irq() so the power-off path waits for any in-flight threaded IRQ handler to complete before returning.

Fixes bb8a95aa038e ("media: iris: implement power management")
---
 drivers/media/platform/qcom/iris/iris_vpu_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/iris/iris_vpu_common.c +1 -1
index 69e6126dc4d9..538659284c7b 100644
@@ -236,7 +236,7 @@ void iris_vpu_power_off(struct iris_core *core)
 	iris_unset_icc_bw(core);
 
 	if (!iris_vpu_watchdog(core, core->intr_status))
-		disable_irq_nosync(core->irq);
+		disable_irq(core->irq);
 }
 
 int iris_vpu_power_on_controller(struct iris_core *core)
Signature · 1 line
2.34.1
Reviewed-by on v6 1/1
#1 lore raw
Quoted 37 lines · Hungyu Lin

The IRQ is registered as a threaded IRQ.

Using disable_irq_nosync() in iris_vpu_power_off() does not wait for an already queued threaded IRQ handler to complete before returning.

As a result, a threaded IRQ handler may still run after the VPU has been powered down and access hardware registers after power-off.

Replace disable_irq_nosync() with disable_irq() so the power-off path waits for any in-flight threaded IRQ handler to complete before returning.

Fixes bb8a95aa038e ("media: iris: implement power management")
---
  drivers/media/platform/qcom/iris/iris_vpu_common.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/iris/iris_vpu_common.c +1 -2
index 69e6126dc4d9..538659284c7b 100644
@@ -236,7 +236,7 @@ void iris_vpu_power_off(struct iris_core *core)
  	iris_unset_icc_bw(core);
 
  	if (!iris_vpu_watchdog(core, core->intr_status))
-		disable_irq_nosync(core->irq);
+		disable_irq(core->irq);
  }
 
  int iris_vpu_power_on_controller(struct iris_core *core)
--
Quoted 3 lines

2.34.1

---
bod