Skip to contentSkip to conversation

sched_ext: Parenthesize local SCX_EVENT defines to fix checkpatch error

PATCH Applied Cheng-Yang Chou 2 participants 2 messages Jun 30

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched_ext: Parenthesize local SCX_EVENT defines to fix checkpatch error

Fix checkpatch "Macros with complex values should be enclosed in parentheses" error.

---
 kernel/sched/ext/ext.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/sched/ext/ext.c +2 -2
index 0c51f9826a77..a9d23d9f5947 100644
@@ -4979,7 +4979,7 @@ static ssize_t scx_attr_events_show(struct kobject *kobj,
 	int at = 0;
 
 	scx_read_events(sch, &events);
-#define SCX_EVENT(name)	at += scx_attr_event_show(buf, at, &events, name)
+#define SCX_EVENT(name)	(at += scx_attr_event_show(buf, at, &events, name))
 	SCX_EVENTS_LIST(SCX_EVENT);
 #undef SCX_EVENT
 	return at;
@@ -10309,7 +10309,7 @@ static void scx_read_events(struct scx_sched *sch, struct scx_event_stats *event
 	memset(events, 0, sizeof(*events));
 	for_each_possible_cpu(cpu) {
 		struct scx_event_stats *e_cpu = &per_cpu_ptr(sch->pcpu, cpu)->event_stats;
-#define SCX_EVENT(name)	events->name += READ_ONCE(e_cpu->name)
+#define SCX_EVENT(name)	(events->name += READ_ONCE(e_cpu->name))
 		SCX_EVENTS_LIST(SCX_EVENT);
 #undef SCX_EVENT
 	}
Signature · 1 line
2.43.0
reviewer Applied
#1 lore raw

Hello,

Quoted 2 lines · Cheng-Yang Chou

Fix checkpatch "Macros with complex values should be enclosed in parentheses" error.

Applied to sched_ext/for-7.3.

Thanks.

--
tejun