ata: sata_dwc_460ex: cleanups and interrupt ordering fix
cover ata: sata_dwc_460ex: cleanups and interrupt ordering fix
This series modernizes the sata_dwc_460ex driver by replacing legacy OF APIs with their modern device-property and platform-device counterparts, converting old DMA resource teardown to devm-managed cleanup, fixing a latent interrupt-ordering bug, and dropping a redundant stack copy of port_info.
Patch 4 fixes a real issue: sata_dwc_enable_interrupts() was called before the IRQ handler was registered, so a probe failure or an asserted interrupt could trigger an unhandled irq storm.
Rosen Penev (5):
ata: sata_dwc_460ex: use device_property_present()
ata: sata_dwc_460ex: use platform_get_irq()
ata: sata_dwc_460ex: use devm for old DMA resource lifetime management
ata: sata_dwc_460ex: enable SATA interrupts only after IRQ handler is
registered
ata: sata_dwc_460ex: drop redundant struct copy of port_info
drivers/ata/sata_dwc_460ex.c | 66 +++++++++++++++--------------------- 1 file changed, 28 insertions(+), 38 deletions(-)
Signature · 1 line
2.55.0
PATCH 1/5 ata: sata_dwc_460ex: use device_property_present()
There's no need to use np here when dev is enough. Follows the similar pattern elsewhere where of APIs are replaced with device ones, especially when using platform_device.
--- drivers/ata/sata_dwc_460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/sata_dwc_460ex.c +1 -1
@@ -1180,7 +1180,7 @@ static int sata_dwc_probe(struct platform_device *ofdev) }#ifdef CONFIG_SATA_DWC_OLD_DMA -if (!of_property_present (np,"dmas" )) { +if (!device_property_present (dev,"dmas" )) { err =sata_dwc_dma_init_old (ofdev, hsdev);if (err)return err;
Signature · 1 line
2.55.0