Skip to contentSkip to conversation

mshv: fix hv_input_get_system_property struct

PATCH In review [email protected] 2 participants 3 messages Jun 30 – Jul 1

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 mshv: fix hv_input_get_system_property struct

From: Wei Liu <[email protected]>

Keep it in sync with the correct definition.

The old code worked by chance.

---
 include/hyperv/hvhdk_mini.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/hyperv/hvhdk_mini.h +2 -1
index b4cb2fa26e9b..035ba20870f7 100644
@@ -184,8 +184,9 @@ enum hv_dynamic_processor_feature_property {
 
 struct hv_input_get_system_property {
 	u32 property_id; /* enum hv_system_property */
+	u32 reserved;
 	union {
-		u32 as_uint32;
+		u64 as_uint64;
 #if IS_ENABLED(CONFIG_X86)
 		/* enum hv_dynamic_processor_feature_property */
 		u32 hv_processor_feature;
Signature · 1 line
2.53.0
#1 lore raw
Quoted 7 lines · On Tue, Jun 30, 2026 at 02:57:54PM -0700, [email protected] wrote:

From: Wei Liu <[email protected]>

Keep it in sync with the correct definition.

The old code worked by chance.

Any idea how far back this goes? Also, does it require a check on the hypervisor version, or was it always wrong?

Quoted 23 lines
---
 include/hyperv/hvhdk_mini.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/hyperv/hvhdk_mini.h +2 -1
index b4cb2fa26e9b..035ba20870f7 100644
@@ -184,8 +184,9 @@ enum hv_dynamic_processor_feature_property {
 
 struct hv_input_get_system_property {
 	u32 property_id; /* enum hv_system_property */
+	u32 reserved;
 	union {
-		u32 as_uint32;
+		u64 as_uint64;
 #if IS_ENABLED(CONFIG_X86)
 		/* enum hv_dynamic_processor_feature_property */
 		u32 hv_processor_feature;
Signature · 1 line
2.53.0
author maintainer
#2 lore raw
Quoted 11 lines · Hamza Mahfooz
Quoted 7 lines · On Tue, Jun 30, 2026 at 02:57:54PM -0700, [email protected] wrote:

From: Wei Liu <[email protected]>

Keep it in sync with the correct definition.

The old code worked by chance.

Any idea how far back this goes? Also, does it require a check on the hypervisor version, or was it always wrong?

This should go as far as possible. The upstream version has always been wrong.

We cannot check versions. Version numbers are not reliable indicators.

Wei

Quoted 24 lines
Quoted 24 lines
---
 include/hyperv/hvhdk_mini.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/hyperv/hvhdk_mini.h +2 -1
index b4cb2fa26e9b..035ba20870f7 100644
@@ -184,8 +184,9 @@ enum hv_dynamic_processor_feature_property {
 
 struct hv_input_get_system_property {
 	u32 property_id; /* enum hv_system_property */
+	u32 reserved;
 	union {
-		u32 as_uint32;
+		u64 as_uint64;
 #if IS_ENABLED(CONFIG_X86)
 		/* enum hv_dynamic_processor_feature_property */
 		u32 hv_processor_feature;
Signature · 1 line
2.53.0