Skip to contentSkip to conversation

ASoC: samsung: i2s: Use dev_err_probe() for iis clock error

PATCH In review [email protected] 2 participants 2 messages Jul 1 – Jul 3

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: samsung: i2s: Use dev_err_probe() for iis clock error

From: bui duc phuc <[email protected]>

Switch the iis clock error path to dev_err_probe(). This folds the dev_err() and return into a single statement and, when devm_clk_get() returns -EPROBE_DEFER, avoids logging a spurious error on every probe retry while still recording the reason in the deferred-probe debugfs.

No functional change other than the demoted log level on deferred probe; the returned error code is unchanged.

---
 sound/soc/samsung/i2s.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
sound/soc/samsung/i2s.c +4 -4
index f80f697a5d55..68fff67b9660 100644
@@ -1448,10 +1448,10 @@ static int samsung_i2s_probe(struct platform_device *pdev)
 	regs_base = res->start;
 
 	priv->clk = devm_clk_get(&pdev->dev, "iis");
-	if (IS_ERR(priv->clk)) {
-		dev_err(&pdev->dev, "Failed to get iis clock\n");
-		return PTR_ERR(priv->clk);
-	}
+	if (IS_ERR(priv->clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(priv->clk),
+				     "Failed to get iis clock\n");
+
 
 	ret = clk_prepare_enable(priv->clk);
 	if (ret != 0) {
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 1 line · On Wed, 01 Jul 2026 15:43:36 +0700, [email protected] wrote:

ASoC: samsung: i2s: Use dev_err_probe() for iis clock error

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/1] ASoC: samsung: i2s: Use dev_err_probe() for iis clock error

      https://git.kernel.org/broonie/sound/c/406e181cb325

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark