Connecting the SB600's i8259 controller rather in pasemi's pci.c than in pasemi's setup.c.
PATCH 1/1 Connecting the SB600's i8259 controller rather in pasemi's pci.c than in pasemi's setup.c.
Hello,
Here is the email without HTML (Sorry):
The Nemo board [1] doesn’t boot without this patch. Darren explained it really well:
Originally we initialised the PCI-e ports in setup arch, this is quite early, and it seems uses some kernel functions that were not recommended (They changed a whole lot of different platforms at the same time for the same reason)
After this we added the ISA bridge, then the kernel would init the IRQ contollers.
The patch that broke booting on the X1000 moved the pas_pci_init to a node in the machine description, where it called later in the boot sequence. Unfortunately this is after we've tried to add the i8259 contoller from the pas_init_IRQ. Since our ISA bridge can't be found until we've connected the PCI-e ports the system tries to write to registers that aren't yet mapped - result a kernel panic, but before console I/O has been initialised so it appears to be a hang. We had a similar problem when they were introducing Radix support.
My patch changes our code so that it works with the new kernel code in place. Basically I moved the code that adds the i8259 cascade to after we've scanned for the ISA bridge where I know it will work.
Hopefully this makes sense, shout out if it doesn't.
Regards
Darren
[1] https://en.wikipedia.org/wiki/AmigaOne_X1000
--- arch/powerpc/platforms/pasemi/pci.c | 7 +++++++ arch/powerpc/platforms/pasemi/setup.c | 7 ++++--- 2 files changed, 11 insertions(+), 3 deletions(-)
arch/powerpc/platforms/pasemi/pci.c +7 -0
@@ -25,6 +25,8 @@#define PA_PXP_CFA (bus, devfn, off) (((bus) << 20) | ((devfn) << 12) | (off)) +extern void nemo_init_IRQ (void ); +static inline int pa_pxp_offset_valid (u8 bus,u8 devfn,int offset) {/* Device 0 Function 0 is special: It's config space spans function 1 as
@@ -265,6 +267,11 @@ static int __init pas_add_bridge(struct device_node *dev)*/ isa_bridge_find_early (hose); +/* +* ISA brigde is now active, add the i8259 cascade (if needed) +*/ +nemo_init_IRQ (); +return 0 ; }
arch/powerpc/platforms/pasemi/setup.c +4 -3
@@ -214,10 +214,12 @@ static void sb600_8259_cascade(struct irq_desc *desc) chip->irq_eoi (&desc->irq_data); } -static void __init nemo_init_IRQ (struct mpic *mpic) +void nemo_init_IRQ (void ) {struct device_node *np;int gpio_virq; +struct mpic *mpic; +/* Connect the SB600's legacy i8259 controller */ np =of_find_node_by_path ("/pxp@0,e0000000" );i8259_init (np,0 );
@@ -228,6 +230,7 @@ static void __init nemo_init_IRQ(struct mpic *mpic)irq_set_chained_handler (gpio_virq, sb600_8259_cascade);mpic_unmask_irq (irq_get_irq_data (gpio_virq)); + mpic =irq_get_chip_data (gpio_virq);irq_set_default_domain (mpic->irqhost); }
@@ -298,8 +301,6 @@ static __init void pas_init_IRQ(void)mpic_unmask_irq (irq_get_irq_data (nmi_virq)); } -nemo_init_IRQ (mpic); -of_node_put (mpic_node);of_node_put (root); }
Signature · 1 line
2.55.0.windows.1
Christophe Leroy (CS GROUP)
reviewerLe 01/07/2026 à 14:59, Christian Zigotzky a écrit :
Quoted 14 lines
Hello,
Here is the email without HTML (Sorry):
The Nemo board [1] doesn’t boot without this patch. Darren explained it really well:
Originally we initialised the PCI-e ports in setup arch, this is quite early, and it seems uses some kernel functions that were not recommended (They changed a whole lot of different platforms at the same time for the same reason)
After this we added the ISA bridge, then the kernel would init the IRQ contollers.
The patch that broke booting on the X1000 moved the
pas_pci_initto a node in the machine description, where it called later in the boot sequence. Unfortunately this is after we've tried to add the i8259 contoller from thepas_init_IRQ. Since our ISA bridge can't be found until we've connected the PCI-e ports the system tries to write to registers that aren't yet mapped - result a kernel panic, but before console I/O has been initialised so it appears to be a hang. We had a similar problem when they were introducing Radix support.My patch changes our code so that it works with the new kernel code in place. Basically I moved the code that adds the i8259 cascade to after we've scanned for the ISA bridge where I know it will work.
Quoted 8 lines
Hopefully this makes sense, shout out if it doesn't.
Regards
DarrenSigned-off-by Christian Zigotzky <[email protected]>
The commit message will look strange when picking-up this email, you should resend with a cleaned commit message.
Quoted 10 lines
--- arch/powerpc/platforms/pasemi/pci.c | 7 +++++++ arch/powerpc/platforms/pasemi/setup.c | 7 ++++--- 2 files changed, 11 insertions(+), 3 deletions(-)arch/powerpc/platforms/pasemi/pci.c +0
-0
arch/powerpc/platforms/pasemi/pci.c line 29
Quoted 5 lines
arch/powerpc/platforms/pasemi/pci.c +2
-0@@ -25,6 +25,8 @@#define PA_PXP_CFA (bus, devfn, off) (((bus) << 20) | ((devfn) << 12) | (off)) +extern void nemo_init_IRQ (void ); +
Should be better in arch/powerpc/platforms/pasemi/pasemi.h
Quoted 42 lines
arch/powerpc/platforms/pasemi/pci.c +5
-0static inline int pa_pxp_offset_valid (u8 bus,u8 devfn,int offset) {/* Device 0 Function 0 is special: It's config space spans function 1 as @@ -265,6 +267,11 @@ static int __init pas_add_bridge(struct device_node *dev)*/ isa_bridge_find_early (hose); +/* +* ISA brigde is now active, add the i8259 cascade (if needed) +*/ +nemo_init_IRQ (); +return 0 ; }arch/powerpc/platforms/pasemi/setup.c +4
-1@@ -214,10 +214,12 @@ static void sb600_8259_cascade(struct irq_desc *desc) chip->irq_eoi (&desc->irq_data); } -static void __init nemo_init_IRQ (struct mpic *mpic) +void nemo_init_IRQ (void ) {struct device_node *np;int gpio_virq; +struct mpic *mpic; +/* Connect the SB600's legacy i8259 controller */ np =of_find_node_by_path ("/pxp@0,e0000000" );i8259_init (np,0 );@@ -228,6 +230,7 @@ static void __init nemo_init_IRQ(struct mpic *mpic)irq_set_chained_handler (gpio_virq, sb600_8259_cascade);mpic_unmask_irq (irq_get_irq_data (gpio_virq)); + mpic =irq_get_chip_data (gpio_virq);irq_set_default_domain (mpic->irqhost); }
arch/powerpc/platforms/pasemi/setup.c static __init void pas_init_IRQ(void) · line 306
Quoted 8 lines
arch/powerpc/platforms/pasemi/setup.c +0
-2@@ -298,8 +301,6 @@ static __init void pas_init_IRQ(void)mpic_unmask_irq (irq_get_irq_data (nmi_virq)); } -nemo_init_IRQ (mpic); -of_node_put (mpic_node);of_node_put (root); }
Build fails:
CC arch/powerpc/platforms/pasemi/setup.oarch/powerpc/platforms/pasemi/setup.c:217:6: error: no previous prototype for 'nemo_init_IRQ' [-Werror=missing-prototypes]
217 | void nemo_init_IRQ(void)
| ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[5]: *** [scripts/Makefile.build:289: arch/powerpc/platforms/pasemi/setup.o] Error 1 make[4]: *** [scripts/Makefile.build:549: arch/powerpc/platforms/pasemi] Error 2 make[3]: *** [scripts/Makefile.build:549: arch/powerpc/platforms] Error 2 make[2]: *** [scripts/Makefile.build:549: arch/powerpc] Error 2
make[1]: *** [/home/chleroy/linux-powerpc/Makefile:2184: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2
Christian Zigotzky
Tested-byQuoted 3 lines · Christophe Leroy (CS GROUP)
Should be better in
arch/powerpc/platforms/pasemi/pasemi.h
Hello Christophe,
Thank you for your answer. I modified the patch today. The Nemo board boots without any problems if I compile the RC5 of kernel 7.2 with this patch.
Could you please check the following modified patch?
Thanks,
Christian
---
powerpc/pasemi: Move Nemo i8259 initialization to pci.c
The Nemo board requires the PCIe ports to be initialized before the SB600 ISA bridge can be accessed.
Since pas_pci_init() is now called later during boot, the i8259 initialization in pas_init_IRQ() happens too early and accesses registers that are not yet mapped, preventing the board from booting.
Move the Nemo-specific i8259 initialization to pas_add_bridge(), after the ISA bridge has been discovered.
---
v2:
- Move Nemo i8259 initialization out of pas_init_IRQ() and into pas_add_bridge() after the ISA bridge has been discovered.
- Change nemo_init_IRQ() to no longer depend on the MPIC instance passed from the IRQ setup path.
- Move the nemo_init_IRQ() declaration to pasemi.h and add a no-op stub for non-Nemo builds.
- Fix missing prototype warning reported by Christophe Leroy.
- Fix indentation and clean up the commit message.
arch/powerpc/platforms/pasemi/pasemi.h 2026-07-28 07:44:31.924168227 +0200 renamed from arch/powerpc/platforms/pasemi/pasemi.h 2026-07-26 23:45:48.000000000 +0200 +0 -0
@@ -7,6 +7,12 @@ extern void pas_pci_init(void);
struct pci_dev;
extern void pas_pci_dma_dev_setup(struct pci_dev *dev);
+#ifdef CONFIG_PPC_PASEMI_NEMO
+extern void __init nemo_init_IRQ(void);
+#else
+static inline void __init nemo_init_IRQ(void) { }
+#endif
+
void __iomem *__init pasemi_pci_getcfgaddr(struct pci_dev *dev, int offset);
extern void __init pasemi_map_registers(void);
arch/powerpc/platforms/pasemi/pci.c 2026-07-28 07:34:37.036634023 +0200 renamed from arch/powerpc/platforms/pasemi/pci.c 2026-07-26 23:45:48.000000000 +0200 +0 -0
@@ -265,6 +265,11 @@ static int __init pas_add_bridge(struct
*/
isa_bridge_find_early(hose);
+ /*
+ * ISA bridge is now active, add the i8259 cascade (if needed) + */
+ nemo_init_IRQ();
+
return 0;
}
arch/powerpc/platforms/pasemi/setup.c 2026-07-28 07:54:54.147863161 +0200 renamed from arch/powerpc/platforms/pasemi/setup.c 2026-07-26 23:45:48.000000000 +0200 +0 -0
@@ -214,10 +214,12 @@ static void sb600_8259_cascade(struct ir
chip->irq_eoi(&desc->irq_data);
}
-static void __init nemo_init_IRQ(struct mpic *mpic) +void __init nemo_init_IRQ(void)
{
struct device_node *np;
int gpio_virq;
+ struct mpic *mpic;
+
/* Connect the SB600's legacy i8259 controller */ np = of_find_node_by_path("/pxp@0,e0000000"); i8259_init(np, 0);
@@ -228,14 +230,10 @@ static void __init nemo_init_IRQ(struct irq_set_chained_handler(gpio_virq, sb600_8259_cascade); mpic_unmask_irq(irq_get_irq_data(gpio_virq));
+ mpic = irq_get_chip_data(gpio_virq);
irq_set_default_domain(mpic->irqhost);
}
-#else
-
-static inline void nemo_init_IRQ(struct mpic *mpic) -{
-}
#endif
static __init void pas_init_IRQ(void)
@@ -297,9 +295,7 @@ static __init void pas_init_IRQ(void) irq_set_irq_type(nmi_virq, IRQ_TYPE_EDGE_RISING); mpic_unmask_irq(irq_get_irq_data(nmi_virq)); }
-
- nemo_init_IRQ(mpic);
-
+
of_node_put(mpic_node);
of_node_put(root);
}
Christophe Leroy (CS GROUP)
reviewerLe 28/07/2026 à 14:50, Christian Zigotzky a écrit :
Quoted 10 lines · Christophe Leroy (CS GROUP)
Quoted 3 lines
Should be better in
arch/powerpc/platforms/pasemi/pasemi.hHello Christophe,
Thank you for your answer. I modified the patch today. The Nemo board boots without any problems if I compile the RC5 of kernel 7.2 with this patch.
Could you please check the following modified patch?
b4 doesn't see it as a patch. Can you resend as a regular patch ?
$ b4 shazam --single-message [email protected] Single-message mode, ignoring any follow-ups Grabbing thread from lore.kernel.org/all/[email protected]/t.mbox.gz Analyzing 1 messages in the thread No patches found.
Thanks
Christophe
Quoted 118 lines
Thanks,
Christian---
powerpc/pasemi: Move Nemo i8259 initialization to
pci.cThe Nemo board requires the PCIe ports to be initialized before the SB600 ISA bridge can be accessed.
Since
pas_pci_init()is now called later during boot, the i8259 initialization inpas_init_IRQ()happens too early and accesses registers that are not yet mapped, preventing the board from booting.Move the Nemo-specific i8259 initialization to
pas_add_bridge(), after the ISA bridge has been discovered.Suggested-by Darren Stevens <[email protected]>Tested-by Christian Zigotzky <[email protected]>Signed-off-by Christian Zigotzky <[email protected]>---
v2:
- Move Nemo i8259 initialization out ofpas_init_IRQ()and intopas_add_bridge()after the ISA bridge has been discovered.
- Changenemo_init_IRQ()to no longer depend on the MPIC instance passed from the IRQ setup path.
- Move thenemo_init_IRQ()declaration topasemi.hand add a no-op stub for non-Nemo builds.
- Fix missing prototype warning reported by Christophe Leroy.
- Fix indentation and clean up the commit message.diff -rupN
a/arch/powerpc/platforms/pasemi/pasemi.hb/arch/powerpc/platforms/pasemi/pasemi.h--- a/arch/powerpc/platforms/pasemi/pasemi.h 2026-07-26
23:45:48.000000000 +0200
+++ b/arch/powerpc/platforms/pasemi/pasemi.h 2026-07-28
07:44:31.924168227 +0200(quoted diff) +6
-0@@ -7,6 +7,12 @@ extern void pas_pci_init(void); struct pci_dev; extern void pas_pci_dma_dev_setup(struct pci_dev *dev); +#ifdef CONFIG_PPC_PASEMI_NEMO +extern void __init nemo_init_IRQ(void); +#else +static inline void __init nemo_init_IRQ(void) { } +#endif + void __iomem *__init pasemi_pci_getcfgaddr(struct pci_dev *dev, int offset);extern void
__initpasemi_map_registers(void);
diff -rupNa/arch/powerpc/platforms/pasemi/pci.cb/arch/powerpc/platforms/pasemi/pci.c--- a/arch/powerpc/platforms/pasemi/pci.c 2026-07-26 23:45:48.000000000 +0200
+++ b/arch/powerpc/platforms/pasemi/pci.c 2026-07-28 07:34:37.036634023 +0200(quoted diff) +5
-0@@ -265,6 +265,11 @@ static int __init pas_add_bridge(struct */ isa_bridge_find_early(hose); + /* + * ISA bridge is now active, add the i8259 cascade (if needed) + */ + nemo_init_IRQ(); + return 0; }diff -rupN
a/arch/powerpc/platforms/pasemi/setup.cb/arch/powerpc/platforms/pasemi/setup.c--- a/arch/powerpc/platforms/pasemi/setup.c 2026-07-26
23:45:48.000000000 +0200
+++ b/arch/powerpc/platforms/pasemi/setup.c 2026-07-28
07:54:54.147863161 +0200(quoted diff) +5
-9@@ -214,10 +214,12 @@ static void sb600_8259_cascade(struct ir chip->irq_eoi(&desc->irq_data); } -static void __init nemo_init_IRQ(struct mpic *mpic) +void __init nemo_init_IRQ(void) { struct device_node *np; int gpio_virq; + struct mpic *mpic; + /* Connect the SB600's legacy i8259 controller */ np = of_find_node_by_path("/pxp@0,e0000000"); i8259_init(np, 0);@@ -228,14 +230,10 @@ static void __init nemo_init_IRQ(struct irq_set_chained_handler(gpio_virq, sb600_8259_cascade); mpic_unmask_irq(irq_get_irq_data(gpio_virq)); + mpic = irq_get_chip_data(gpio_virq); irq_set_default_domain(mpic->irqhost); } -#else - -static inline void nemo_init_IRQ(struct mpic *mpic) -{ -} #endif static __init void pas_init_IRQ(void)@@ -297,9 +295,7 @@ static __init void pas_init_IRQ(void) irq_set_irq_type(nmi_virq, IRQ_TYPE_EDGE_RISING); mpic_unmask_irq(irq_get_irq_data(nmi_virq)); } - - nemo_init_IRQ(mpic); - + of_node_put(mpic_node); of_node_put(root); }
kernel test robot
build botkernel test robot noticed the following build warnings:
Hi Christian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes linus/master v7.2-rc7 next-20260813] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Christian-Zigotzky/Connecting-the-SB600-s-i8259-controller-rather-in-pasemi-s-pci-c-than-in-pasemi-s-setup-c/20260813-054214 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next patch link: https://lore.kernel.org/r/20260701125941.906-2-chzigotzky%40xenosoft.de patch subject: [PATCH] Connecting the SB600's i8259 controller rather in pasemi's pci.c than in pasemi's setup.c. config: powerpc64-randconfig-r052-20260814 (https://download.01.org/0day-ci/archive/20260814/[email protected]/config) compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260814/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> arch/powerpc/platforms/pasemi/setup.c:217:6: warning: no previous prototype for function 'nemo_init_IRQ' [-Wmissing-prototypes]
217 | void nemo_init_IRQ(void)
| ^
arch/powerpc/platforms/pasemi/setup.c:217:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
217 | void nemo_init_IRQ(void)
| ^
| static 1 warning generated.
vim +/nemo_init_IRQ +217 arch/powerpc/platforms/pasemi/setup.c
216
> 217 void nemo_init_IRQ(void)
218 {
219 struct device_node *np;
220 int gpio_virq;
221 struct mpic *mpic;
222
223 /* Connect the SB600's legacy i8259 controller */
224 np = of_find_node_by_path("/pxp@0,e0000000");
225 i8259_init(np, 0);
226 of_node_put(np);
227
228 gpio_virq = irq_create_mapping(NULL, 3);
229 irq_set_irq_type(gpio_virq, IRQ_TYPE_LEVEL_HIGH);
230 irq_set_chained_handler(gpio_virq, sb600_8259_cascade);
231 mpic_unmask_irq(irq_get_irq_data(gpio_virq));
232
233 mpic = irq_get_chip_data(gpio_virq);
234 irq_set_default_domain(mpic->irqhost);
235 }
236
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Quoted 10 lines · kernel test robot
Hi Christian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes linus/master v7.2-rc7 next-20260813] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
Quoted 5 lines
All warnings (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
arch/powerpc/platforms/pasemi/setup.c:217:6: warning: no previous prototype for function 'nemo_init_IRQ' [-Wmissing-prototypes]
This is the old patch.
Here is the new patch with pasemi.h: https://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/
Thanks
Signature · 1 line
Sent with BrassMonkey 34.3.1 (https://github.com/chzigotzky/Web-Browsers-and-Suites-for-Linux-PPC/releases/tag/BrassMonkey_34.3.1)
Quoted 12 lines · Christian Zigotzky
Quoted 6 lines · kernel test robot
Hi Christian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes linus/master v7.2-rc7next-20260813]
Quoted 4 lines
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
Quoted 8 lines
Quoted 5 lines
All warnings (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
arch/powerpc/platforms/pasemi/setup.c:217:6: warning: no previousprototype for function '
nemo_init_IRQ' [-Wmissing-prototypes]This is the old patch.
Sorry about this meaningless report, we will improve the bot to check new patches to avoid such report.
Quoted 9 lines
Here is the new patch with
pasemi.h: https://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/Thanks
Signature · 1 line
Sent with BrassMonkey 34.3.1 (https://github.com/chzigotzky/Web-Browsers-and-Suites-for-Linux-PPC/releases/tag/BrassMonkey_34.3.1)
Quoted 15 lines · Philip Li
Quoted 14 lines · Christian Zigotzky
Quoted 6 lines · kernel test robot
Hi Christian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes linus/master v7.2-rc7next-20260813]
Quoted 6 lines
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
All warnings (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
arch/powerpc/platforms/pasemi/setup.c:217:6: warning: no previousprototype for function '
nemo_init_IRQ' [-Wmissing-prototypes]This is the old patch.
Sorry about this meaningless report, we will improve the bot to check new patches to avoid such report.
When will the patch be integrated into the kernel? Would it be possible to integrate the patch into kernel 7.4? Yesterday I adapted the patch for the stable long-term kernel 6.12.
Link to the patch for the kernel 6.12: https://raw.githubusercontent.com/chzigotzky/kernels/refs/heads/6_12/patches/X1000/pas_pci_init_v6.patch
-- Christian
Signature · 1 line
Sent with BrassMonkey 34.3.2.1 (https://github.com/chzigotzky/Web-Browsers-and-Suites-for-Linux-PPC/releases/tag/BrassMonkey_34.3.2.1)
Quoted 15 lines · Philip Li
Quoted 14 lines · Christian Zigotzky
Quoted 6 lines · kernel test robot
Hi Christian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes linus/master v7.2-rc7next-20260813]
Quoted 6 lines
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
Quoted 16 lines
Quoted 6 lines
Quoted 3 lines
All warnings (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
arch/powerpc/platforms/pasemi/setup.c:217:6: warning: no previousprototype for function '
nemo_init_IRQ' [-Wmissing-prototypes]This is the old patch.
Sorry about this meaningless report, we will improve the bot to check new patches to avoid such report.
Quoted 7 lines
Here is the new patch with
pasemi.h: https://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/Thanks
Hi All,
is it possible to add this patch to the kernel 7.4 too?
Thanks,
Christian
Signature · 1 line
Sent with BrassMonkey 35.0.2 (https://github.com/chzigotzky/Web-Browsers-and-Suites-for-Linux-PPC/releases/tag/BrassMonkey_35.0.2)
Quoted 27 lines · Christian Zigotzky
Quoted 26 lines · Philip Li
Quoted 12 lines · Christian Zigotzky
Quoted 6 lines · kernel test robot
Hi Christian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes linus/master v7.2-rc7next-20260813]
Quoted 4 lines
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]Quoted 8 lines
Quoted 5 lines
All warnings (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
arch/powerpc/platforms/pasemi/setup.c:217:6: warning: no previousprototype for function '
nemo_init_IRQ' [-Wmissing-prototypes]This is the old patch.
Sorry about this meaningless report, we will improve the bot to check new patches to avoid such report.
Quoted 2 lines
Here is the new patch with
pasemi.h: https://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
Thanks
Hi All,
is it possible to add this patch to the kernel 7.4 too?
This patch received reports which basically rejected the patch for inclusion and we wait for proper, fixed version, as explained in submitting patches document.
Patch also did not follow standard naming rules of commits, so again, please read the docs (submitting patches) how to properly describe and send your contribution.
Best regards,
Krzysztof
On 23 October 2026 at 08:48 am, Krzysztof Kozlowski <[email protected]> wrote:
This patch received reports which basically rejected the patch for inclusion and we wait for proper, fixed version, as explained in submitting patches document.
Patch also did not follow standard naming rules of commits, so again, please read the docs (submitting patches) how to properly describe and send your contribution.
Best regards,
Krzysztof
- - -
Hi Krzysztof,
But the patch has been ready for a long time; it has also been tested and is already in the right place: https://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/
Thanks,
Christian
Quoted 12 lines · Christian Zigotzky
On 23 October 2026 at 08:48 am, Krzysztof Kozlowski <[email protected]> wrote:
This patch received reports which basically rejected the patch for inclusion and we wait for proper, fixed version, as explained in submitting patches document.
Patch also did not follow standard naming rules of commits, so again, please read the docs (submitting patches) how to properly describe and send your contribution.
Quoted 8 lines
Best regards,
Krzysztof- - -
Hi Krzysztof,
But the patch has been ready for a long time; it has also been tested and is already in the right place: https://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/
You are referring to some other patch but replied about this one.
Best regards,
Krzysztof
On 23 October 2026 at 11:12 am Krzysztof Kozlowski <[email protected]> wrote:
You are referring to some other patch but replied about this one.
Best regards,
Krzysztof
- - -
Is the following patch OK or not?
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/
Sorry to bother you.