Skip to contentSkip to conversation

iio: hid-sensors: Fix poll_value sign check before msleep_interruptible

PATCH In review Kittisak Boonmapa 5 participants 7 messages Jul 1 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: hid-sensors: Fix poll_value sign check before msleep_interruptible

hid_sensor_read_poll_value() returns -EINVAL when the HID descriptor does not contain a Report Interval feature field.

_hid_sensor_power_state() currently treats any non-zero value as a valid delay and passes it to msleep_interruptible(). Since msleep_interruptible() takes an unsigned int, negative values are converted into very large delays.

Only sleep when poll_value is positive.

Fixes 5d9854eaea77 ("iio: hid-sensor: Store restore poll and hysteresis on S3")
Assisted-by Anthropic:Claude Sonnet 4.6

---
The bug was discovered while implementing a custom USB HID Sensor (Accelerometer 3D, HID Usage 0x200073) on a Seeed XIAO nRF52840 Sense for use with the Linux IIO subsystem and iio-sensor-proxy.

The device intentionally omitted the Report Interval feature from its HID descriptor. This causes hid_sensor_read_poll_value() to return -EINVAL, which is then treated as a non-zero delay by _hid_sensor_power_state() and passed directly to msleep_interruptible(). Since msleep_interruptible() takes an unsigned int, the negative value is converted into an unintended sleep of approximately 49.7 days.

The issue was reproduced consistently on a Steam Deck LCD running Bazzite (Linux 6.17.x), and disappeared completely after adding the Report Interval feature to the HID descriptor, confirming the root cause.

This patch changes the condition to sleep only when poll_value is strictly positive, avoiding unintended delays while preserving the existing behavior for valid poll intervals.

 drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/common/hid-sensors/hid-sensor-trigger.c +1 -1
index 417c4ab8c1b2..20099614bb27 100644
@@ -143,7 +143,7 @@ static int _hid_sensor_power_state(struct hid_sensor_common *st, bool state)
 	sensor_hub_get_feature(st->hsdev, st->power_state.report_id,
 			       st->power_state.index,
 			       sizeof(state_val), &state_val);
-	if (state && poll_value)
+	if (state && poll_value > 0)
 		msleep_interruptible(poll_value * 2);
 
 	return 0;
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Kittisak Boonmapa

hid_sensor_read_poll_value() returns -EINVAL when the HID descriptor does not contain a Report Interval feature field.

_hid_sensor_power_state() currently treats any non-zero value as a valid delay and passes it to msleep_interruptible(). Since msleep_interruptible() takes an unsigned int, negative values are converted into very large delays.

Only sleep when poll_value is positive.

Makes sense.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
Reviewed-by on v1 1/1
#2 lore raw
In reply to Kittisak Boonmapa
Quoted 10 lines · On Wed, 1 Jul 2026 22:43:19 +0700 Kittisak Boonmapa…

hid_sensor_read_poll_value() returns -EINVAL when the HID descriptor does not contain a Report Interval feature field.

_hid_sensor_power_state() currently treats any non-zero value as a valid delay and passes it to msleep_interruptible(). Since msleep_interruptible() takes an unsigned int, negative values are converted into very large delays.

Only sleep when poll_value is positive.

Quoted 7 lines
Fixes 5d9854eaea77 ("iio: hid-sensor: Store restore poll and hysteresis on S3")
Assisted-by Anthropic:Claude Sonnet 4.6

---

This bug was introduced 9 years ago!

Signature · 3 lines
Kind regards

CJD
Acked-by on v1 1/1
#3 lore raw
In reply to Kittisak Boonmapa
Quoted 10 lines · Kittisak Boonmapa

hid_sensor_read_poll_value() returns -EINVAL when the HID descriptor does not contain a Report Interval feature field.

_hid_sensor_power_state() currently treats any non-zero value as a valid delay and passes it to msleep_interruptible(). Since msleep_interruptible() takes an unsigned int, negative values are converted into very large delays.

Only sleep when poll_value is positive.

Quoted 8 lines
Fixes 5d9854eaea77 ("iio: hid-sensor: Store restore poll and

hysteresis on S3")
Closes:
https://lore.kernel.org/linux-iio/CAPr6G1qLDrgHvCNsVxj7xHxYUKkAkyo87Hq3Lfyoj3RaZ2v4dg@mail.gmail.com/

Assisted-by Anthropic:Claude Sonnet 4.6
Quoted 13 lines

---
The bug was discovered while implementing a custom USB HID Sensor (Accelerometer 3D, HID Usage 0x200073) on a Seeed XIAO nRF52840 Sense for use with the Linux IIO subsystem and iio-sensor-proxy.

The device intentionally omitted the Report Interval feature from its HID descriptor. This causes hid_sensor_read_poll_value() to return -EINVAL, which is then treated as a non-zero delay by _hid_sensor_power_state() and passed directly to msleep_interruptible(). Since msleep_interruptible() takes an unsigned int, the negative value is converted into an unintended sleep of approximately 49.7 days.

Quoted 4 lines

The issue was reproduced consistently on a Steam Deck LCD running Bazzite (Linux 6.17.x), and disappeared completely after adding the Report Interval feature to the HID descriptor, confirming the root cause.

Although Report interval is an optional field, every hub had it from the beginning.
But this change is good.

Thanks,
Srinivas

Quoted 23 lines

This patch changes the condition to sleep only when poll_value is strictly positive, avoiding unintended delays while preserving the existing behavior for valid poll intervals.

 drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/common/hid-sensors/hid-sensor-trigger.c +1 -1
index 417c4ab8c1b2..20099614bb27 100644
@@ -143,7 +143,7 @@ static int _hid_sensor_power_state(struct
 hid_sensor_common *st, bool state)
  	sensor_hub_get_feature(st->hsdev, st->power_state.report_id,
  			       st->power_state.index,
  			       sizeof(state_val), &state_val);
-	if (state && poll_value)
+	if (state && poll_value > 0)
  		msleep_interruptible(poll_value * 2);


  return 0;

maintainer
#4 lore raw
In reply to Kittisak Boonmapa
Quoted 8 lines · On Wed, 1 Jul 2026 22:43:19 +0700 Kittisak Boonmapa…

hid_sensor_read_poll_value() returns -EINVAL when the HID descriptor does not contain a Report Interval feature field.

_hid_sensor_power_state() currently treats any non-zero value as a valid delay and passes it to msleep_interruptible(). Since msleep_interruptible() takes an unsigned int, negative values are converted into very large delays.

Quoted 8 lines

Only sleep when poll_value is positive.

Fixes 5d9854eaea77 ("iio: hid-sensor: Store restore poll and hysteresis on S3")
Assisted-by Anthropic:Claude Sonnet 4.6

Bug looks to be correct, but fix it by returning much earlier. If that function is returning an error something is very wrong and we should fail at that point, not just skip a sleep later.

Quoted 5 lines

---
The bug was discovered while implementing a custom USB HID Sensor (Accelerometer 3D, HID Usage 0x200073) on a Seeed XIAO nRF52840 Sense for use with the Linux IIO subsystem and iio-sensor-proxy.

Quoted 8 lines

The device intentionally omitted the Report Interval feature from its HID descriptor. This causes hid_sensor_read_poll_value() to return -EINVAL, which is then treated as a non-zero delay by _hid_sensor_power_state() and passed directly to msleep_interruptible(). Since msleep_interruptible() takes an unsigned int, the negative value is converted into an unintended sleep of approximately 49.7 days.

For this non implemented feature, we need to explicitly handle the error and if seen put an appropriate replacement value in place. That may well be zero. I'm not sure! Setting such a 'default' value provides a place to add a comment on why we are doing so.

Jonathan

Quoted 25 lines

The issue was reproduced consistently on a Steam Deck LCD running Bazzite (Linux 6.17.x), and disappeared completely after adding the Report Interval feature to the HID descriptor, confirming the root cause.

This patch changes the condition to sleep only when poll_value is strictly positive, avoiding unintended delays while preserving the existing behavior for valid poll intervals.

 drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/common/hid-sensors/hid-sensor-trigger.c +1 -1
index 417c4ab8c1b2..20099614bb27 100644
@@ -143,7 +143,7 @@ static int _hid_sensor_power_state(struct hid_sensor_common *st, bool state)
 	sensor_hub_get_feature(st->hsdev, st->power_state.report_id,
 			       st->power_state.index,
 			       sizeof(state_val), &state_val);
-	if (state && poll_value)
+	if (state && poll_value > 0)
 		msleep_interruptible(poll_value * 2);
 
 	return 0;
#5 lore raw
Quoted 22 lines · Jonathan Cameron
Quoted 11 lines · On Wed,  1 Jul 2026 22:43:19 +0700 Kittisak Boonmapa…

hid_sensor_read_poll_value() returns -EINVAL when the HID descriptor
does not contain a Report Interval feature field.

_hid_sensor_power_state() currently treats any non-zero value as a valid delay and passes it to msleep_interruptible(). Since msleep_interruptible() takes an unsigned int, negative values are converted into very large delays.

Only sleep when poll_value is positive.

Quoted 8 lines
Fixes 5d9854eaea77 ("iio: hid-sensor: Store restore poll and

hysteresis on S3")
Closes:
https://lore.kernel.org/linux-iio/CAPr6G1qLDrgHvCNsVxj7xHxYUKkAkyo87Hq3Lfyoj3RaZ2v4dg@mail.gmail.com/

Assisted-by Anthropic:Claude Sonnet 4.6
Quoted 4 lines

Bug looks to be correct, but fix it by returning much earlier. If that function is returning an error something is very wrong and we should fail at that point, not just skip a sleep later.

Even if the report interval is not specified, but it has power state, so returning early will fail to set power state.

Thanks,
Srinivas

Quoted 51 lines
Quoted 6 lines

---
The bug was discovered while implementing a custom USB HID Sensor (Accelerometer 3D, HID Usage 0x200073) on a Seeed XIAO nRF52840 Sense
for use with the Linux IIO subsystem and iio-sensor-proxy.

Quoted 9 lines

The device intentionally omitted the Report Interval feature from its
HID descriptor. This causes hid_sensor_read_poll_value() to return -EINVAL, which is then treated as a non-zero delay by _hid_sensor_power_state() and passed directly to msleep_interruptible(). Since msleep_interruptible() takes an unsigned int, the negative value is converted into an unintended sleep of approximately 49.7 days.

For this non implemented feature, we need to explicitly handle the error and if seen put an appropriate replacement value in place. That may well be zero. I'm not sure!  Setting such a 'default' value provides a place to add a comment on why we are doing so.

Jonathan

Quoted 28 lines

The issue was reproduced consistently on a Steam Deck LCD running Bazzite (Linux 6.17.x), and disappeared completely after adding the Report Interval feature to the HID descriptor, confirming the root cause.

This patch changes the condition to sleep only when poll_value is strictly positive, avoiding unintended delays while preserving the existing behavior for valid poll intervals.

 drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/common/hid-sensors/hid-sensor-trigger.c +0 -0
index 417c4ab8c1b2..20099614bb27 100644
@@ -143,7 +143,7 @@ static int _hid_sensor_power_state(struct
 hid_sensor_common *st, bool state)

  sensor_hub_get_feature(st->hsdev, st-

Quoted 1 line

power_state.report_id,

         st->power_state.index, sizeof(state_val), &state_val);

drivers/iio/common/hid-sensors/hid-sensor-trigger.c +1 -1
-	if (state && poll_value)
+	if (state && poll_value > 0)

  msleep_interruptible(poll_value * 2);
  return 0;

maintainer
#6 lore raw
Quoted 23 lines · On Wed, 01 Jul 2026 10:59:00 -0700 srinivas pandruvada…
Quoted 22 lines · Jonathan Cameron
Quoted 19 lines · On Wed,  1 Jul 2026 22:43:19 +0700 Kittisak Boonmapa…

hid_sensor_read_poll_value() returns -EINVAL when the HID descriptor
does not contain a Report Interval feature field.

_hid_sensor_power_state() currently treats any non-zero value as a valid delay and passes it to msleep_interruptible(). Since msleep_interruptible() takes an unsigned int, negative values are converted into very large delays.

Only sleep when poll_value is positive.

Fixes 5d9854eaea77 ("iio: hid-sensor: Store restore poll and

hysteresis on S3")
Closes:
https://lore.kernel.org/linux-iio/CAPr6G1qLDrgHvCNsVxj7xHxYUKkAkyo87Hq3Lfyoj3RaZ2v4dg@mail.gmail.com/

Assisted-by Anthropic:Claude Sonnet 4.6
Quoted 7 lines
Quoted 4 lines

Bug looks to be correct, but fix it by returning much earlier. If that function is returning an error something is very wrong and we should fail at that point, not just skip a sleep later.

Even if the report interval is not specified, but it has power state, so returning early will fail to set power state.

Ah. Fair enough. In that case as below, explicitly catch the error and put a default in place rather than relying on an error code in a variable that isn't obviously going to contain one.

Jonathan

Quoted 56 lines

Thanks,
Srinivas

Quoted 51 lines
Quoted 6 lines

---
The bug was discovered while implementing a custom USB HID Sensor (Accelerometer 3D, HID Usage 0x200073) on a Seeed XIAO nRF52840 Sense
for use with the Linux IIO subsystem and iio-sensor-proxy.

Quoted 9 lines

The device intentionally omitted the Report Interval feature from its
HID descriptor. This causes hid_sensor_read_poll_value() to return -EINVAL, which is then treated as a non-zero delay by _hid_sensor_power_state() and passed directly to msleep_interruptible(). Since msleep_interruptible() takes an unsigned int, the negative value is converted into an unintended sleep of approximately 49.7 days.

For this non implemented feature, we need to explicitly handle the error and if seen put an appropriate replacement value in place. That may well be zero. I'm not sure!  Setting such a 'default' value provides a place to add a comment on why we are doing so.

Jonathan

Quoted 28 lines

The issue was reproduced consistently on a Steam Deck LCD running Bazzite (Linux 6.17.x), and disappeared completely after adding the Report Interval feature to the HID descriptor, confirming the root cause.

This patch changes the condition to sleep only when poll_value is strictly positive, avoiding unintended delays while preserving the existing behavior for valid poll intervals.

 drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/common/hid-sensors/hid-sensor-trigger.c +0 -0
index 417c4ab8c1b2..20099614bb27 100644
@@ -143,7 +143,7 @@ static int _hid_sensor_power_state(struct
 hid_sensor_common *st, bool state)

  sensor_hub_get_feature(st->hsdev, st-

Quoted 1 line

power_state.report_id,

         st->power_state.index, sizeof(state_val), &state_val);

drivers/iio/common/hid-sensors/hid-sensor-trigger.c +1 -1
-	if (state && poll_value)
+	if (state && poll_value > 0)

  msleep_interruptible(poll_value * 2);
  return 0;