Skip to contentSkip to conversation

bpf: default log level should be NOTICE

PATCH In review Stephen Hemminger 3 participants 8 messages Jul 1 – Jul 11

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 bpf: default log level should be NOTICE

BPF is used by other services now and the default log level should match other libraries.

---
 lib/bpf/bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/bpf/bpf.c +1 -1
index 740c080591..695454a2d4 100644
@@ -78,4 +78,4 @@ __rte_bpf_jit(struct rte_bpf *bpf)
 	return rc;
 }
 
-RTE_LOG_REGISTER_DEFAULT(rte_bpf_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_bpf_logtype, NOTICE);
Signature · 1 line
2.53.0
#1 lore raw

PATCH 2/2 bpf: silence noisy message

The recent loader change causes a log message every time BPF is used. For example, running dpdk-dumpcap cause:
BPF: rte_bpf_load_ex(): successfully creates ...

This is a debug message and should not normally be needed.

Fixes 55192fe168b9 ("bpf: introduce extensible load API")
---
 lib/bpf/bpf_load.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/bpf/bpf_load.c +1 -1
index 2fd0ee0720..36f6556fd5 100644
@@ -286,7 +286,7 @@ rte_bpf_load_ex(const struct rte_bpf_prm_ex *prm)
 		return NULL;
 	}
 
-	RTE_BPF_LOG_FUNC_LINE(INFO, "successfully creates %p(jit={.func=%p,.sz=%zu});",
+	RTE_BPF_LOG_FUNC_LINE(DEBUG, "successfully creates %p(jit={.func=%p,.sz=%zu});",
 		load.bpf, load.bpf->jit.raw, load.bpf->jit.sz);
 	return load.bpf;
 }
Signature · 1 line
2.53.0
Acked-by on v1 2/2
#2 lore raw

RE: [PATCH 2/2] bpf: silence noisy message

Quoted 10 lines

-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Wednesday 1 July 2026 23:35
To: [email protected]
Cc: Stephen Hemminger <[email protected]>; Konstantin Ananyev <[email protected]>; Marat Khalili <[email protected]>
Subject: [PATCH 2/2] bpf: silence noisy message

Quoted 7 lines

The recent loader change causes a log message every time BPF is used. For example, running dpdk-dumpcap cause:
BPF: rte_bpf_load_ex(): successfully creates ...

This is a debug message and should not normally be needed.

Fixes 55192fe168b9 ("bpf: introduce extensible load API")

The commit message and Fixes tag are not 100% accurate, this message existed before:
https://github.com/DPDK/dpdk/blob/09e4f37ddd0f7d5cc7c696741f31f1582c73a716/lib/bpf/bpf_load_elf.c#L331-L333

(In fact I tried to eliminate it, but had to but back at the insistence of AI reviewer and even broke the build in the process...)

So naturally I support downgrading this message. With the commit message corrected,

Quoted 21 lines
---
 lib/bpf/bpf_load.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/bpf/bpf_load.c +1 -2
index 2fd0ee0720..36f6556fd5 100644
@@ -286,7 +286,7 @@ rte_bpf_load_ex(const struct rte_bpf_prm_ex *prm)
 		return NULL;
 	}
 
-	RTE_BPF_LOG_FUNC_LINE(INFO, "successfully creates %p(jit={.func=%p,.sz=%zu});",
+	RTE_BPF_LOG_FUNC_LINE(DEBUG, "successfully creates %p(jit={.func=%p,.sz=%zu});",
 		load.bpf, load.bpf->jit.raw, load.bpf->jit.sz);
 	return load.bpf;
 }
--

2.53.0

#3 lore raw

Re: [PATCH 2/2] bpf: silence noisy message

Quoted 9 lines · On Thu, 2 Jul 2026 08:36:14 +0000 Marat Khalili <[email protected]>…

The commit message and Fixes tag are not 100% accurate, this message existed before:
https://github.com/DPDK/dpdk/blob/09e4f37ddd0f7d5cc7c696741f31f1582c73a716/lib/bpf/bpf_load_elf.c#L331-L333

(In fact I tried to eliminate it, but had to but back at the insistence of AI reviewer and even broke the build in the process...)

So naturally I support downgrading this message. With the commit message corrected,

Looks like you added that message in:
55192fe168b9 ("bpf: introduce extensible load API")

#4 lore raw

RE: [PATCH 2/2] bpf: silence noisy message

Quoted 6 lines

https://github.com/DPDK/dpdk/blob/09e4f37ddd0f7d5cc7c696741f31f1582c73a716/lib/bpf/bpf_load_elf.c#L331
-L333

Quoted 4 lines

(In fact I tried to eliminate it, but had to but back at the insistence of AI reviewer and even broke the build in the process...)

Quoted 6 lines
Quoted 3 lines

So naturally I support downgrading this message. With the commit message corrected,

Looks like you added that message in:
55192fe168b9 ("bpf: introduce extensible load API")

It was moved from a different file, see above.
Maybe it applied to fewer code paths since they are now all merged.

Anyway it's not really important unless you think it's worth backporting. Feel free to downgrade or remove this message.

#5 lore raw

Re: [PATCH 2/2] bpf: silence noisy message

02/07/2026 18:34, Marat Khalili:

Quoted 10 lines
Quoted 10 lines

https://github.com/DPDK/dpdk/blob/09e4f37ddd0f7d5cc7c696741f31f1582c73a716/lib/bpf/bpf_load_elf.c#L331
-L333

Quoted 7 lines

(In fact I tried to eliminate it, but had to but back at the insistence of AI reviewer and even broke the build in the process...)

So naturally I support downgrading this message. With the commit message corrected,

Quoted 8 lines
Quoted 2 lines

Looks like you added that message in:
55192fe168b9 ("bpf: introduce extensible load API")

It was moved from a different file, see above.
Maybe it applied to fewer code paths since they are now all merged.

Anyway it's not really important unless you think it's worth backporting. Feel free to downgrade or remove this message.

Fixes 5dba93ae5f2d ("bpf: add ability to load eBPF program from ELF object file")
Acked-by on v1 1/2
#6 lore raw
In reply to Stephen Hemminger
Quoted 27 lines

-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Wednesday 1 July 2026 23:35
To: [email protected]
Cc: Stephen Hemminger <[email protected]>; Konstantin Ananyev <[email protected]>; Marat Khalili <[email protected]>
Subject: [PATCH 1/2] bpf: default log level should be NOTICE

BPF is used by other services now and the default log level should match other libraries.

---
 lib/bpf/bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/bpf/bpf.c +1 -2
index 740c080591..695454a2d4 100644
@@ -78,4 +78,4 @@ __rte_bpf_jit(struct rte_bpf *bpf)
 	return rc;
 }
 
-RTE_LOG_REGISTER_DEFAULT(rte_bpf_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_bpf_logtype, NOTICE);
--
Quoted 1 line

2.53.0

(I wonder if this default should have a name like LIB_DEFAULT.)